You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2012/09/27 13:10:07 UTC

[jira] [Commented] (LANG-833) ToStringBuilder should use StringBuilder

    [ https://issues.apache.org/jira/browse/LANG-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464619#comment-13464619 ] 

Sebb commented on LANG-833:
---------------------------

bq. No cause for it. [i.e. StringBuffer]

StringBuffer may still be needed for snchronisation purposes.

Also if used in APIs, it may not be possible to change to StringBuilder without breaking compatibility.

But if it is possible to replace Buffer with Builder it would be sensible to do so.
                
> ToStringBuilder should use StringBuilder
> ----------------------------------------
>
>                 Key: LANG-833
>                 URL: https://issues.apache.org/jira/browse/LANG-833
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Shevek
>
> Rewriting as lang3 but still using StringBuffer (synchronized) looks like a missed opportunity. Please use StringBuilder.
> Suggest audit for uses of StringBuffer in lang3 overall. No cause for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira