[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #124: docs: describe conventional commits format

[GitBox <gi...@apache.org>]

zeroshade commented on code in PR #124:
URL: https://github.com/apache/arrow-adbc/pull/124#discussion_r970992785


##########
CONTRIBUTING.md:
##########
@@ -175,3 +172,57 @@ $ pytest -vvx
 ### Ruby
 
 The Ruby libraries are bindings around the GLib libraries.
+
+## Opening a Pull Request
+
+Before opening a pull request, please run the static checks, which are
+enforced via [`pre-commit`](https://pre-commit.com/).  This will run
+linters, formatters, and other analysis.  For example:
+
+```shell
+$ pip install pre-commit
+# Set up hooks
+$ pre-commit install
+# Run manually
+$ pre-commit run
+Check Xml............................................(no files to check)Skipped
+Check Yaml...........................................(no files to check)Skipped
+Fix End of Files.....................................(no files to check)Skipped
+Trim Trailing Whitespace.............................(no files to check)Skipped
+clang-format.........................................(no files to check)Skipped
+cmake-format.........................................(no files to check)Skipped
+cpplint..............................................(no files to check)Skipped
+Google Java Formatter................................(no files to check)Skipped
+black................................................(no files to check)Skipped
+flake8...............................................(no files to check)Skipped
+isort................................................(no files to check)Skipped
+# Hooks automatically run on commit
+$ git commit

Review Comment:
   we should probably add `go fmt` and a go linter to the pre-commit scripts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org