You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/07 04:10:51 UTC
[GitHub] [spark] zhengruifeng opened a new pull request #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
zhengruifeng opened a new pull request #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486
### What changes were proposed in this pull request?
Revert
https://github.com/apache/spark/pull/27360
https://github.com/apache/spark/pull/27396
https://github.com/apache/spark/pull/27374
https://github.com/apache/spark/pull/27389
### Why are the changes needed?
BLAS need more performace tests, specially on sparse datasets
### Does this PR introduce any user-facing change?
remove newly added param `blockSize`
### How was this patch tested?
reverted testsuites
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583226345
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22778/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583254515
**[Test build #118013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118013/testReport)** for PR 27486 at commit [`6612bb4`](https://github.com/apache/spark/commit/6612bb48a3592ae1b409cb7db7bec123dca8a11a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583255029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118013/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583255020
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583226345
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22778/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583226066
**[Test build #118013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118013/testReport)** for PR 27486 at commit [`6612bb4`](https://github.com/apache/spark/commit/6612bb48a3592ae1b409cb7db7bec123dca8a11a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583226341
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583226341
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583255020
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583228403
@HyukjinKwon OK, I will reopen a PR to test each revert commit. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583255029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118013/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583226066
**[Test build #118013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118013/testReport)** for PR 27486 at commit [`6612bb4`](https://github.com/apache/spark/commit/6612bb48a3592ae1b409cb7db7bec123dca8a11a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng opened a new pull request #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
zhengruifeng opened a new pull request #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486
### What changes were proposed in this pull request?
Revert
https://github.com/apache/spark/pull/27360
https://github.com/apache/spark/pull/27396
https://github.com/apache/spark/pull/27374
https://github.com/apache/spark/pull/27389
### Why are the changes needed?
BLAS need more performace tests, specially on sparse datasets
### Does this PR introduce any user-facing change?
remove newly added param `blockSize`
### How was this patch tested?
reverted testsuites
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27486: Revert
"[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27486: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"
URL: https://github.com/apache/spark/pull/27486#issuecomment-583227284
BTW @zhengruifeng, it might be better to revert the commits (a69f8ef, 2b27c0a, c148fae and 6612bb4) one by one manually for trackability once the tests pass and this PR is approved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org