You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Senrian (via GitHub)" <gi...@apache.org> on 2026/03/02 08:39:31 UTC

[PR] fix: use currOffset instead of nextOffset when delivery fails (ISSUE #9249) [rocketmq]

Senrian opened a new pull request, #10117:
URL: https://github.com/apache/rocketmq/pull/10117

   ## Description
   When message delivery fails in ScheduleMessageService.DeliverDelayedMessageTimerTask, the offset parameter passed to scheduleNextTimerTask was incorrect. Using nextOffset would skip the current message and potentially lose messages.
   
   ## Fix
   This fix changes to use currOffset to retry the current message immediately.
   
   ## Verification
   - Compare with version 4.9.8 which correctly passes currOffset when delivery fails
   - The bug causes message loss when delivery fails
   
   Fixes #9249


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: use currOffset instead of nextOffset when delivery fails (ISSUE #9249) [rocketmq]

Posted by "humkum (via GitHub)" <gi...@apache.org>.
humkum commented on PR #10117:
URL: https://github.com/apache/rocketmq/pull/10117#issuecomment-3990420790

   The code doesn't match the PR description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org