You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2015/11/01 23:38:27 UTC
[jira] [Commented] (DBCP-436) Avoid executing ROLLBACK when
transaction is not active
[ https://issues.apache.org/jira/browse/DBCP-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984579#comment-14984579 ]
Gary Gregory commented on DBCP-436:
-----------------------------------
Won't fix is OK by me. Drivers can optimize as they see fit. The JDBC I am writing has to deal with transaction states...
> Avoid executing ROLLBACK when transaction is not active
> -------------------------------------------------------
>
> Key: DBCP-436
> URL: https://issues.apache.org/jira/browse/DBCP-436
> Project: Commons Dbcp
> Issue Type: Improvement
> Reporter: Michael Mikhulya
> Labels: performance
> Fix For: 2.2
>
>
> {{rollbackOnReturn}} terminates the transaction by calling {{rollback}} on the connection as it is returned to the pool.
> It hurts performance.
> I suggest to don't call {{rollback}} if transaction is not active.
> Such improvement is done in HikariCP:
> https://github.com/brettwooldridge/HikariCP/issues/177
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)