You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/11/16 00:44:07 UTC
[GitHub] [calcite] hqx871 opened a new pull request #2264: fix: the equalsDeep returns wrong result
hqx871 opened a new pull request #2264:
URL: https://github.com/apache/calcite/pull/2264
The method equalsDeep of SqlCall will returns wrong result when used to compare count and count_distinct, because it does not compare the functionQuantifier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hqx871 edited a comment on pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
hqx871 edited a comment on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727793500
> Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
> Thank you for your fix. You can find more about how to contribute in https://calcite.apache.org/develop/#contributing.
> Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 edited a comment on pull request #2264: fix: the equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
danny0405 edited a comment on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727696232
Can you also log an issue here: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4263?filter=allopenissues,
Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hqx871 edited a comment on pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
hqx871 edited a comment on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727793500
> Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
> Thank you for your fix. You can find more about how to contribute in https://calcite.apache.org/develop/#contributing.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] chunweilei commented on pull request #2264: fix: the equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
chunweilei commented on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727706417
Thank you for your fix. You can find more about how to contribute in https://calcite.apache.org/develop/#contributing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2264: fix: the equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#discussion_r523864020
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlCall.java
##########
@@ -146,6 +146,9 @@ public int operandCount() {
return litmus.fail("{} != {}", this, node);
}
SqlCall that = (SqlCall) node;
+ if (!equalDeep(this.getFunctionQuantifier(), that.getFunctionQuantifier(), litmus)) {
+ return litmus.fail("{} != {}", this, node);
+ }
Review comment:
Thanks for the fix, can you also add test case there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hqx871 removed a comment on pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
hqx871 removed a comment on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727793190
> Can you also log an issue here: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4263?filter=allopenissues,
>
> Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
Thanks. I
> Can you also log an issue here: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4263?filter=allopenissues,
>
> Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on pull request #2264: fix: the equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727696232
Can you also log an issue here: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4263?filter=allopenissues,
Your commit message should be with format: [CALCITE-{issue number}] {Your title} {your GitHub account}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hqx871 commented on a change in pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
hqx871 commented on a change in pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#discussion_r524875767
##########
File path: site/_posts/2020-10-06-release-1.26.0.md
##########
@@ -30,6 +30,10 @@ The [Apache Calcite PMC]({{ site.baseurl }})
is pleased to announce
[Apache Calcite release 1.26.0]({{ site.baseurl }}/docs/history.html#v1-26-0).
+**Warning:** Calcite 1.26.0 has **severe** issues with `RexNode` simplification caused by `SEARCH operator` (
+wrong data from query optimization, `NullPointerException`), so use 1.26.0 for development only,
+and beware that Calcite 1.26.0 would corrupt your data.
Review comment:
This may be from another comtributor
##########
File path: site/_posts/2020-10-06-release-1.26.0.md
##########
@@ -30,6 +30,10 @@ The [Apache Calcite PMC]({{ site.baseurl }})
is pleased to announce
[Apache Calcite release 1.26.0]({{ site.baseurl }}/docs/history.html#v1-26-0).
+**Warning:** Calcite 1.26.0 has **severe** issues with `RexNode` simplification caused by `SEARCH operator` (
+wrong data from query optimization, `NullPointerException`), so use 1.26.0 for development only,
+and beware that Calcite 1.26.0 would corrupt your data.
Review comment:
This may be from another contributor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hqx871 commented on pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
hqx871 commented on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727793500
> Can you also log an issue here: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4263?filter=allopenissues,
>
> Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
> Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hqx871 edited a comment on pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
hqx871 edited a comment on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727793500
> Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
> Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hqx871 commented on pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
hqx871 commented on pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#issuecomment-727793190
> Can you also log an issue here: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4263?filter=allopenissues,
>
> Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
Thanks. I
> Can you also log an issue here: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4263?filter=allopenissues,
>
> Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}).
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2264:
URL: https://github.com/apache/calcite/pull/2264#discussion_r524856834
##########
File path: site/_posts/2020-10-06-release-1.26.0.md
##########
@@ -30,6 +30,10 @@ The [Apache Calcite PMC]({{ site.baseurl }})
is pleased to announce
[Apache Calcite release 1.26.0]({{ site.baseurl }}/docs/history.html#v1-26-0).
+**Warning:** Calcite 1.26.0 has **severe** issues with `RexNode` simplification caused by `SEARCH operator` (
+wrong data from query optimization, `NullPointerException`), so use 1.26.0 for development only,
+and beware that Calcite 1.26.0 would corrupt your data.
Review comment:
unnecessary change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hqx871 closed pull request #2264: [CALCITE-4402] The equalsDeep returns wrong result
Posted by GitBox <gi...@apache.org>.
hqx871 closed pull request #2264:
URL: https://github.com/apache/calcite/pull/2264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org