[GitHub] [logging-log4net] cremor commented on pull request #66: Fix net40 client profile

[GitBox <gi...@apache.org>]

cremor commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688832079


   Not directly related to this PR, but since you are modifying the preprocessor symbols (constants) here I thought I should mention this:
   SDK style projects already define various target framework related constants automatically, see https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives/preprocessor-if#remarks
   
   Some of those are the same as are now manually defined in the log4net.csproj and some are different. This might be confusing for developers who don't check if the constants are defined by the project itself.
   
   But it also seems like migration to the official constants is not that easy. Because with them it seems like the version specific constants are **not** enabled for lower versions when a higher version is built.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org