You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/17 01:20:49 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #10350: chore: enable no-unused-vars and prefer-template eslint rules
etr2460 opened a new pull request #10350:
URL: https://github.com/apache/incubator-superset/pull/10350
### SUMMARY
Sometimes I feel like eslint doesn't catch enough of my silly mistakes. Sometimes that's because my mistakes are exceedingly bad, but it turns out other times that's because we disable a bunch of the standard eslint rules from the airbnb standard set. I've re-enabled 2 in this PR, but will likely do more in the future if we think this is a good direction to go in. I'm hoping that these 2 rules are accepted by everyone, so it should be an easy change
### TEST PLAN
CI, ensure main functionality in dashboard, sql lab, and explore still works
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @ktmud @rusackas @graceguo-supercat @lilykuang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #10350: chore: enable no-unused-vars and prefer-template eslint rules
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #10350:
URL: https://github.com/apache/incubator-superset/pull/10350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10350: chore: enable no-unused-vars and prefer-template eslint rules
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10350:
URL: https://github.com/apache/incubator-superset/pull/10350#discussion_r456165670
##########
File path: superset-frontend/package.json
##########
@@ -129,7 +129,6 @@
"d3-scale": "^2.1.2",
"dnd-core": "^2.6.0",
"dom-to-image": "^2.6.0",
- "dompurify": "^2.0.7",
Review comment:
the place where i removed this was the last instance of it, so i've removed it from package.json
##########
File path: superset-frontend/src/components/TableSelector.jsx
##########
@@ -103,11 +103,11 @@ export default class TableSelector extends React.PureComponent {
});
}
- onDatabaseChange(db, selectChangeMeta) {
- return this.changeDataBase(db);
+ onDatabaseChange(db, force) {
Review comment:
@ktmud this is the only instance where instead of deleting the unused variable, I tried to fix logic that seemed to be missing. Could you confirm if this is a correct change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10350: chore: enable no-unused-vars and prefer-template eslint rules
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10350:
URL: https://github.com/apache/incubator-superset/pull/10350#discussion_r456175548
##########
File path: superset-frontend/src/components/TableSelector.jsx
##########
@@ -103,11 +103,11 @@ export default class TableSelector extends React.PureComponent {
});
}
- onDatabaseChange(db, selectChangeMeta) {
- return this.changeDataBase(db);
+ onDatabaseChange(db, force) {
Review comment:
look good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org