Re: DO NOT REPLY [Bug 39838] New: - patches to prevent integer overflow

[in...@dvholten.de]

Hi,

thanks for those well-meant hints.

Jeremias: i received the 'invitation-card', but no keys, so far - i 
thought, i would need some kind of password?
Cameron: your diagnosis is correct, the two expressions are not identical, 
but the 'safe' expression is good enough as a replacement.

code-style: there are many, i dont care too  much for a space here or 
there. The greatest layout-changes come from converting tabs to spaces
and dropping trailing blanks (thats done automatically by my intellij). To 
get the code in good shape, i would propose a clean-up session 
before/after a major release or once a year. JBuilder, IntelliJ and 
Eclipse(not sure here) or Jalopy support formatting whole directory trees. 
But, from my experience, mechanically formatting makes problems too: there 
are many places where code is neatly lined up to show a regular structure. 
Automatic formatters dont care for that...

greetings from sunny Hamburg
dieter

Re: DO NOT REPLY [Bug 39838] New: - patches to prevent integer overflow

[Jeremias Maerki <de...@jeremias-maerki.ch>]

Hi Dieter

On 21.06.2006 10:30:42 info wrote:
> Hi,
> 
> thanks for those well-meant hints.
> 
> Jeremias: i received the 'invitation-card', but no keys, so far - i 
> thought, i would need some kind of password?

You should actually receive a mail with your username and initial
password for ASF's root. Thomas told me there was some problem with your
former mail adress. I told him how best to resolve this. I hope you'll
get the initial password soon.

> Cameron: your diagnosis is correct, the two expressions are not identical, 
> but the 'safe' expression is good enough as a replacement.
> 
> code-style: there are many, i dont care too  much for a space here or 
> there. The greatest layout-changes come from converting tabs to spaces
> and dropping trailing blanks (thats done automatically by my intellij). To 
> get the code in good shape, i would propose a clean-up session 
> before/after a major release or once a year. JBuilder, IntelliJ and 
> Eclipse(not sure here) or Jalopy support formatting whole directory trees. 
> But, from my experience, mechanically formatting makes problems too: there 
> are many places where code is neatly lined up to show a regular structure. 
> Automatic formatters dont care for that...

I agree, autoformatting is often not welcome. We've made pretty good
experiences with Checkstyle in FOP (lots of plug-ins available). But I
still wait for the day that Eclipse learns to strip trailing spaces. BTW,
tab characters are reported as an error in FOP's checkstyle
configuration. tabs are evil! :-)

> greetings from sunny Hamburg
> dieter

hehe, same from sunny Lucerne, soon leaving for rainy Dublin... :-)


Jeremias Maerki


---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org