[GitHub] [hadoop] steveloughran commented on a diff in pull request #5301: HDFS-16892. Fix method name of RPC.Builder#setnumReaders

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #5301:
URL: https://github.com/apache/hadoop/pull/5301#discussion_r1093569537


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -901,7 +901,7 @@ public Builder setNumHandlers(int numHandlers) {
      * @return Default: -1.
      * @param numReaders input numReaders.
      */
-    public Builder setnumReaders(int numReaders) {
+    public Builder setNumReaders(int numReaders) {

Review Comment:
   it'll break things. at best a new method can be added, internal code moved and this one tagged as deprecated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org