You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stricklandrbls (via GitHub)" <gi...@apache.org> on 2024/01/26 20:09:16 UTC
[PR] Properly Dispose of Data Editor Session / Server [daffodil-vscode]
stricklandrbls opened a new pull request, #953:
URL: https://github.com/apache/daffodil-vscode/pull/953
If the data editor panel was closed, or a DFDL debug session terminated, the omega edit server would not be properly shut down from the data editor side.
- Implemented proper `dataEditorClient` & `WebviewPanel` disposal.
Closes #898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Properly Dispose of Data Editor Session / Server [daffodil-vscode]
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls merged PR #953:
URL: https://github.com/apache/daffodil-vscode/pull/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Properly Dispose of Data Editor Session / Server [daffodil-vscode]
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on PR #953:
URL: https://github.com/apache/daffodil-vscode/pull/953#issuecomment-1912633475
## Lingering Omega Edit Server Note
There still seems to be an issue with the Omega Edit server lingering if the user force closes the VSCode window entirely while the Data Editor has a connection to the Omega Edit Server.
I made attempts to check and kill the server upon Data Editor initialization but results only in an unresponsive Omega Edit API invocation and causes the data editor to open in an invalid state ( no associated file and port reads as 0).
### What this PR _does_ fix:
This PR fixes the issue seen where closing the Data Editor panel or terminating the debug session would not properly dispose of the Omega Edit server / Data Editor session. This resulted in the lingering server after shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org