You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/03/04 00:31:19 UTC
Review Request 18713: Initiate a teardown of scheduler lifecycle upon
application exit.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/
-----------------------------------------------------------
Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
Repository: aurora
Description
-------
AFAICT there currently isn't wiring for this, so application exit not initiated by scheduler lifecycle will not gracefully tear down components handled by SchedulerLifecycle.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1cdbff62b5348db4565388651032bf88533d9d91
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 1b1e948d95387fe6aab0a78c2b1b1744b990ba55
Diff: https://reviews.apache.org/r/18713/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner
Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon
application exit.
Posted by Bill Farner <wf...@apache.org>.
> On March 4, 2014, 2:16 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 236
> > <https://reviews.apache.org/r/18713/diff/1/?file=509104#file509104line236>
> >
> > Not sure how shutdownRegistry.addAction() fits into this specific Closure. It there anything forcing it here? If not shouldn't be one level up within the constructor body?
>
> Suman Karumuri wrote:
> +1
>
> Kevin Sweeney wrote:
> +1, I think this should happen right after the state machine is created.
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/#review36077
-----------------------------------------------------------
On March 3, 2014, 11:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18713/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 11:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AFAICT there currently isn't wiring for this, so application exit not initiated by scheduler lifecycle will not gracefully tear down components handled by SchedulerLifecycle.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1cdbff62b5348db4565388651032bf88533d9d91
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 1b1e948d95387fe6aab0a78c2b1b1744b990ba55
>
> Diff: https://reviews.apache.org/r/18713/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon
application exit.
Posted by Kevin Sweeney <ke...@apache.org>.
> On March 3, 2014, 6:16 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 236
> > <https://reviews.apache.org/r/18713/diff/1/?file=509104#file509104line236>
> >
> > Not sure how shutdownRegistry.addAction() fits into this specific Closure. It there anything forcing it here? If not shouldn't be one level up within the constructor body?
>
> Suman Karumuri wrote:
> +1
+1, I think this should happen right after the state machine is created.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/#review36077
-----------------------------------------------------------
On March 3, 2014, 3:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18713/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 3:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AFAICT there currently isn't wiring for this, so application exit not initiated by scheduler lifecycle will not gracefully tear down components handled by SchedulerLifecycle.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1cdbff62b5348db4565388651032bf88533d9d91
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 1b1e948d95387fe6aab0a78c2b1b1744b990ba55
>
> Diff: https://reviews.apache.org/r/18713/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon
application exit.
Posted by Suman Karumuri <ma...@apache.org>.
> On March 4, 2014, 2:16 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 236
> > <https://reviews.apache.org/r/18713/diff/1/?file=509104#file509104line236>
> >
> > Not sure how shutdownRegistry.addAction() fits into this specific Closure. It there anything forcing it here? If not shouldn't be one level up within the constructor body?
+1
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/#review36077
-----------------------------------------------------------
On March 3, 2014, 11:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18713/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 11:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AFAICT there currently isn't wiring for this, so application exit not initiated by scheduler lifecycle will not gracefully tear down components handled by SchedulerLifecycle.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1cdbff62b5348db4565388651032bf88533d9d91
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 1b1e948d95387fe6aab0a78c2b1b1744b990ba55
>
> Diff: https://reviews.apache.org/r/18713/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon
application exit.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/#review36077
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
<https://reviews.apache.org/r/18713/#comment66968>
Not sure how shutdownRegistry.addAction() fits into this specific Closure. It there anything forcing it here? If not shouldn't be one level up within the constructor body?
- Maxim Khutornenko
On March 3, 2014, 11:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18713/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 11:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AFAICT there currently isn't wiring for this, so application exit not initiated by scheduler lifecycle will not gracefully tear down components handled by SchedulerLifecycle.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1cdbff62b5348db4565388651032bf88533d9d91
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 1b1e948d95387fe6aab0a78c2b1b1744b990ba55
>
> Diff: https://reviews.apache.org/r/18713/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon
application exit.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/#review36890
-----------------------------------------------------------
Ship it!
Ship It!
- Suman Karumuri
On March 12, 2014, 1:26 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18713/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 1:26 a.m.)
>
>
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AFAICT there currently isn't wiring for this, so application exit not initiated by scheduler lifecycle will not gracefully tear down components handled by SchedulerLifecycle.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1cdbff62b5348db4565388651032bf88533d9d91
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 1b1e948d95387fe6aab0a78c2b1b1744b990ba55
>
> Diff: https://reviews.apache.org/r/18713/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon
application exit.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/#review36888
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On March 12, 2014, 1:26 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18713/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 1:26 a.m.)
>
>
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AFAICT there currently isn't wiring for this, so application exit not initiated by scheduler lifecycle will not gracefully tear down components handled by SchedulerLifecycle.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1cdbff62b5348db4565388651032bf88533d9d91
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 1b1e948d95387fe6aab0a78c2b1b1744b990ba55
>
> Diff: https://reviews.apache.org/r/18713/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon
application exit.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/
-----------------------------------------------------------
(Updated March 12, 2014, 1:26 a.m.)
Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
Repository: aurora
Description
-------
AFAICT there currently isn't wiring for this, so application exit not initiated by scheduler lifecycle will not gracefully tear down components handled by SchedulerLifecycle.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1cdbff62b5348db4565388651032bf88533d9d91
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 1b1e948d95387fe6aab0a78c2b1b1744b990ba55
Diff: https://reviews.apache.org/r/18713/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner