[jira] [Commented] (PARQUET-2023) TravisCI builds do not fail even when there is a compilation error

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319126#comment-17319126 ] 

ASF GitHub Bot commented on PARQUET-2023:
-----------------------------------------

martin-g opened a new pull request #890:
URL: https://github.com/apache/parquet-mr/pull/890


   Piping to pv looses the exit status of mvn and the builds never fail
   
   Run mvn in quiet mode to prevent Travis error because of too much output
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   https://issues.apache.org/jira/browse/PARQUET-2023
   
   ### Tests
   
   No modifications to the source code. Only to the CI config.
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   No new functionality!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> TravisCI builds do not fail even when there is a compilation error
> ------------------------------------------------------------------
>
>                 Key: PARQUET-2023
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2023
>             Project: Parquet
>          Issue Type: Improvement
>            Reporter: Martin Tzvetanov Grigorov
>            Priority: Minor
>
> As noticed at [https://github.com/apache/parquet-mr/pull/840] the build at TravisCI didn't fail despite the compilation errors.
>  
> The reason is the piping to 'pv' for progress monitoring. The exit status of 'mvn' command is ignored and the exit status of 'pv' is 0, i.e. success.
> Currently the build at TravisCI takes around 40 minutes ([https://travis-ci.org/github/apache/parquet-mr/builds/765496614)] so there are 10 more minutes before the upper limit at TravisCI.
> Maven will be run with '–quiet' option to prevent another error - too much output.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)