You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/26 07:51:06 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #13277: add configuration switch for federation executor engine in Apache/ShardingSphere

tristaZero commented on a change in pull request #13277:
URL: https://github.com/apache/shardingsphere/pull/13277#discussion_r736245919



##########
File path: docs/document/content/user-manual/shardingsphere-jdbc/configuration/props.en.md
##########
@@ -14,8 +14,9 @@ Apache ShardingSphere provides the way of property configuration to configure sy
 | ---------------------------------- | ----------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | --------------- |
 | sql-show (?)                       | boolean     | Whether show SQL or not in log. <br /> Print SQL details can help developers debug easier. The log details include: logic SQL, actual SQL and SQL parse result. <br /> Enable this property will log into log topic `ShardingSphere-SQL`, log level is INFO. | false           |
 | sql-simple (?)                     | boolean     | Whether show SQL details in simple style.                                                                                                                                                                                                                    | false           |
-| kernel-executor-size (?)                  | int         | The max thread size of worker group to execute SQL. One ShardingSphereDataSource will use a independent thread pool, it does not share thread pool even different data source in same JVM.                                                                   | infinite        |
+| kernel-executor-size (?)           | int         | The max thread size of worker group to execute SQL. One ShardingSphereDataSource will use a independent thread pool, it does not share thread pool even different data source in same JVM.                                                                   | infinite        |
 | max-connections-size-per-query (?) | int         | Max opened connection size for each query.                                                                                                                                                                                                                   | 1               |
 | check-table-metadata-enabled (?)   | boolean     | Whether validate table meta data consistency when application startup or updated.                                                                                                                                                                            | false           |
 | check-duplicate-table-enabled (?)  | boolean     | Whether validate duplicate table when application startup or updated.                                                                                                                                                                                        | false           |
 | sql-comment-parse-enabled (?)      | boolean     | Whether parse the comment of SQL.                                                                                                                                                                                                                            | false           |
+| federation-executor-enabled (?)    | boolean     | Whether use federation executor engine.                                                                                                                                                                                                                      | false           |

Review comment:
       How about `federated-sql-enabled` or `sql-federation-enabled` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org