[GitHub] [beam] TheNeuralBit commented on a change in pull request #14174: [BEAM-XXX] Port join extensions to Python

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #14174:
URL: https://github.com/apache/beam/pull/14174#discussion_r590679919



##########
File path: sdks/python/apache_beam/transforms/join/keyedpcollectiontuple.py
##########
@@ -0,0 +1,162 @@
+
+from typing import Any, Generic, List, TypeVar
+import apache_beam as beam
+from apache_beam.typehints import typehints
+from apache_beam.coders.coders import Coder
+
+K = TypeVar("K")
+V = TypeVar("V")
+InputT = TypeVar("InputT")
+OutputT = TypeVar("OutputT")
+
+class KeyedPCollectionTuple(Generic[K]):

Review comment:
       I think it should be possible to add the Join library to Python without porting `KeyedPCollectionTuple`. In Java this is necessary for CoGroupByKey, but in Python we represent tagged/keyed PCollections as `Dict[str, PCollection]`, you can see how this works with CoGroupByKey in that transform's API docs: https://beam.apache.org/releases/pydoc/2.28.0/apache_beam.transforms.util.html#apache_beam.transforms.util.CoGroupByKey




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org