[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1368: Refactor to remove event dispatcher completely

[GitBox <gi...@apache.org>]

Mulavar commented on a change in pull request #1368:
URL: https://github.com/apache/dubbo-go/pull/1368#discussion_r689994596



##########
File path: registry/etcdv3/service_discovery.go
##########
@@ -282,7 +287,15 @@ func (e *etcdV3ServiceDiscovery) DataChange(eventType remoting.Event) bool {
 			instance.ServiceName = ""
 		}
 
-		if err := e.DispatchEventByServiceName(instance.ServiceName); err != nil {
+		// notify instance listener instance change
+		name := instance.ServiceName // TODO, seems like ServiceName is not exactly the app name?

Review comment:
       pls deal with this ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org