You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2019/09/03 21:15:51 UTC
[GitHub] [brooklyn-client] johnmccabe commented on a change in pull request
#78: BROOKLYN-586 update br to replace obsolete jsonpath package
johnmccabe commented on a change in pull request #78: BROOKLYN-586 update br to replace obsolete jsonpath package
URL: https://github.com/apache/brooklyn-client/pull/78#discussion_r320481843
##########
File path: cli/api/locations/locations.go
##########
@@ -56,7 +56,7 @@ func DeleteLocation(network *net.Network, locationId string) (string, error) {
// WIP
func CreateLocation(network *net.Network, locationId string) (string, error) {
- url := fmt.Sprintf("/v1/locations", locationId)
Review comment:
Should be using `path.join()` when building URLs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services