You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/04/10 08:54:58 UTC
Review Request: Add vm ip in listPortForwardingRules response
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10391/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
Description
-------
Update the listPortForwardingRules API response with vm ip address.
This vm ipaddress is use ful in case multiple ip address per mic
This addresses bug CLOUDSTACK-1862.
Diffs
-----
api/src/org/apache/cloudstack/api/response/FirewallRuleResponse.java 08722ae
server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
Diff: https://reviews.apache.org/r/10391/diff/
Testing
-------
Verified the API response
Thanks,
Jayapal Reddy
Re: Review Request: Add vm ip in listPortForwardingRules response
Posted by Abhinandan Prateek <ap...@apache.org>.
> On April 10, 2013, 8:48 a.m., Abhinandan Prateek wrote:
> > Ship It!
committed. cbbba28..c8f2003 master -> master
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10391/#review18939
-----------------------------------------------------------
On April 10, 2013, 6:54 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10391/
> -----------------------------------------------------------
>
> (Updated April 10, 2013, 6:54 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Update the listPortForwardingRules API response with vm ip address.
> This vm ipaddress is use ful in case multiple ip address per mic
>
>
> This addresses bug CLOUDSTACK-1862.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/response/FirewallRuleResponse.java 08722ae
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
>
> Diff: https://reviews.apache.org/r/10391/diff/
>
>
> Testing
> -------
>
> Verified the API response
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Add vm ip in listPortForwardingRules response
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10391/#review18939
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On April 10, 2013, 6:54 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10391/
> -----------------------------------------------------------
>
> (Updated April 10, 2013, 6:54 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Update the listPortForwardingRules API response with vm ip address.
> This vm ipaddress is use ful in case multiple ip address per mic
>
>
> This addresses bug CLOUDSTACK-1862.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/response/FirewallRuleResponse.java 08722ae
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
>
> Diff: https://reviews.apache.org/r/10391/diff/
>
>
> Testing
> -------
>
> Verified the API response
>
>
> Thanks,
>
> Jayapal Reddy
>
>