[jira] [Commented] (CASSANDRA-16316) Tracing continues after session completed

["Jan Karlsson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246496#comment-17246496 ] 

Jan Karlsson commented on CASSANDRA-16316:
------------------------------------------

You are probably right about trunk. I also tried reproducing it on there without success.

As for a fix, I think something simple like calling maybeResetTraceSessionWrapper should suffice.

Something like [this|[https://github.com/apache/cassandra/compare/cassandra-3.11...itskarlsson:16316-3.11]].

I can provide patches for the other versions if needed.

> Tracing continues after session completed
> -----------------------------------------
>
>                 Key: CASSANDRA-16316
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16316
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability/Tracing
>            Reporter: Jan Karlsson
>            Assignee: Jan Karlsson
>            Priority: Normal
>             Fix For: 2.2.x, 3.0.x, 3.11.x
>
>
> We saw the system_trace.events table increasing in size continuously without any trace requests being issued.
> I traced the issue back to a specific version and patch. I believe we have removed the call to reset the trace flag in CASSANDRA-15041 which causes tracing to continue in the thread even after it is finished with the request.
> Reproduced like follows:
> 1. ccm test -n 1 -v 3.11.9
> 2. Enable authentication/authorization
> 3. Set permissions_update_interval_in_ms: 1000 (It works if this value is default value. I am guessing this is because the update is done in the calling thread)
> 4. select * from some table a bunch of times until PermissionRoleCache is refreshed
> 5. Watch system_traces.events grow
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org