[GitHub] [iceberg] kbendick edited a comment on pull request #1991: [WIP] Avro: Schema conversions should preserve docs

[GitBox <gi...@apache.org>]

kbendick edited a comment on pull request #1991:
URL: https://github.com/apache/iceberg/pull/1991#issuecomment-751543148


   So the issue with the merging manifests test appears to be that the test in question uses a hardcoded value for `commit.manifest.target-size-bytes` based on a size expected _without doc comments_. Because the manifest fields have doc comments in them, the overall size of each manifest increases and that affects the merging behavior as outlined in the test. 
   
   It's quite possible that we don't want to make this change (or at least that we don't want the doc comments in the manifest files) due to the increase in size of manifest files. I will let others weigh in on that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org