[GitHub] [spark] cloud-fan commented on a diff in pull request #39144: [SPARK-41637][SQL] ORDER BY ALL

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #39144:
URL: https://github.com/apache/spark/pull/39144#discussion_r1056029662


##########
sql/core/src/test/resources/sql-tests/inputs/order-by-all.sql:
##########
@@ -0,0 +1,44 @@
+create temporary view data as select * from values

Review Comment:
   isn't it to better to test different features in test golden files?



##########
sql/core/src/test/resources/sql-tests/inputs/order-by-all.sql:
##########
@@ -0,0 +1,44 @@
+create temporary view data as select * from values

Review Comment:
   isn't it better to test different features in test golden files?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org