You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Tibor Digana <ti...@apache.org> on 2018/03/03 11:42:48 UTC

[VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Hi,

We solved 33 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12341630

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1402/
https://repository.apache.org/content/repositories/maven-1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip

Source release checksum(s):
surefire-2.21.0-source-release.zip sha1:
6927024eefa0b8c80dee70efa014f1f421d7844b

Staging site:
http://maven.apache.org/surefire-archives/surefire-LATEST/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Cheers
Tibor

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Thx to everybody!

On Tue, Mar 6, 2018 at 2:27 PM, Tibor Digana <ti...@apache.org> wrote:

> +1
>
> On Tue, Mar 6, 2018 at 10:26 AM, Tibor Digana <ti...@apache.org>
> wrote:
>
>> Hi Herve,
>>
>> Can you send me a zip of the test which failed
>> *surefire-its/target/Surefire1177TestngParallelSuitesIT_shouldRunTwoSuitesInParallel*
>> ?
>> It is a parallelism in TestNG. I will discuss it with the guys in TestNG
>> team on GitHub.
>> Thx.
>> Tibor
>>
>>
>> On Tue, Mar 6, 2018 at 7:50 AM, Hervé BOUTEMY <he...@free.fr>
>> wrote:
>>
>>> built from sources (with classic "mvn -Prun-its verify" & Java 8) and
>>> got 2
>>> failing unit tests:
>>> Failed tests:
>>> checkFileNamesWithUnicode(org.apache.maven.surefire.its.Unic
>>> odeTestNamesIT):
>>> Did not find expected message in log
>>>   shouldRunTwoSuitesInParallel(org.apache.maven.surefire.its.j
>>> iras.Surefire1177TestngParallelSuitesIT):
>>> log pattern does not match nTimes(..)
>>>
>>> Unicode tests si already known, and I don't know for the second issue
>>>
>>> I don't see this as a blocker
>>>
>>> +1
>>>
>>> Regards,
>>>
>>> Hervé
>>>
>>> Le samedi 3 mars 2018, 12:42:48 CET Tibor Digana a écrit :
>>> > Hi,
>>> >
>>> > We solved 33 issues:
>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>> ctId=12317927&ve
>>> > rsion=12341630
>>> >
>>> > There are still a couple of issues left in JIRA:
>>> > https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUR
>>> EFIRE+AND+status
>>> > +%3D+Open+ORDER+BY+priority+DESC
>>> >
>>> > Staging repo:
>>> > https://repository.apache.org/content/repositories/maven-1402/
>>> > https://repository.apache.org/content/repositories/maven-140
>>> 2/org/apache/mav
>>> > en/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
>>> >
>>> > Source release checksum(s):
>>> > surefire-2.21.0-source-release.zip sha1:
>>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>>> >
>>> > Staging site:
>>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>>> >
>>> > Guide to testing staged releases:
>>> > http://maven.apache.org/guides/development/guide-testing-releases.html
>>> >
>>> > Vote open for 72 hours.
>>> >
>>> > [ ] +1
>>> > [ ] +0
>>> > [ ] -1
>>> >
>>> > Cheers
>>> > Tibor
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
I will fix all mentioned issues above but this one. I only guess what has
happened. So I need to have a log from Herve to make sure my guess is right.

On Tue, Mar 6, 2018 at 3:38 PM, Eric Lilja <mi...@gmail.com> wrote:

> On 2018-03-06 14:27, Tibor Digana wrote:
>
>>
>> Hi Herve,
>>>
>>> Can you send me a zip of the test which failed
>>> *surefire-its/target/Surefire1177TestngParallelSuitesIT_shou
>>> ldRunTwoSuitesInParallel*
>>> ?
>>> It is a parallelism in TestNG. I will discuss it with the guys in TestNG
>>> team on GitHub.
>>> Thx.
>>> Tibor
>>>
>>>
>>>
> Congratulations on the release, looking forward to trying it! For us who
> only read this mailing list, how was the issue mentioned above resolved
> (parallelism in TestNG)?
>
> - EL
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Eric Lilja <mi...@gmail.com>.
On 2018-03-06 14:27, Tibor Digana wrote:
>
>> Hi Herve,
>>
>> Can you send me a zip of the test which failed
>> *surefire-its/target/Surefire1177TestngParallelSuitesIT_shouldRunTwoSuitesInParallel*
>> ?
>> It is a parallelism in TestNG. I will discuss it with the guys in TestNG
>> team on GitHub.
>> Thx.
>> Tibor
>>
>>

Congratulations on the release, looking forward to trying it! For us who 
only read this mailing list, how was the issue mentioned above resolved 
(parallelism in TestNG)?

- EL

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
+1

On Tue, Mar 6, 2018 at 10:26 AM, Tibor Digana <ti...@apache.org>
wrote:

> Hi Herve,
>
> Can you send me a zip of the test which failed
> *surefire-its/target/Surefire1177TestngParallelSuitesIT_shouldRunTwoSuitesInParallel*
> ?
> It is a parallelism in TestNG. I will discuss it with the guys in TestNG
> team on GitHub.
> Thx.
> Tibor
>
>
> On Tue, Mar 6, 2018 at 7:50 AM, Hervé BOUTEMY <he...@free.fr>
> wrote:
>
>> built from sources (with classic "mvn -Prun-its verify" & Java 8) and got
>> 2
>> failing unit tests:
>> Failed tests:
>> checkFileNamesWithUnicode(org.apache.maven.surefire.its.Unic
>> odeTestNamesIT):
>> Did not find expected message in log
>>   shouldRunTwoSuitesInParallel(org.apache.maven.surefire.its.j
>> iras.Surefire1177TestngParallelSuitesIT):
>> log pattern does not match nTimes(..)
>>
>> Unicode tests si already known, and I don't know for the second issue
>>
>> I don't see this as a blocker
>>
>> +1
>>
>> Regards,
>>
>> Hervé
>>
>> Le samedi 3 mars 2018, 12:42:48 CET Tibor Digana a écrit :
>> > Hi,
>> >
>> > We solved 33 issues:
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12317927&ve
>> > rsion=12341630
>> >
>> > There are still a couple of issues left in JIRA:
>> > https://issues.apache.org/jira/i#issues/?jql=project+%3D+
>> SUREFIRE+AND+status
>> > +%3D+Open+ORDER+BY+priority+DESC
>> >
>> > Staging repo:
>> > https://repository.apache.org/content/repositories/maven-1402/
>> > https://repository.apache.org/content/repositories/maven-140
>> 2/org/apache/mav
>> > en/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
>> >
>> > Source release checksum(s):
>> > surefire-2.21.0-source-release.zip sha1:
>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>> >
>> > Staging site:
>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>> >
>> > Guide to testing staged releases:
>> > http://maven.apache.org/guides/development/guide-testing-releases.html
>> >
>> > Vote open for 72 hours.
>> >
>> > [ ] +1
>> > [ ] +0
>> > [ ] -1
>> >
>> > Cheers
>> > Tibor
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Hi Herve,

Can you send me a zip of the test which failed
*surefire-its/target/Surefire1177TestngParallelSuitesIT_shouldRunTwoSuitesInParallel*
?
It is a parallelism in TestNG. I will discuss it with the guys in TestNG
team on GitHub.
Thx.
Tibor


On Tue, Mar 6, 2018 at 7:50 AM, Hervé BOUTEMY <he...@free.fr> wrote:

> built from sources (with classic "mvn -Prun-its verify" & Java 8) and got 2
> failing unit tests:
> Failed tests:
> checkFileNamesWithUnicode(org.apache.maven.surefire.its.
> UnicodeTestNamesIT):
> Did not find expected message in log
>   shouldRunTwoSuitesInParallel(org.apache.maven.surefire.its.jiras.
> Surefire1177TestngParallelSuitesIT):
> log pattern does not match nTimes(..)
>
> Unicode tests si already known, and I don't know for the second issue
>
> I don't see this as a blocker
>
> +1
>
> Regards,
>
> Hervé
>
> Le samedi 3 mars 2018, 12:42:48 CET Tibor Digana a écrit :
> > Hi,
> >
> > We solved 33 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&ve
> > rsion=12341630
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status
> > +%3D+Open+ORDER+BY+priority+DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1402/
> > https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/mav
> > en/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
> >
> > Source release checksum(s):
> > surefire-2.21.0-source-release.zip sha1:
> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Hervé BOUTEMY <he...@free.fr>.
built from sources (with classic "mvn -Prun-its verify" & Java 8) and got 2 
failing unit tests:
Failed tests:   
checkFileNamesWithUnicode(org.apache.maven.surefire.its.UnicodeTestNamesIT): 
Did not find expected message in log
  shouldRunTwoSuitesInParallel(org.apache.maven.surefire.its.jiras.Surefire1177TestngParallelSuitesIT): 
log pattern does not match nTimes(..)

Unicode tests si already known, and I don't know for the second issue

I don't see this as a blocker

+1

Regards,

Hervé

Le samedi 3 mars 2018, 12:42:48 CET Tibor Digana a écrit :
> Hi,
> 
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&ve
> rsion=12341630
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status
> +%3D+Open+ORDER+BY+priority+DESC
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-1402/org/apache/mav
> en/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
> 
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
> 
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
> 
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> Cheers
> Tibor



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Hello Enrico,

Would you create an issue in Jira? I will fix it in the nearest release.
(Let's continue our discussion in Jira.)
Yes, it is minor issue however annoying because you see the dump file.
Details: The only problem is the order of these two lines. First line
writes to a native Std/Out and second line wraps the stream to surefire
format:

*Filter filter = jUnit48Reflector.isJUnit48Available() ?
createJUnit48Filter() : null;createRunListener( reporterFactory,
consoleStream )*

Cheers
Tibor

On Sun, Mar 4, 2018 at 9:14 AM, Enrico Olivelli <eo...@gmail.com> wrote:

> Using the '-Dgroups' parameter I get this warning.
> It seems not a showstopper but the fix may be simple.
> Surefire itself is corrupting stdout while writing a WARNING.
> It is related to my issue
> https://issues.apache.org/jira/plugins/servlet/mobile#issue/SUREFIRE-1453
>
>
> Thoughts?
> Enrico
>
>
> # Created on 2018-03-04T08:36:54.490
> Corrupted STDOUT by directly writing to native stream in forked JVM 1.
> Stream '[WARNING] Couldn't load group class 'MinimumAcceptance' in
> Surefire|Failsafe plugin. The group class is ignored!'.
> java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma
> after third character in command '[WARNING] Couldn't load group class
> 'MinimumAcceptance' in Surefire|Failsafe plugin. The group class is
> ignored!'.
> at
> org.apache.maven.plugin.surefire.booterclient.output.
> ForkClient$OperationalData.<init>(ForkClient.java:511)
> at
> org.apache.maven.plugin.surefire.booterclient.output.
> ForkClient.processLine(ForkClient.java:209)
> at
> org.apache.maven.plugin.surefire.booterclient.output.
> ForkClient.consumeLine(ForkClient.java:176)
> at
> org.apache.maven.plugin.surefire.booterclient.output.
> ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
> at java.base/java.lang.Thread.run(Thread.java:844)
> Il sab 3 mar 2018, 13:34 Tibor Digana <ti...@apache.org> ha scritto:
>
> > Maybe disappointed a bit on how we run the build with Java 1.8 and
> another
> > J7 - J10 used in all Tests (unit + integration tests).
> > $ mvn install -P run-its -nsu -Dintegration-test-port=8000
> > -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program
> Files\Java\jdk10"
> > -Djacoco.skip=true
> > There were several reasons.
> > Maven plugins failed with J9, JUnit 5 Provider in future Surefire
> requires
> > J8, and the last is the JavaDoc check which runs within JavaC and it
> forced
> > the contributors to write JavaDoc correctly in the beginning of
> > development.
> >
> > T
> >
> > On Sat, Mar 3, 2018 at 12:48 PM, Tibor Digana <ti...@apache.org>
> > wrote:
> >
> > > Typo, the version is 2.21.0 of course.
> > >
> > > On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <ti...@apache.org>
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> We solved 33 issues:
> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> > >> ctId=12317927&version=12341630
> > >>
> > >> There are still a couple of issues left in JIRA:
> > >> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
> > >> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> > >>
> > >> Staging repo:
> > >> https://repository.apache.org/content/repositories/maven-1402/
> > >> https://repository.apache.org/content/repositories/maven-140
> > >> 2/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.
> > >> 0-source-release.zip
> > >>
> > >> Source release checksum(s):
> > >> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1
> > >> f421d7844b
> > >>
> > >> Staging site:
> > >> http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >>
> > >> Guide to testing staged releases:
> > >> http://maven.apache.org/guides/development/guide-
> testing-releases.html
> > >>
> > >> Vote open for 72 hours.
> > >>
> > >> [ ] +1
> > >> [ ] +0
> > >> [ ] -1
> > >>
> > >> Cheers
> > >> Tibor
> > >>
> > >
> > >
> >
> --
>
>
> -- Enrico Olivelli
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Enrico Olivelli <eo...@gmail.com>.
Using the '-Dgroups' parameter I get this warning.
It seems not a showstopper but the fix may be simple.
Surefire itself is corrupting stdout while writing a WARNING.
It is related to my issue
https://issues.apache.org/jira/plugins/servlet/mobile#issue/SUREFIRE-1453


Thoughts?
Enrico


# Created on 2018-03-04T08:36:54.490
Corrupted STDOUT by directly writing to native stream in forked JVM 1.
Stream '[WARNING] Couldn't load group class 'MinimumAcceptance' in
Surefire|Failsafe plugin. The group class is ignored!'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma
after third character in command '[WARNING] Couldn't load group class
'MinimumAcceptance' in Surefire|Failsafe plugin. The group class is
ignored!'.
at
org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:511)
at
org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:209)
at
org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:176)
at
org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:844)
Il sab 3 mar 2018, 13:34 Tibor Digana <ti...@apache.org> ha scritto:

> Maybe disappointed a bit on how we run the build with Java 1.8 and another
> J7 - J10 used in all Tests (unit + integration tests).
> $ mvn install -P run-its -nsu -Dintegration-test-port=8000
> -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10"
> -Djacoco.skip=true
> There were several reasons.
> Maven plugins failed with J9, JUnit 5 Provider in future Surefire requires
> J8, and the last is the JavaDoc check which runs within JavaC and it forced
> the contributors to write JavaDoc correctly in the beginning of
> development.
>
> T
>
> On Sat, Mar 3, 2018 at 12:48 PM, Tibor Digana <ti...@apache.org>
> wrote:
>
> > Typo, the version is 2.21.0 of course.
> >
> > On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <ti...@apache.org>
> > wrote:
> >
> >> Hi,
> >>
> >> We solved 33 issues:
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> >> ctId=12317927&version=12341630
> >>
> >> There are still a couple of issues left in JIRA:
> >> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
> >> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1402/
> >> https://repository.apache.org/content/repositories/maven-140
> >> 2/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.
> >> 0-source-release.zip
> >>
> >> Source release checksum(s):
> >> surefire-2.21.0-source-release.zip sha1: 6927024eefa0b8c80dee70efa014f1
> >> f421d7844b
> >>
> >> Staging site:
> >> http://maven.apache.org/surefire-archives/surefire-LATEST/
> >>
> >> Guide to testing staged releases:
> >> http://maven.apache.org/guides/development/guide-testing-releases.html
> >>
> >> Vote open for 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Cheers
> >> Tibor
> >>
> >
> >
>
-- 


-- Enrico Olivelli

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Maybe disappointed a bit on how we run the build with Java 1.8 and another
J7 - J10 used in all Tests (unit + integration tests).
$ mvn install -P run-its -nsu -Dintegration-test-port=8000
-Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10"
-Djacoco.skip=true
There were several reasons.
Maven plugins failed with J9, JUnit 5 Provider in future Surefire requires
J8, and the last is the JavaDoc check which runs within JavaC and it forced
the contributors to write JavaDoc correctly in the beginning of development.

T

On Sat, Mar 3, 2018 at 12:48 PM, Tibor Digana <ti...@apache.org>
wrote:

> Typo, the version is 2.21.0 of course.
>
> On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <ti...@apache.org>
> wrote:
>
>> Hi,
>>
>> We solved 33 issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12317927&version=12341630
>>
>> There are still a couple of issues left in JIRA:
>> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
>> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1402/
>> https://repository.apache.org/content/repositories/maven-140
>> 2/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.
>> 0-source-release.zip
>>
>> Source release checksum(s):
>> surefire-2.21.0-source-release.zip sha1: 6927024eefa0b8c80dee70efa014f1
>> f421d7844b
>>
>> Staging site:
>> http://maven.apache.org/surefire-archives/surefire-LATEST/
>>
>> Guide to testing staged releases:
>> http://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Cheers
>> Tibor
>>
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Typo, the version is 2.21.0 of course.

On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <ti...@apache.org>
wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1: 6927024eefa0b8c80dee70efa014f1
> f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.21.0

Posted by Tibor Digana <ti...@apache.org>.
Thx Robert for your voice in the release vote.

Cheers
Tibor

On Sun, Mar 4, 2018 at 3:47 PM, Robert Scholte <rf...@apache.org> wrote:

> +1
>
> On Sat, 03 Mar 2018 12:42:48 +0100, Tibor Digana <ti...@apache.org>
> wrote:
>
> Hi,
>>
>> We solved 33 issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12317927&version=12341630
>>
>> There are still a couple of issues left in JIRA:
>> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
>> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1402/
>> https://repository.apache.org/content/repositories/maven-140
>> 2/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.
>> 0-source-release.zip
>>
>> Source release checksum(s):
>> surefire-2.21.0-source-release.zip sha1:
>> 6927024eefa0b8c80dee70efa014f1f421d7844b
>>
>> Staging site:
>> http://maven.apache.org/surefire-archives/surefire-LATEST/
>>
>> Guide to testing staged releases:
>> http://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Cheers
>> Tibor
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.21.0

Posted by Robert Scholte <rf...@apache.org>.
+1

On Sat, 03 Mar 2018 12:42:48 +0100, Tibor Digana <ti...@apache.org>  
wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Fwd: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
 Hello Karl,

I was not able to reproduce it on mine and CI platforms.
Enrico, our user and developer, reported the same issue like you.

This assertion statement should be turned to Japanese test name:
*surefireReportFile.assertContainsText( "junit.twoTestCases.????Test" );*

So I changed the assertion statement to Japanese already and added property
outputEncoding=UTF-8 for reports in the IT's POM in the branch
*UnicodeTestNamesIT3*.
I think this would be the right fix of the IT.

The build will take only cca 5 minutes to complete because the only one IT
is important to run (mvn install -nsu).
Can you please re-run the build on the platforms where you initially
reproduced this issue?
Thx for help.

Cheers
Tibor

---------- Forwarded message ----------
From: Karl Heinz Marbaise <kh...@gmx.de>
Date: Sun, Mar 4, 2018 at 10:39 PM
Subject: Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1
To: Maven Developers List <de...@maven.apache.org>, Tibor Digana <
tibordigana@apache.org>


Hi,

The only issue I have found is that the following test:

checkFileNamesWithUnicode(org.apache.maven.surefire.its.UnicodeTestNamesIT):
Did not find expected message in log

seemed to be failing on my Mac overall Maven versions and JDK versions..


JDK 8  Maven 3.1.X, 3.2.X, 3.3.X, 3.5.X

otherwise Vote +1 for this release.

kind regards
Karl Heinz Marbaise


On 03/03/18 12:42, Tibor Digana wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> ctId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-140
> 2/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.
> 0-source-release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi,

The only issue I have found is that the following test:

checkFileNamesWithUnicode(org.apache.maven.surefire.its.UnicodeTestNamesIT): 
Did not find expected message in log

seemed to be failing on my Mac overall Maven versions and JDK versions..


JDK 8  Maven 3.1.X, 3.2.X, 3.3.X, 3.5.X

otherwise Vote +1 for this release.

kind regards
Karl Heinz Marbaise

On 03/03/18 12:42, Tibor Digana wrote:
> Hi,
> 
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12341630
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
> 
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
> 
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
> 
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> Cheers
> Tibor
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (non binding)

Tested on Fedora 26/27, with J9 and J10 on my applications.

Built from surces, got only error on Unicode names tests (already known
issue)

Great !
Enrico

Il lun 5 mar 2018, 07:11 Olivier Lamy <ol...@apache.org> ha scritto:

> +1
>
> On 3 March 2018 at 21:42, Tibor Digana <ti...@apache.org> wrote:
>
> > Hi,
> >
> > We solved 33 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12317927&version=12341630
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/i#issues/?jql=project+%
> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1402/
> > https://repository.apache.org/content/repositories/maven-
> > 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> > release.zip
> >
> > Source release checksum(s):
> > surefire-2.21.0-source-release.zip sha1:
> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
-- 


-- Enrico Olivelli

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Olivier Lamy <ol...@apache.org>.
+1

On 3 March 2018 at 21:42, Tibor Digana <ti...@apache.org> wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Stephane Nicoll <st...@gmail.com>.
+1 (also tested on JDK10)

Thanks,
S.

On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <ti...@apache.org>
wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Jeff Jensen <je...@upstairstechnology.com>.
 Thanks for the link Tibor (didn't know there was an open infra issue you
were working on).  Based on that JIRA comment, they have done what I was
suggesting for Windows line lengths.

> The error message is Caused by: java.io.IOException: CreateProcess
error=5, Access is denied
Yes, need to find the "Access is denied" cause.  I looked at the log and
posted a couple of initial thoughts on the ticket.


On Sat, Mar 17, 2018 at 12:48 PM, Tibor Digana <ti...@apache.org>
wrote:

> Hi Jeff,
>
> The entire problem is when trying to run a forked sub-process via
> ProcessBuilder.start().
> The error message is
> Caused by: java.io.IOException: CreateProcess error=5, Access is denied
>
> I found a sort of similar issue reported for Java 9 as well:
> https://bugs.openjdk.java.net/browse/JDK-8168275
>
> Cheers
> Tibor
>
> On Sat, Mar 17, 2018 at 6:12 PM, Tibor Digana <ti...@apache.org>
> wrote:
>
>> Hi Jeff,
>>
>> I am not an expert for Windows internals. Here is the statement [1] given
>> by our INFRA team. Do you think they performed same setting you have
>> proposed?
>> If it is different, you can maybe reply on JIRA and give them the hint.
>> [1]:
>> https://issues.apache.org/jira/browse/INFRA-16191?focusedCom
>> mentId=16402016&page=com.atlassian.jira.plugin.system.
>> issuetabpanels:comment-tabpanel#comment-16402016
>>
>> We do not have long paths in Git repo hopefully. The situation is that we
>> copy some sources to a newly created folder in runtime:
>> surefire-its/target/<created-test-folder>/src/main/java/...
>>
>> Then this exceeds the length. The copy is done by Java process JDK 1.8.
>>
>> Cheers
>> Tibor
>>
>>
>>
>>
>>
>> On Sat, Mar 17, 2018 at 5:52 PM, Jeff Jensen <
>> jeffjensen@upstairstechnology.com> wrote:
>>
>>> Hi Tibor,
>>>
>>> > I should maybe write some limitations regarding length of IT
>>> class/method/package and length of Git branch name in README.md due to
>>> problems with Windows paths length.
>>>
>>> In case this helps: instead of shortening names for the Windows path
>>> length
>>> limitation, we can configure Windows and Git:
>>>
>>> 1. For recent Windows versions, set this to 1 (0 is
>>> disabled): HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSyst
>>> em
>>> -> LongPathsEnabled
>>>
>>> 2.  git config --global core.longpaths true
>>>   Caveat per git doc and mitigated with step 1:
>>>
>>> Enable long path (> 260) support for builtin commands in Git for Windows.
>>> This is disabled by default, as long paths are not supported by Windows
>>> Explorer, cmd.exe and the Git for Windows tool chain (msys, bash, tcl,
>>> perl…​). Only enable this if you know what you’re doing and are prepared
>>> to
>>> live with a few quirks.
>>>
>>> On Sat, Mar 17, 2018 at 11:12 AM, Tibor Digana <ti...@apache.org>
>>> wrote:
>>>
>>> > I will push the Jira 1490 first.
>>> > Sorry it took some time. Last days we solved issues INFRA-16168 and
>>> > INFRA-16191.
>>> > I should maybe write some limitations regarding length of IT
>>> > class/method/package and length of Git branch name in README.md due to
>>> > problems with Windows paths length.
>>> >
>>> > On Fri, Mar 9, 2018 at 11:12 AM, Enrico Olivelli <eo...@gmail.com>
>>> > wrote:
>>> >
>>> > > 2018-03-09 9:55 GMT+01:00 Tibor Digana <ti...@apache.org>:
>>> > >
>>> > > > Hi Enrico, Karl, Herve,
>>> > > >
>>> > > > We reported the issues [1] found during the Vote. They are fixed in
>>> > > > branches [2] and CI builds [3].
>>> > > > We can make a code review.
>>> > > > Additionally, we fixed SUREFIRE-1490 which was in progress but we
>>> did
>>> > not
>>> > > > have spare time to include it in the Release 2.21.0. Now it is
>>> fixed in
>>> > > [4].
>>> > > >
>>> > >
>>> > >
>>> > >
>>> > > Thank you Tibor,
>>> > > I did not have time to create issues yet and you already have
>>> resolved
>>> > them
>>> > > !!
>>> > >
>>> > > I can confirm that I am now using 2.21.0 and I am really happy with
>>> it.
>>> > >
>>> > > I have reviewed your commits and they looks good to me,
>>> > > today I do not have time to test your fixes on my "real" projects but
>>> > > surely I will do it next week, I guess we will not release 3.0.0M1
>>> > > immediately
>>> > >
>>> > > Cheers
>>> > > Enrico
>>> > >
>>> > >
>>> > >
>>> > > >
>>> > > > [1]:
>>> > > > https://issues.apache.org/jira/browse/SUREFIRE-1495
>>> > > > https://issues.apache.org/jira/browse/SUREFIRE-1498
>>> > > >
>>> > > > [2]:
>>> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
>>> > > surefire.git;a=commit;h=
>>> > > > c496ebf3b4518c25787d5eac9f54b2a220a59447
>>> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
>>> > > surefire.git;a=commit;h=
>>> > > > af7ae9ef933873a038b2817d6430859f2a5bd1c7
>>> > > >
>>> > > > [3]:
>>> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
>>> > > > job/SUREFIRE-1495/4/
>>> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
>>> > > > job/SUREFIRE-1498/1/
>>> > > >
>>> > > > [4]:
>>> > > > https://issues.apache.org/jira/browse/SUREFIRE-1490
>>> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
>>> > > surefire.git;a=commit;h=
>>> > > > 6174be76f52ffc2873a18a5215f60767843d7479
>>> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
>>> > > > job/SUREFIRE-1490/2/
>>> > > >
>>> > > > Cheers
>>> > > > Tibor
>>> > > >
>>> > > >
>>> > > > On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <
>>> tibordigana@apache.org>
>>> > > > wrote:
>>> > > >
>>> > > >> Hello Gary, yes but my typo was corrected in the second e-mail.
>>> > > >>
>>> > > >> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <
>>> garydgregory@gmail.com>
>>> > > >> wrote:
>>> > > >>
>>> > > >>> This thread has the wrong VERSION in its subject.
>>> > > >>>
>>> > > >>> Gary
>>> > > >>>
>>> > > >>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <
>>> tibordigana@apache.org
>>> > >
>>> > > >>> wrote:
>>> > > >>>
>>> > > >>> > Hi,
>>> > > >>> >
>>> > > >>> > We solved 33 issues:
>>> > > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>> > > >>> > projectId=12317927&version=12341630
>>> > > >>> >
>>> > > >>> > There are still a couple of issues left in JIRA:
>>> > > >>> > https://issues.apache.org/jira/i#issues/?jql=project+%
>>> > > >>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>>> > > >>> >
>>> > > >>> > Staging repo:
>>> > > >>> > https://repository.apache.org/content/repositories/maven-1402/
>>> > > >>> > https://repository.apache.org/content/repositories/maven-
>>> > > >>> > 1402/org/apache/maven/surefire/surefire/2.21.0/
>>> > > surefire-2.21.0-source-
>>> > > >>> > release.zip
>>> > > >>> >
>>> > > >>> > Source release checksum(s):
>>> > > >>> > surefire-2.21.0-source-release.zip sha1:
>>> > > >>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>>> > > >>> >
>>> > > >>> > Staging site:
>>> > > >>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>>> > > >>> >
>>> > > >>> > Guide to testing staged releases:
>>> > > >>> > http://maven.apache.org/guides/development/guide-
>>> > > testing-releases.html
>>> > > >>> >
>>> > > >>> > Vote open for 72 hours.
>>> > > >>> >
>>> > > >>> > [ ] +1
>>> > > >>> > [ ] +0
>>> > > >>> > [ ] -1
>>> > > >>> >
>>> > > >>> > Cheers
>>> > > >>> > Tibor
>>> > > >>> >
>>> > > >>>
>>> > > >>
>>> > > >>
>>> > > >
>>> > >
>>> >
>>>
>>
>>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Hi Jeff,

The entire problem is when trying to run a forked sub-process via
ProcessBuilder.start().
The error message is
Caused by: java.io.IOException: CreateProcess error=5, Access is denied

I found a sort of similar issue reported for Java 9 as well:
https://bugs.openjdk.java.net/browse/JDK-8168275

Cheers
Tibor

On Sat, Mar 17, 2018 at 6:12 PM, Tibor Digana <ti...@apache.org>
wrote:

> Hi Jeff,
>
> I am not an expert for Windows internals. Here is the statement [1] given
> by our INFRA team. Do you think they performed same setting you have
> proposed?
> If it is different, you can maybe reply on JIRA and give them the hint.
> [1]:
> https://issues.apache.org/jira/browse/INFRA-16191?
> focusedCommentId=16402016&page=com.atlassian.jira.
> plugin.system.issuetabpanels:comment-tabpanel#comment-16402016
>
> We do not have long paths in Git repo hopefully. The situation is that we
> copy some sources to a newly created folder in runtime:
> surefire-its/target/<created-test-folder>/src/main/java/...
>
> Then this exceeds the length. The copy is done by Java process JDK 1.8.
>
> Cheers
> Tibor
>
>
>
>
>
> On Sat, Mar 17, 2018 at 5:52 PM, Jeff Jensen <jeffjensen@
> upstairstechnology.com> wrote:
>
>> Hi Tibor,
>>
>> > I should maybe write some limitations regarding length of IT
>> class/method/package and length of Git branch name in README.md due to
>> problems with Windows paths length.
>>
>> In case this helps: instead of shortening names for the Windows path
>> length
>> limitation, we can configure Windows and Git:
>>
>> 1. For recent Windows versions, set this to 1 (0 is
>> disabled): HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem
>> -> LongPathsEnabled
>>
>> 2.  git config --global core.longpaths true
>>   Caveat per git doc and mitigated with step 1:
>>
>> Enable long path (> 260) support for builtin commands in Git for Windows.
>> This is disabled by default, as long paths are not supported by Windows
>> Explorer, cmd.exe and the Git for Windows tool chain (msys, bash, tcl,
>> perl…​). Only enable this if you know what you’re doing and are prepared
>> to
>> live with a few quirks.
>>
>> On Sat, Mar 17, 2018 at 11:12 AM, Tibor Digana <ti...@apache.org>
>> wrote:
>>
>> > I will push the Jira 1490 first.
>> > Sorry it took some time. Last days we solved issues INFRA-16168 and
>> > INFRA-16191.
>> > I should maybe write some limitations regarding length of IT
>> > class/method/package and length of Git branch name in README.md due to
>> > problems with Windows paths length.
>> >
>> > On Fri, Mar 9, 2018 at 11:12 AM, Enrico Olivelli <eo...@gmail.com>
>> > wrote:
>> >
>> > > 2018-03-09 9:55 GMT+01:00 Tibor Digana <ti...@apache.org>:
>> > >
>> > > > Hi Enrico, Karl, Herve,
>> > > >
>> > > > We reported the issues [1] found during the Vote. They are fixed in
>> > > > branches [2] and CI builds [3].
>> > > > We can make a code review.
>> > > > Additionally, we fixed SUREFIRE-1490 which was in progress but we
>> did
>> > not
>> > > > have spare time to include it in the Release 2.21.0. Now it is
>> fixed in
>> > > [4].
>> > > >
>> > >
>> > >
>> > >
>> > > Thank you Tibor,
>> > > I did not have time to create issues yet and you already have resolved
>> > them
>> > > !!
>> > >
>> > > I can confirm that I am now using 2.21.0 and I am really happy with
>> it.
>> > >
>> > > I have reviewed your commits and they looks good to me,
>> > > today I do not have time to test your fixes on my "real" projects but
>> > > surely I will do it next week, I guess we will not release 3.0.0M1
>> > > immediately
>> > >
>> > > Cheers
>> > > Enrico
>> > >
>> > >
>> > >
>> > > >
>> > > > [1]:
>> > > > https://issues.apache.org/jira/browse/SUREFIRE-1495
>> > > > https://issues.apache.org/jira/browse/SUREFIRE-1498
>> > > >
>> > > > [2]:
>> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
>> > > surefire.git;a=commit;h=
>> > > > c496ebf3b4518c25787d5eac9f54b2a220a59447
>> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
>> > > surefire.git;a=commit;h=
>> > > > af7ae9ef933873a038b2817d6430859f2a5bd1c7
>> > > >
>> > > > [3]:
>> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
>> > > > job/SUREFIRE-1495/4/
>> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
>> > > > job/SUREFIRE-1498/1/
>> > > >
>> > > > [4]:
>> > > > https://issues.apache.org/jira/browse/SUREFIRE-1490
>> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
>> > > surefire.git;a=commit;h=
>> > > > 6174be76f52ffc2873a18a5215f60767843d7479
>> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
>> > > > job/SUREFIRE-1490/2/
>> > > >
>> > > > Cheers
>> > > > Tibor
>> > > >
>> > > >
>> > > > On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <
>> tibordigana@apache.org>
>> > > > wrote:
>> > > >
>> > > >> Hello Gary, yes but my typo was corrected in the second e-mail.
>> > > >>
>> > > >> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <
>> garydgregory@gmail.com>
>> > > >> wrote:
>> > > >>
>> > > >>> This thread has the wrong VERSION in its subject.
>> > > >>>
>> > > >>> Gary
>> > > >>>
>> > > >>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <
>> tibordigana@apache.org
>> > >
>> > > >>> wrote:
>> > > >>>
>> > > >>> > Hi,
>> > > >>> >
>> > > >>> > We solved 33 issues:
>> > > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > > >>> > projectId=12317927&version=12341630
>> > > >>> >
>> > > >>> > There are still a couple of issues left in JIRA:
>> > > >>> > https://issues.apache.org/jira/i#issues/?jql=project+%
>> > > >>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>> > > >>> >
>> > > >>> > Staging repo:
>> > > >>> > https://repository.apache.org/content/repositories/maven-1402/
>> > > >>> > https://repository.apache.org/content/repositories/maven-
>> > > >>> > 1402/org/apache/maven/surefire/surefire/2.21.0/
>> > > surefire-2.21.0-source-
>> > > >>> > release.zip
>> > > >>> >
>> > > >>> > Source release checksum(s):
>> > > >>> > surefire-2.21.0-source-release.zip sha1:
>> > > >>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>> > > >>> >
>> > > >>> > Staging site:
>> > > >>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>> > > >>> >
>> > > >>> > Guide to testing staged releases:
>> > > >>> > http://maven.apache.org/guides/development/guide-
>> > > testing-releases.html
>> > > >>> >
>> > > >>> > Vote open for 72 hours.
>> > > >>> >
>> > > >>> > [ ] +1
>> > > >>> > [ ] +0
>> > > >>> > [ ] -1
>> > > >>> >
>> > > >>> > Cheers
>> > > >>> > Tibor
>> > > >>> >
>> > > >>>
>> > > >>
>> > > >>
>> > > >
>> > >
>> >
>>
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Hi Jeff,

I am not an expert for Windows internals. Here is the statement [1] given
by our INFRA team. Do you think they performed same setting you have
proposed?
If it is different, you can maybe reply on JIRA and give them the hint.
[1]:
https://issues.apache.org/jira/browse/INFRA-16191?focusedCommentId=16402016&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16402016

We do not have long paths in Git repo hopefully. The situation is that we
copy some sources to a newly created folder in runtime:
surefire-its/target/<created-test-folder>/src/main/java/...

Then this exceeds the length. The copy is done by Java process JDK 1.8.

Cheers
Tibor





On Sat, Mar 17, 2018 at 5:52 PM, Jeff Jensen <
jeffjensen@upstairstechnology.com> wrote:

> Hi Tibor,
>
> > I should maybe write some limitations regarding length of IT
> class/method/package and length of Git branch name in README.md due to
> problems with Windows paths length.
>
> In case this helps: instead of shortening names for the Windows path length
> limitation, we can configure Windows and Git:
>
> 1. For recent Windows versions, set this to 1 (0 is
> disabled): HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem
> -> LongPathsEnabled
>
> 2.  git config --global core.longpaths true
>   Caveat per git doc and mitigated with step 1:
>
> Enable long path (> 260) support for builtin commands in Git for Windows.
> This is disabled by default, as long paths are not supported by Windows
> Explorer, cmd.exe and the Git for Windows tool chain (msys, bash, tcl,
> perl…​). Only enable this if you know what you’re doing and are prepared to
> live with a few quirks.
>
> On Sat, Mar 17, 2018 at 11:12 AM, Tibor Digana <ti...@apache.org>
> wrote:
>
> > I will push the Jira 1490 first.
> > Sorry it took some time. Last days we solved issues INFRA-16168 and
> > INFRA-16191.
> > I should maybe write some limitations regarding length of IT
> > class/method/package and length of Git branch name in README.md due to
> > problems with Windows paths length.
> >
> > On Fri, Mar 9, 2018 at 11:12 AM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > 2018-03-09 9:55 GMT+01:00 Tibor Digana <ti...@apache.org>:
> > >
> > > > Hi Enrico, Karl, Herve,
> > > >
> > > > We reported the issues [1] found during the Vote. They are fixed in
> > > > branches [2] and CI builds [3].
> > > > We can make a code review.
> > > > Additionally, we fixed SUREFIRE-1490 which was in progress but we did
> > not
> > > > have spare time to include it in the Release 2.21.0. Now it is fixed
> in
> > > [4].
> > > >
> > >
> > >
> > >
> > > Thank you Tibor,
> > > I did not have time to create issues yet and you already have resolved
> > them
> > > !!
> > >
> > > I can confirm that I am now using 2.21.0 and I am really happy with it.
> > >
> > > I have reviewed your commits and they looks good to me,
> > > today I do not have time to test your fixes on my "real" projects but
> > > surely I will do it next week, I guess we will not release 3.0.0M1
> > > immediately
> > >
> > > Cheers
> > > Enrico
> > >
> > >
> > >
> > > >
> > > > [1]:
> > > > https://issues.apache.org/jira/browse/SUREFIRE-1495
> > > > https://issues.apache.org/jira/browse/SUREFIRE-1498
> > > >
> > > > [2]:
> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > > surefire.git;a=commit;h=
> > > > c496ebf3b4518c25787d5eac9f54b2a220a59447
> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > > surefire.git;a=commit;h=
> > > > af7ae9ef933873a038b2817d6430859f2a5bd1c7
> > > >
> > > > [3]:
> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > > job/SUREFIRE-1495/4/
> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > > job/SUREFIRE-1498/1/
> > > >
> > > > [4]:
> > > > https://issues.apache.org/jira/browse/SUREFIRE-1490
> > > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > > surefire.git;a=commit;h=
> > > > 6174be76f52ffc2873a18a5215f60767843d7479
> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > > job/SUREFIRE-1490/2/
> > > >
> > > > Cheers
> > > > Tibor
> > > >
> > > >
> > > > On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <tibordigana@apache.org
> >
> > > > wrote:
> > > >
> > > >> Hello Gary, yes but my typo was corrected in the second e-mail.
> > > >>
> > > >> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <
> garydgregory@gmail.com>
> > > >> wrote:
> > > >>
> > > >>> This thread has the wrong VERSION in its subject.
> > > >>>
> > > >>> Gary
> > > >>>
> > > >>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <
> tibordigana@apache.org
> > >
> > > >>> wrote:
> > > >>>
> > > >>> > Hi,
> > > >>> >
> > > >>> > We solved 33 issues:
> > > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > >>> > projectId=12317927&version=12341630
> > > >>> >
> > > >>> > There are still a couple of issues left in JIRA:
> > > >>> > https://issues.apache.org/jira/i#issues/?jql=project+%
> > > >>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> > > >>> >
> > > >>> > Staging repo:
> > > >>> > https://repository.apache.org/content/repositories/maven-1402/
> > > >>> > https://repository.apache.org/content/repositories/maven-
> > > >>> > 1402/org/apache/maven/surefire/surefire/2.21.0/
> > > surefire-2.21.0-source-
> > > >>> > release.zip
> > > >>> >
> > > >>> > Source release checksum(s):
> > > >>> > surefire-2.21.0-source-release.zip sha1:
> > > >>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> > > >>> >
> > > >>> > Staging site:
> > > >>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > > >>> >
> > > >>> > Guide to testing staged releases:
> > > >>> > http://maven.apache.org/guides/development/guide-
> > > testing-releases.html
> > > >>> >
> > > >>> > Vote open for 72 hours.
> > > >>> >
> > > >>> > [ ] +1
> > > >>> > [ ] +0
> > > >>> > [ ] -1
> > > >>> >
> > > >>> > Cheers
> > > >>> > Tibor
> > > >>> >
> > > >>>
> > > >>
> > > >>
> > > >
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Jeff Jensen <je...@upstairstechnology.com>.
Hi Tibor,

> I should maybe write some limitations regarding length of IT
class/method/package and length of Git branch name in README.md due to
problems with Windows paths length.

In case this helps: instead of shortening names for the Windows path length
limitation, we can configure Windows and Git:

1. For recent Windows versions, set this to 1 (0 is
disabled): HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem
-> LongPathsEnabled

2.  git config --global core.longpaths true
  Caveat per git doc and mitigated with step 1:

Enable long path (> 260) support for builtin commands in Git for Windows.
This is disabled by default, as long paths are not supported by Windows
Explorer, cmd.exe and the Git for Windows tool chain (msys, bash, tcl,
perl…​). Only enable this if you know what you’re doing and are prepared to
live with a few quirks.

On Sat, Mar 17, 2018 at 11:12 AM, Tibor Digana <ti...@apache.org>
wrote:

> I will push the Jira 1490 first.
> Sorry it took some time. Last days we solved issues INFRA-16168 and
> INFRA-16191.
> I should maybe write some limitations regarding length of IT
> class/method/package and length of Git branch name in README.md due to
> problems with Windows paths length.
>
> On Fri, Mar 9, 2018 at 11:12 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > 2018-03-09 9:55 GMT+01:00 Tibor Digana <ti...@apache.org>:
> >
> > > Hi Enrico, Karl, Herve,
> > >
> > > We reported the issues [1] found during the Vote. They are fixed in
> > > branches [2] and CI builds [3].
> > > We can make a code review.
> > > Additionally, we fixed SUREFIRE-1490 which was in progress but we did
> not
> > > have spare time to include it in the Release 2.21.0. Now it is fixed in
> > [4].
> > >
> >
> >
> >
> > Thank you Tibor,
> > I did not have time to create issues yet and you already have resolved
> them
> > !!
> >
> > I can confirm that I am now using 2.21.0 and I am really happy with it.
> >
> > I have reviewed your commits and they looks good to me,
> > today I do not have time to test your fixes on my "real" projects but
> > surely I will do it next week, I guess we will not release 3.0.0M1
> > immediately
> >
> > Cheers
> > Enrico
> >
> >
> >
> > >
> > > [1]:
> > > https://issues.apache.org/jira/browse/SUREFIRE-1495
> > > https://issues.apache.org/jira/browse/SUREFIRE-1498
> > >
> > > [2]:
> > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > surefire.git;a=commit;h=
> > > c496ebf3b4518c25787d5eac9f54b2a220a59447
> > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > surefire.git;a=commit;h=
> > > af7ae9ef933873a038b2817d6430859f2a5bd1c7
> > >
> > > [3]:
> > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > job/SUREFIRE-1495/4/
> > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > job/SUREFIRE-1498/1/
> > >
> > > [4]:
> > > https://issues.apache.org/jira/browse/SUREFIRE-1490
> > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > surefire.git;a=commit;h=
> > > 6174be76f52ffc2873a18a5215f60767843d7479
> > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > job/SUREFIRE-1490/2/
> > >
> > > Cheers
> > > Tibor
> > >
> > >
> > > On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <ti...@apache.org>
> > > wrote:
> > >
> > >> Hello Gary, yes but my typo was corrected in the second e-mail.
> > >>
> > >> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <ga...@gmail.com>
> > >> wrote:
> > >>
> > >>> This thread has the wrong VERSION in its subject.
> > >>>
> > >>> Gary
> > >>>
> > >>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <tibordigana@apache.org
> >
> > >>> wrote:
> > >>>
> > >>> > Hi,
> > >>> >
> > >>> > We solved 33 issues:
> > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >>> > projectId=12317927&version=12341630
> > >>> >
> > >>> > There are still a couple of issues left in JIRA:
> > >>> > https://issues.apache.org/jira/i#issues/?jql=project+%
> > >>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> > >>> >
> > >>> > Staging repo:
> > >>> > https://repository.apache.org/content/repositories/maven-1402/
> > >>> > https://repository.apache.org/content/repositories/maven-
> > >>> > 1402/org/apache/maven/surefire/surefire/2.21.0/
> > surefire-2.21.0-source-
> > >>> > release.zip
> > >>> >
> > >>> > Source release checksum(s):
> > >>> > surefire-2.21.0-source-release.zip sha1:
> > >>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> > >>> >
> > >>> > Staging site:
> > >>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >>> >
> > >>> > Guide to testing staged releases:
> > >>> > http://maven.apache.org/guides/development/guide-
> > testing-releases.html
> > >>> >
> > >>> > Vote open for 72 hours.
> > >>> >
> > >>> > [ ] +1
> > >>> > [ ] +0
> > >>> > [ ] -1
> > >>> >
> > >>> > Cheers
> > >>> > Tibor
> > >>> >
> > >>>
> > >>
> > >>
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
I will push the Jira 1490 first.
Sorry it took some time. Last days we solved issues INFRA-16168 and
INFRA-16191.
I should maybe write some limitations regarding length of IT
class/method/package and length of Git branch name in README.md due to
problems with Windows paths length.

On Fri, Mar 9, 2018 at 11:12 AM, Enrico Olivelli <eo...@gmail.com>
wrote:

> 2018-03-09 9:55 GMT+01:00 Tibor Digana <ti...@apache.org>:
>
> > Hi Enrico, Karl, Herve,
> >
> > We reported the issues [1] found during the Vote. They are fixed in
> > branches [2] and CI builds [3].
> > We can make a code review.
> > Additionally, we fixed SUREFIRE-1490 which was in progress but we did not
> > have spare time to include it in the Release 2.21.0. Now it is fixed in
> [4].
> >
>
>
>
> Thank you Tibor,
> I did not have time to create issues yet and you already have resolved them
> !!
>
> I can confirm that I am now using 2.21.0 and I am really happy with it.
>
> I have reviewed your commits and they looks good to me,
> today I do not have time to test your fixes on my "real" projects but
> surely I will do it next week, I guess we will not release 3.0.0M1
> immediately
>
> Cheers
> Enrico
>
>
>
> >
> > [1]:
> > https://issues.apache.org/jira/browse/SUREFIRE-1495
> > https://issues.apache.org/jira/browse/SUREFIRE-1498
> >
> > [2]:
> > https://git1-us-west.apache.org/repos/asf?p=maven-
> surefire.git;a=commit;h=
> > c496ebf3b4518c25787d5eac9f54b2a220a59447
> > https://git1-us-west.apache.org/repos/asf?p=maven-
> surefire.git;a=commit;h=
> > af7ae9ef933873a038b2817d6430859f2a5bd1c7
> >
> > [3]:
> > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > job/SUREFIRE-1495/4/
> > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > job/SUREFIRE-1498/1/
> >
> > [4]:
> > https://issues.apache.org/jira/browse/SUREFIRE-1490
> > https://git1-us-west.apache.org/repos/asf?p=maven-
> surefire.git;a=commit;h=
> > 6174be76f52ffc2873a18a5215f60767843d7479
> > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > job/SUREFIRE-1490/2/
> >
> > Cheers
> > Tibor
> >
> >
> > On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <ti...@apache.org>
> > wrote:
> >
> >> Hello Gary, yes but my typo was corrected in the second e-mail.
> >>
> >> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <ga...@gmail.com>
> >> wrote:
> >>
> >>> This thread has the wrong VERSION in its subject.
> >>>
> >>> Gary
> >>>
> >>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <ti...@apache.org>
> >>> wrote:
> >>>
> >>> > Hi,
> >>> >
> >>> > We solved 33 issues:
> >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >>> > projectId=12317927&version=12341630
> >>> >
> >>> > There are still a couple of issues left in JIRA:
> >>> > https://issues.apache.org/jira/i#issues/?jql=project+%
> >>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >>> >
> >>> > Staging repo:
> >>> > https://repository.apache.org/content/repositories/maven-1402/
> >>> > https://repository.apache.org/content/repositories/maven-
> >>> > 1402/org/apache/maven/surefire/surefire/2.21.0/
> surefire-2.21.0-source-
> >>> > release.zip
> >>> >
> >>> > Source release checksum(s):
> >>> > surefire-2.21.0-source-release.zip sha1:
> >>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> >>> >
> >>> > Staging site:
> >>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >>> >
> >>> > Guide to testing staged releases:
> >>> > http://maven.apache.org/guides/development/guide-
> testing-releases.html
> >>> >
> >>> > Vote open for 72 hours.
> >>> >
> >>> > [ ] +1
> >>> > [ ] +0
> >>> > [ ] -1
> >>> >
> >>> > Cheers
> >>> > Tibor
> >>> >
> >>>
> >>
> >>
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Enrico Olivelli <eo...@gmail.com>.
2018-03-09 9:55 GMT+01:00 Tibor Digana <ti...@apache.org>:

> Hi Enrico, Karl, Herve,
>
> We reported the issues [1] found during the Vote. They are fixed in
> branches [2] and CI builds [3].
> We can make a code review.
> Additionally, we fixed SUREFIRE-1490 which was in progress but we did not
> have spare time to include it in the Release 2.21.0. Now it is fixed in [4].
>



Thank you Tibor,
I did not have time to create issues yet and you already have resolved them
!!

I can confirm that I am now using 2.21.0 and I am really happy with it.

I have reviewed your commits and they looks good to me,
today I do not have time to test your fixes on my "real" projects but
surely I will do it next week, I guess we will not release 3.0.0M1
immediately

Cheers
Enrico



>
> [1]:
> https://issues.apache.org/jira/browse/SUREFIRE-1495
> https://issues.apache.org/jira/browse/SUREFIRE-1498
>
> [2]:
> https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=
> c496ebf3b4518c25787d5eac9f54b2a220a59447
> https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=
> af7ae9ef933873a038b2817d6430859f2a5bd1c7
>
> [3]:
> https://builds.apache.org/job/maven-wip/job/maven-surefire/
> job/SUREFIRE-1495/4/
> https://builds.apache.org/job/maven-wip/job/maven-surefire/
> job/SUREFIRE-1498/1/
>
> [4]:
> https://issues.apache.org/jira/browse/SUREFIRE-1490
> https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=
> 6174be76f52ffc2873a18a5215f60767843d7479
> https://builds.apache.org/job/maven-wip/job/maven-surefire/
> job/SUREFIRE-1490/2/
>
> Cheers
> Tibor
>
>
> On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <ti...@apache.org>
> wrote:
>
>> Hello Gary, yes but my typo was corrected in the second e-mail.
>>
>> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>
>>> This thread has the wrong VERSION in its subject.
>>>
>>> Gary
>>>
>>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <ti...@apache.org>
>>> wrote:
>>>
>>> > Hi,
>>> >
>>> > We solved 33 issues:
>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>> > projectId=12317927&version=12341630
>>> >
>>> > There are still a couple of issues left in JIRA:
>>> > https://issues.apache.org/jira/i#issues/?jql=project+%
>>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>>> >
>>> > Staging repo:
>>> > https://repository.apache.org/content/repositories/maven-1402/
>>> > https://repository.apache.org/content/repositories/maven-
>>> > 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
>>> > release.zip
>>> >
>>> > Source release checksum(s):
>>> > surefire-2.21.0-source-release.zip sha1:
>>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>>> >
>>> > Staging site:
>>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>>> >
>>> > Guide to testing staged releases:
>>> > http://maven.apache.org/guides/development/guide-testing-releases.html
>>> >
>>> > Vote open for 72 hours.
>>> >
>>> > [ ] +1
>>> > [ ] +0
>>> > [ ] -1
>>> >
>>> > Cheers
>>> > Tibor
>>> >
>>>
>>
>>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Hi Enrico, Karl, Herve,

We reported the issues [1] found during the Vote. They are fixed in
branches [2] and CI builds [3].
We can make a code review.
Additionally, we fixed SUREFIRE-1490 which was in progress but we did not
have spare time to include it in the Release 2.21.0. Now it is fixed in [4].

[1]:
https://issues.apache.org/jira/browse/SUREFIRE-1495
https://issues.apache.org/jira/browse/SUREFIRE-1498

[2]:
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=c496ebf3b4518c25787d5eac9f54b2a220a59447
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=af7ae9ef933873a038b2817d6430859f2a5bd1c7

[3]:
https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1495/4/
https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1498/1/

[4]:
https://issues.apache.org/jira/browse/SUREFIRE-1490
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=6174be76f52ffc2873a18a5215f60767843d7479
https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1490/2/

Cheers
Tibor


On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <ti...@apache.org> wrote:

> Hello Gary, yes but my typo was corrected in the second e-mail.
>
> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> This thread has the wrong VERSION in its subject.
>>
>> Gary
>>
>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <ti...@apache.org>
>> wrote:
>>
>> > Hi,
>> >
>> > We solved 33 issues:
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > projectId=12317927&version=12341630
>> >
>> > There are still a couple of issues left in JIRA:
>> > https://issues.apache.org/jira/i#issues/?jql=project+%
>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>> >
>> > Staging repo:
>> > https://repository.apache.org/content/repositories/maven-1402/
>> > https://repository.apache.org/content/repositories/maven-
>> > 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
>> > release.zip
>> >
>> > Source release checksum(s):
>> > surefire-2.21.0-source-release.zip sha1:
>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>> >
>> > Staging site:
>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>> >
>> > Guide to testing staged releases:
>> > http://maven.apache.org/guides/development/guide-testing-releases.html
>> >
>> > Vote open for 72 hours.
>> >
>> > [ ] +1
>> > [ ] +0
>> > [ ] -1
>> >
>> > Cheers
>> > Tibor
>> >
>>
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Tibor Digana <ti...@apache.org>.
Hello Gary, yes but my typo was corrected in the second e-mail.

On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <ga...@gmail.com> wrote:

> This thread has the wrong VERSION in its subject.
>
> Gary
>
> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <ti...@apache.org>
> wrote:
>
> > Hi,
> >
> > We solved 33 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12317927&version=12341630
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/i#issues/?jql=project+%
> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1402/
> > https://repository.apache.org/content/repositories/maven-
> > 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> > release.zip
> >
> > Source release checksum(s):
> > surefire-2.21.0-source-release.zip sha1:
> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Posted by Gary Gregory <ga...@gmail.com>.
This thread has the wrong VERSION in its subject.

Gary

On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <ti...@apache.org> wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>