[GitHub] [netbeans] jlahoda commented on a change in pull request #2813: Execute commit validation on JDK15

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #2813:
URL: https://github.com/apache/netbeans/pull/2813#discussion_r597226719



##########
File path: nbbuild/templates/projectized.xml
##########
@@ -86,7 +86,46 @@
         <property name="have-custom-javac-task" value="true" />
     </target>
 
-    <target name="build-init" depends="basic-init,jdk-8-check,set-buildnumber,-define-custom-javac-task">
+    <target name="-init-bootclasspath-prepend" depends="basic-init,jdk-8-check,set-buildnumber,-define-custom-javac-task" unless="have-jdk-1.9">

Review comment:
       It might be better to augment the conditions below that test for `test.use.jdk.javac` to also include `have-jdk1.9`, rather than skipping this completely, so that the `bootclasspath.prepend` is set for compilation.

##########
File path: platform/o.n.bootstrap/src/org/netbeans/Util.java
##########
@@ -170,6 +171,9 @@ public static boolean checkPackageDependency(Dependency dep, ClassLoader cl) thr
             } else {
                 pkg = Package.getPackage(packageName);
             }
+            if (pkg == null && sampleClass != null) {
+                pkg = sampleClass.getPackage();

Review comment:
       Thanks for the investigation!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists