You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jb...@apache.org on 2019/04/02 09:27:36 UTC
[beam] branch master updated: [BEAM-6968] Deprecate MqttIO create
with clientId constructor
This is an automated email from the ASF dual-hosted git repository.
jbonofre pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 6859cc2 [BEAM-6968] Deprecate MqttIO create with clientId constructor
new ffea03a Merge pull request #8197 from iemejia/BEAM-6968-mqtt-create-deprecate
6859cc2 is described below
commit 6859cc2645f52261af64f518623c032664d7251d
Author: Ismaël Mejía <ie...@gmail.com>
AuthorDate: Tue Apr 2 11:24:59 2019 +0200
[BEAM-6968] Deprecate MqttIO create with clientId constructor
---
.../io/mqtt/src/main/java/org/apache/beam/sdk/io/mqtt/MqttIO.java | 3 +++
.../src/test/java/org/apache/beam/sdk/io/mqtt/MqttIOTest.java | 8 ++++----
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/sdks/java/io/mqtt/src/main/java/org/apache/beam/sdk/io/mqtt/MqttIO.java b/sdks/java/io/mqtt/src/main/java/org/apache/beam/sdk/io/mqtt/MqttIO.java
index 797d702..dc7cde3 100644
--- a/sdks/java/io/mqtt/src/main/java/org/apache/beam/sdk/io/mqtt/MqttIO.java
+++ b/sdks/java/io/mqtt/src/main/java/org/apache/beam/sdk/io/mqtt/MqttIO.java
@@ -175,7 +175,10 @@ public class MqttIO {
* @param topic The MQTT getTopic pattern.
* @param clientId A client ID prefix, used to construct an unique client ID.
* @return A connection configuration to the MQTT broker.
+ * @deprecated This constructor will be removed in a future version of Beam, please use
+ * #create(String, String)} and {@link #withClientId(String)} instead.
*/
+ @Deprecated
public static ConnectionConfiguration create(String serverUri, String topic, String clientId) {
checkArgument(clientId != null, "clientId can not be null");
return create(serverUri, topic).withClientId(clientId);
diff --git a/sdks/java/io/mqtt/src/test/java/org/apache/beam/sdk/io/mqtt/MqttIOTest.java b/sdks/java/io/mqtt/src/test/java/org/apache/beam/sdk/io/mqtt/MqttIOTest.java
index b4fd2da..58ef330 100644
--- a/sdks/java/io/mqtt/src/test/java/org/apache/beam/sdk/io/mqtt/MqttIOTest.java
+++ b/sdks/java/io/mqtt/src/test/java/org/apache/beam/sdk/io/mqtt/MqttIOTest.java
@@ -150,8 +150,8 @@ public class MqttIOTest {
pipeline.apply(
MqttIO.read()
.withConnectionConfiguration(
- MqttIO.ConnectionConfiguration.create(
- "tcp://localhost:" + port, "READ_TOPIC", "READ_PIPELINE"))
+ MqttIO.ConnectionConfiguration.create("tcp://localhost:" + port, "READ_TOPIC")
+ .withClientId("READ_PIPELINE"))
.withMaxReadTime(Duration.standardSeconds(3)));
PAssert.that(output)
.containsInAnyOrder(
@@ -212,8 +212,8 @@ public class MqttIOTest {
pipeline.apply(
MqttIO.read()
.withConnectionConfiguration(
- MqttIO.ConnectionConfiguration.create(
- "tcp://localhost:" + port, "READ_TOPIC", "READ_PIPELINE"))
+ MqttIO.ConnectionConfiguration.create("tcp://localhost:" + port, "READ_TOPIC")
+ .withClientId("READ_PIPELINE"))
.withMaxReadTime(Duration.standardSeconds(2)));
// should stop before the test timeout