You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "cbalint13 (via GitHub)" <gi...@apache.org> on 2023/04/10 09:29:29 UTC
[GitHub] [tvm] cbalint13 commented on a diff in pull request #14468: [AutoTVM] New rank-binary loss_type for the new xgboost >= 2.0.0 behaviour
cbalint13 commented on code in PR #14468:
URL: https://github.com/apache/tvm/pull/14468#discussion_r1161580129
##########
vta/scripts/tune_resnet.py:
##########
@@ -184,7 +184,7 @@ def tune_tasks(
# create tuner
if tuner == "xgb" or tuner == "xgb-rank":
Review Comment:
@FrozenGene
> `tuner == "xgb-rank"` should be changed too.
Thanks for the observation !
* fixed and exposed properly all such cases.
* exposed / updated tmvc with extended options coverage.
* extended the demo lists (taken from original ```tune_relay_arm.py``` for completeness)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org