[GitHub] DaanHoogland opened a new issue #2774: NPE in isOnVolumeManagedStorage() leads to not being able to extract volumes

[GitBox <gi...@apache.org>]

DaanHoogland opened a new issue #2774: NPE in isOnVolumeManagedStorage() leads to not being able to extract volumes
URL: https://github.com/apache/cloudstack/issues/2774
 
 
   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and master branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Bug Report
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   Storage Motion
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on master branch.
   -->
   
   ~~~
   4.11.1
   ~~~
   
   ##### CONFIGURATION
   <!--
   Information about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise
   -->
   In a mixed environment with several advanced zones, extracting a volume failed due to the storage motion strategy org.apache.cloudstack.storage.motion.StorageSystemDataMotionStrategy.canHandle(src,dest) throwing a NullPointerException. root cause is the isVolumeOnManagedStorage() assuming that the dataStore for the destination is Primary while in the case of extractVolume it is an image store. In lab and test environments this seems to happen to go well as both types of storages probably exist with id==1.
   
   ##### OS / ENVIRONMENT
   <!--
   Information about the environment if relevant, N/A otherwise
   -->
   
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   
   
   ##### STEPS TO REPRODUCE
   <!--
   For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
   
   For new features, show how the feature would be used.
   -->
   
   <!-- Paste example playbooks or commands between quotes below -->
   ~~~
   extract a volume. In the case of a lab environment make sure that no primary storage and image stores exist with the same id. 
   ~~~
   
   <!-- You can also paste gist.github.com links for larger files -->
   
   ##### EXPECTED RESULTS
   <!-- What did you expect to happen when running the steps above? -->
   
   ~~~
   user level: the call returns a url for download
   unit level: isVolumeOnMangedStorage should return false or be able to handle the image store case (and still return false?)
   ~~~
   
   ##### ACTUAL RESULTS
   <!-- What actually happened? -->
   
   <!-- Paste verbatim command output between quotes below -->
   ~~~
   user level: a message 'Failed to copy the volume from the source primary storage pool to secondary storage.' is shown in the UI
   unit level: npe
   ~~~
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services