You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/01/20 03:15:01 UTC
[GitHub] flink pull request: [FLINK-3262][web-dashboard] Remove fuzzy versi...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1525
[FLINK-3262][web-dashboard] Remove fuzzy versioning from Bower dependencies
Several packages had been updated locally by users when compiling the templates
without changing the version in bower.json. The following packages have been
explicitly updated.
jquery 2.1.4 → 2.2.0
angular 1.3.15 → 1.4.8
angular-moment 0.9.2 → 0.10.3
angular-ui-router 0.2.13 → 0.2.15
bootstrap 3.3.5 → 3.3.6
d3 3.5.5 → 3.5.12
dagre-d3 0.4.10 → 0.4.11
font-awesome 4.3.0 → 4.5.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3262_remove_fuzzy_versioning_from_bower_dependencies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1525.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1525
----
commit 444e76064bb7ffa504e77d0c5567ea856aff8cc8
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-01-19T15:21:25Z
[FLINK-3262][web-dashboard] Remove fuzzy versioning from Bower dependencies
Several packages had been updated locally by users when compiling the templates
without changing the version in bower.json. The following packages have been
explicitly updated.
jquery 2.1.4 → 2.2.0
angular 1.3.15 → 1.4.8
angular-moment 0.9.2 → 0.10.3
angular-ui-router 0.2.13 → 0.2.15
bootstrap 3.3.5 → 3.3.6
d3 3.5.5 → 3.5.12
dagre-d3 0.4.10 → 0.4.11
font-awesome 4.3.0 → 4.5.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3262][web-dashboard] Remove fuzzy versi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1525#issuecomment-173135590
Changes look good.
Did you check that the UI works properly (no glitches due to the changes in dependencies)?
If all works well, +1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3262][web-dashboard] Remove fuzzy versi...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1525#issuecomment-173371188
Ah, okay, so I ran the UI but neglected to note that the "fonts" were missing. Turns out the spec for [bower.json](
https://github.com/bower/spec/blob/master/json.md#main) now prefers pre-processed files. Font Awesome was [updated](https://github.com/FortAwesome/Font-Awesome/commit/7cde41ea934f43e66dc123ea6411d8535b50a4f7) for the new spec and our `gulpfile.js` needed to be modified to include `font-awesome.css` in the aggregated `vendor.css`.
Rather than downgrading Font Awesome back to 4.3.0 or including an override in `bower.json` I updated `gulpfile.js` to pre-process and include any `LESS` files in bower dependencies (as was already being done for Flink's `bootstrap_custom.less`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3262][web-dashboard] Remove fuzzy versi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1525#issuecomment-175518369
Looks good, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3262][web-dashboard] Remove fuzzy versi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---