You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/12/27 01:31:41 UTC
[kudu-CR] [consensus] fix last-heard-from-leader in error message
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14952
Change subject: [consensus] fix last-heard-from-leader in error message
......................................................................
[consensus] fix last-heard-from-leader in error message
Fixed the last-heard-from-leader reported time in error message
from TimeManager::AssignTimestamp() when in NON_LEADER mode.
Change-Id: Ic7afdd411f6b23eb690304cf3c8e588e5f08869c
---
M src/kudu/consensus/time_manager.cc
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/14952/1
--
To view, visit http://gerrit.cloudera.org:8080/14952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7afdd411f6b23eb690304cf3c8e588e5f08869c
Gerrit-Change-Number: 14952
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] fix last-heard-from-leader in error message
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14952 )
Change subject: [consensus] fix last-heard-from-leader in error message
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ic7afdd411f6b23eb690304cf3c8e588e5f08869c
Gerrit-Change-Number: 14952
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] fix last-heard-from-leader in error message
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14952 )
Change subject: [consensus] fix last-heard-from-leader in error message
......................................................................
[consensus] fix last-heard-from-leader in error message
Fixed the last-heard-from-leader reported time in error message
from TimeManager::AssignTimestamp() when in NON_LEADER mode.
Change-Id: Ic7afdd411f6b23eb690304cf3c8e588e5f08869c
Reviewed-on: http://gerrit.cloudera.org:8080/14952
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/consensus/time_manager.cc
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7afdd411f6b23eb690304cf3c8e588e5f08869c
Gerrit-Change-Number: 14952
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] fix last-heard-from-leader in error message
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14952 )
Change subject: [consensus] fix last-heard-from-leader in error message
......................................................................
Patch Set 1: Verified+1
Unrelated test failures in:
* RaftConsensusStressITest.RemoveReplaceInCycle
* TsTabletManagerITest.TestTableStats
--
To view, visit http://gerrit.cloudera.org:8080/14952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7afdd411f6b23eb690304cf3c8e588e5f08869c
Gerrit-Change-Number: 14952
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Dec 2019 02:42:25 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] fix last-heard-from-leader in error message
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14952 )
Change subject: [consensus] fix last-heard-from-leader in error message
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7afdd411f6b23eb690304cf3c8e588e5f08869c
Gerrit-Change-Number: 14952
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Sun, 29 Dec 2019 18:39:33 +0000
Gerrit-HasComments: No