[GitHub] [airflow] o-nikolas commented on a diff in pull request #29772: Support deleting the local log files when using remote logging

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on code in PR #29772:
URL: https://github.com/apache/airflow/pull/29772#discussion_r1127107807


##########
airflow/config_templates/config.yml:
##########
@@ -606,6 +606,14 @@ logging:
       type: string
       example: ~
       default: ""
+    delete_local_logs:
+      description: |
+        Whether the local log files for GCS, S3, WASB and OSS remote logging should be deleted after
+        they are uploaded to remote location

Review Comment:
   ```suggestion
           they are uploaded to the remote location.
   ```



##########
airflow/providers/alibaba/cloud/log/oss_task_handler.py:
##########
@@ -28,21 +31,35 @@
 from airflow.utils.log.logging_mixin import LoggingMixin
 
 
+def get_default_delete_local_copy():

Review Comment:
   Nice I like this



##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -345,6 +345,10 @@ remote_logging = False
 # reading logs, not writing them.
 remote_log_conn_id =
 
+# Whether the local log files for GCS, S3, WASB and OSS remote logging should be deleted after
+# they are uploaded to remote location

Review Comment:
   ```suggestion
   # they are uploaded to the remote location.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org