[GitHub] [superset] codyml commented on a diff in pull request #22832: chore: Update typing for `Table` component

["codyml (via GitHub)" <gi...@apache.org>]

codyml commented on code in PR #22832:
URL: https://github.com/apache/superset/pull/22832#discussion_r1086120303


##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx:
##########
@@ -302,7 +298,7 @@ export default function DrillDetailPane({
           recordCount={resultsPage?.total}
           usePagination
           loading={isLoading}
-          onChange={(pagination: TablePaginationConfig) =>

Review Comment:
   I took it out because TS can infer this type, so you'll still see `TablePaginationConfig` as the type if you inspect in your IDE and you'll still get the same lint errors as if it were explicitly annotated, and I usually wouldn't include an annotation in those cases to keep the code cleaner.  But, no strong feelings – do you think explicit annotation is helpful here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org