You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/21 17:27:01 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #10380: fix(datasets): sort and humanized modified by

dpgaspar opened a new pull request #10380:
URL: https://github.com/apache/incubator-superset/pull/10380


   ### SUMMARY
   Fixes: modified by time zone issue (same solution has for charts and dashboards). 
   Fixes: Sort by modified by
   Introduces sort on schemas
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [X] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10380: fix(datasets): sort and humanized modified by

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10380:
URL: https://github.com/apache/incubator-superset/pull/10380#discussion_r458268204



##########
File path: superset-frontend/src/views/datasetList/DatasetList.tsx
##########
@@ -277,31 +275,16 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
     {
       Header: t('Schema'),
       accessor: 'schema',
-      disableSortBy: true,
       size: 'lg',
     },
     {
       Cell: ({
         row: {
-          original: { changed_on: changedOn },
+          original: { changed_on_delta_humanized: changedOn },
         },
-      }: any) => {
-        const momentTime = moment(changedOn);
-        const time = momentTime.format(SHORT_DATE);
-        const date = momentTime.format(SHORT_TIME);
-        return (
-          <TooltipWrapper
-            label="last-modified"
-            tooltip={time}
-            placement="right"
-          >
-            <span>{date}</span>
-          </TooltipWrapper>
-        );
-      },
-      Header: t('Last Modified'),
-      accessor: 'changed_on',
-      size: 'xl',
+      }: any) => <span className="no-wrap">{changedOn}</span>,
+      Header: t('Modified'),
+      accessor: 'changed_on_delta_humanized',

Review comment:
       can you add back the `size: 'xl'` property which should ensure even spacing between columns




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar merged pull request #10380: fix(datasets): sort and humanized modified by

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10380:
URL: https://github.com/apache/incubator-superset/pull/10380


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10380: fix(datasets): sort and humanized modified by

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10380:
URL: https://github.com/apache/incubator-superset/pull/10380#issuecomment-662332055


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10380?src=pr&el=h1) Report
   > Merging [#10380](https://codecov.io/gh/apache/incubator-superset/pull/10380?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/09de8050174d48a3fde1c3a8e9a65a6ab21f8f0c&el=desc) will **decrease** coverage by `0.95%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10380/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10380?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10380      +/-   ##
   ==========================================
   - Coverage   70.66%   69.71%   -0.96%     
   ==========================================
     Files         601      196     -405     
     Lines       32267    19019   -13248     
     Branches     3275        0    -3275     
   ==========================================
   - Hits        22803    13259    -9544     
   + Misses       9358     5760    -3598     
   + Partials      106        0     -106     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `69.71% <100.00%> (-0.22%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10380?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.14% <100.00%> (+0.11%)` | :arrow_up: |
   | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `76.96% <0.00%> (-12.98%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `64.51% <0.00%> (-9.68%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `93.54% <0.00%> (-6.46%)` | :arrow_down: |
   | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `95.12% <0.00%> (-4.88%)` | :arrow_down: |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `58.62% <0.00%> (-3.96%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
   | [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `91.12% <0.00%> (-1.62%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.75% <0.00%> (-1.13%)` | :arrow_down: |
   | ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/10380/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10380?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10380?src=pr&el=footer). Last update [09de805...f92dd3c](https://codecov.io/gh/apache/incubator-superset/pull/10380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org