You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/24 06:24:28 UTC
[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5435: [TE] clean up decprecated/unused code
xiaohui-sun commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r429602883
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/ThirdEyeAnomalyApplication.java
##########
@@ -273,9 +224,4 @@ private void initAnomalyClassifierFactory(String anomalyClassifierConfigPath) {
}
Review comment:
initAnomalyClassifierFactory, initAlertFilterFactory could be deleted.
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskInfoFactory.java
##########
@@ -67,16 +64,6 @@ public static TaskInfo getTaskInfoFromTaskType(TaskType taskType, String taskInf
case MONITOR:
taskInfo = OBJECT_MAPPER.readValue(taskInfoString, MonitorTaskInfo.class);
break;
- case ALERT:
Review comment:
ANOMALY_DETECTION and MERGE tasks are not used.
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/ThirdEyeAnomalyApplication.java
##########
@@ -61,18 +54,12 @@
public class ThirdEyeAnomalyApplication
extends BaseThirdEyeApplication<ThirdEyeAnomalyConfiguration> {
- private DetectionJobScheduler detectionJobScheduler = null;
private TaskDriver taskDriver = null;
private MonitorJobScheduler monitorJobScheduler = null;
- private AlertJobSchedulerV2 alertJobSchedulerV2;
private AnomalyFunctionFactory anomalyFunctionFactory = null;
private AutoOnboardService autoOnboardService = null;
- private DataCompletenessScheduler dataCompletenessScheduler = null;
private AlertFilterFactory alertFilterFactory = null;
private AnomalyClassifierFactory anomalyClassifierFactory = null;
Review comment:
anomalyClassifierFactory not used.
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/ThirdEyeAnomalyApplication.java
##########
@@ -61,18 +54,12 @@
public class ThirdEyeAnomalyApplication
extends BaseThirdEyeApplication<ThirdEyeAnomalyConfiguration> {
- private DetectionJobScheduler detectionJobScheduler = null;
private TaskDriver taskDriver = null;
private MonitorJobScheduler monitorJobScheduler = null;
- private AlertJobSchedulerV2 alertJobSchedulerV2;
private AnomalyFunctionFactory anomalyFunctionFactory = null;
private AutoOnboardService autoOnboardService = null;
- private DataCompletenessScheduler dataCompletenessScheduler = null;
private AlertFilterFactory alertFilterFactory = null;
Review comment:
alertFilterFactory not used.
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskRunnerFactory.java
##########
@@ -59,16 +56,6 @@ public static TaskRunner getTaskRunnerFromTaskType(TaskType taskType) {
case MONITOR:
taskRunner = new MonitorTaskRunner();
break;
- case DATA_COMPLETENESS:
Review comment:
ANOMALY_DETECTION and MERGE tasks are not used.
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/completeness/checker/Wo4WAvgDataCompletenessAlgorithm.java
##########
@@ -41,6 +41,7 @@
/**
* This is the implementation of the WO4W Average function or checking data completeness of datasets
*/
+@Deprecated
public class Wo4WAvgDataCompletenessAlgorithm implements DataCompletenessAlgorithm {
public static double DEFAULT_EXPECTED_COMPLETENESS = 80;
Review comment:
This class could be deleted.
Let's delete everything under /completeness.checker
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/completeness/checker/DataCompletenessUtils.java
##########
@@ -261,13 +261,4 @@ public static DateTimeFormatter getDateTimeFormatterForDataset(TimeSpec timeSpec
return bucketNameToCountStar;
}
- public static double getPercentCompleteness(PercentCompletenessFunctionInput input) {
Review comment:
This whole class could be deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org