[GitHub] [superset] eschutho commented on a diff in pull request #23461: feat(bigquery): `get_catalog_names`

["eschutho (via GitHub)" <gi...@apache.org>]

eschutho commented on code in PR #23461:
URL: https://github.com/apache/superset/pull/23461#discussion_r1157762067


##########
superset/db_engine_specs/bigquery.py:
##########
@@ -366,6 +376,21 @@ def df_to_sql(
 
         pandas_gbq.to_gbq(df, **to_gbq_kwargs)
 
+    @classmethod
+    def _get_client(cls, engine: Engine) -> Any:
+        """
+        Return the BigQuery client associated with an engine.
+        """
+        if not dependencies_installed:

Review Comment:
   It looks like this is just catching a formerly uncaught exception, is that right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org