Re: [PR] Added allowed url property to URLContextClassLoaderFactory [accumulo]

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on code in PR #6527:
URL: https://github.com/apache/accumulo/pull/6527#discussion_r4155707897


##########
core/src/main/java/org/apache/accumulo/core/classloader/URLContextClassLoaderFactory.java:
##########
@@ -59,7 +83,11 @@ public ClassLoader getClassLoader(String context) {
       LOG.debug("Creating URLClassLoader for context, uris: {}", context);
       return new URLClassLoader(Arrays.stream(context.split(",")).map(p -> {
         try {
-          return URI.create(p).toURL();
+          URL url = new URL(p);
+          checkArgument(urlPattern.matcher(url.toExternalForm()).matches(),

Review Comment:
   The changes added in 2e8e0b3 should address this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org