You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/06 03:01:00 UTC

[jira] [Commented] (ROCKETMQ-365) Add consume times stat and fix client log

    [ https://issues.apache.org/jira/browse/ROCKETMQ-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353272#comment-16353272 ] 

ASF GitHub Bot commented on ROCKETMQ-365:
-----------------------------------------

lindzh opened a new pull request #223: [ROCKETMQ-365] Add consume times stat and fix client log
URL: https://github.com/apache/rocketmq/pull/223
 
 
   ## What is the purpose of the change
   
   1. We need to known post time stat since there is failure in consume. 
   2. updateConsumeOffsetToBroker log in client is large as log level is info.
   
   ## Brief changelog
   
   1. Add consume post time stat.
   2. delete updateConsumeOffsetToBroker info log
   
   ## Verifying this change
   
   I think there is no need to add testcases for this PR.
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [x] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add consume times stat and fix client log
> -----------------------------------------
>
>                 Key: ROCKETMQ-365
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-365
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: lindzh
>            Assignee: vongosling
>            Priority: Major
>
> We need to known post time stat since there is failure in consume.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)