You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jason Dillon <ja...@planet57.com> on 2007/06/05 00:38:23 UTC
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Why is this needed?
--jason
On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote:
> Author: pmcmahan
> Date: Mon Jun 4 13:44:49 2007
> New Revision: 544258
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=544258
> Log:
> GERONIMO-3209 jspc maven plugin fails in some environments when the
> injectString is not explicitly declared
>
> Modified:
> geronimo/server/trunk/applications/console/geronimo-console-
> framework/pom.xml
> geronimo/server/trunk/applications/console/geronimo-console-
> standard/pom.xml
> geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
> geronimo/server/trunk/applications/geronimo-examples/geronimo-
> jsp-examples/pom.xml
> geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
> geronimo/server/trunk/applications/geronimo-remote-deploy/pom.xml
> geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
> geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>
> Modified: geronimo/server/trunk/applications/console/geronimo-
> console-framework/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> applications/console/geronimo-console-framework/pom.xml?
> view=diff&rev=544258&r1=544257&r2=544258
> ======================================================================
> ========
> --- geronimo/server/trunk/applications/console/geronimo-console-
> framework/pom.xml (original)
> +++ geronimo/server/trunk/applications/console/geronimo-console-
> framework/pom.xml Mon Jun 4 13:44:49 2007
> @@ -86,6 +86,9 @@
> <plugin>
> <groupId>org.codehaus.mojo.jspc</groupId>
> <artifactId>jspc-maven-plugin</artifactId>
> + <configuration>
> + <injectString><!-- [INSERT FRAGMENT HERE] --
> ></injectString>
> + </configuration>
> </plugin>
>
> <plugin>
>
> Modified: geronimo/server/trunk/applications/console/geronimo-
> console-standard/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> applications/console/geronimo-console-standard/pom.xml?
> view=diff&rev=544258&r1=544257&r2=544258
> ======================================================================
> ========
> --- geronimo/server/trunk/applications/console/geronimo-console-
> standard/pom.xml (original)
> +++ geronimo/server/trunk/applications/console/geronimo-console-
> standard/pom.xml Mon Jun 4 13:44:49 2007
> @@ -142,6 +142,9 @@
> <plugin>
> <groupId>org.codehaus.mojo.jspc</groupId>
> <artifactId>jspc-maven-plugin</artifactId>
> + <configuration>
> + <injectString><!-- [INSERT FRAGMENT HERE] --
> ></injectString>
> + </configuration>
> </plugin>
>
> <plugin>
>
> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/
> pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> applications/geronimo-ca-helper/pom.xml?
> view=diff&rev=544258&r1=544257&r2=544258
> ======================================================================
> ========
> --- geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
> (original)
> +++ geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
> Mon Jun 4 13:44:49 2007
> @@ -73,6 +73,9 @@
> <plugin>
> <groupId>org.codehaus.mojo.jspc</groupId>
> <artifactId>jspc-maven-plugin</artifactId>
> + <configuration>
> + <injectString><!-- [INSERT FRAGMENT HERE] --
> ></injectString>
> + </configuration>
> </plugin>
>
> <plugin>
>
> Modified: geronimo/server/trunk/applications/geronimo-examples/
> geronimo-jsp-examples/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> applications/geronimo-examples/geronimo-jsp-examples/pom.xml?
> view=diff&rev=544258&r1=544257&r2=544258
> ======================================================================
> ========
> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-
> jsp-examples/pom.xml (original)
> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-
> jsp-examples/pom.xml Mon Jun 4 13:44:49 2007
> @@ -60,6 +60,9 @@
> <plugin>
> <groupId>org.codehaus.mojo.jspc</groupId>
> <artifactId>jspc-maven-plugin</artifactId>
> + <configuration>
> + <injectString><!-- [INSERT FRAGMENT HERE] --
> ></injectString>
> + </configuration>
> </plugin>
>
> <plugin>
>
> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/
> pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> applications/geronimo-ldap-demo/pom.xml?
> view=diff&rev=544258&r1=544257&r2=544258
> ======================================================================
> ========
> --- geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
> (original)
> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
> Mon Jun 4 13:44:49 2007
> @@ -46,6 +46,9 @@
> <plugin>
> <groupId>org.codehaus.mojo.jspc</groupId>
> <artifactId>jspc-maven-plugin</artifactId>
> + <configuration>
> + <injectString><!-- [INSERT FRAGMENT HERE] --
> ></injectString>
> + </configuration>
> </plugin>
>
> <plugin>
>
> Modified: geronimo/server/trunk/applications/geronimo-remote-deploy/
> pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> applications/geronimo-remote-deploy/pom.xml?
> view=diff&rev=544258&r1=544257&r2=544258
> ======================================================================
> ========
> --- geronimo/server/trunk/applications/geronimo-remote-deploy/
> pom.xml (original)
> +++ geronimo/server/trunk/applications/geronimo-remote-deploy/
> pom.xml Mon Jun 4 13:44:49 2007
> @@ -60,6 +60,9 @@
> <plugin>
> <groupId>org.codehaus.mojo.jspc</groupId>
> <artifactId>jspc-maven-plugin</artifactId>
> + <configuration>
> + <injectString><!-- [INSERT FRAGMENT HERE] --
> ></injectString>
> + </configuration>
> </plugin>
>
> <plugin>
>
> Modified: geronimo/server/trunk/applications/geronimo-uddi-server/
> pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> applications/geronimo-uddi-server/pom.xml?
> view=diff&rev=544258&r1=544257&r2=544258
> ======================================================================
> ========
> --- geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
> (original)
> +++ geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
> Mon Jun 4 13:44:49 2007
> @@ -54,6 +54,9 @@
> <plugin>
> <groupId>org.codehaus.mojo.jspc</groupId>
> <artifactId>jspc-maven-plugin</artifactId>
> + <configuration>
> + <injectString><!-- [INSERT FRAGMENT HERE] --
> ></injectString>
> + </configuration>
> </plugin>
>
> <plugin>
>
> Modified: geronimo/server/trunk/applications/geronimo-welcome/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> applications/geronimo-welcome/pom.xml?
> view=diff&rev=544258&r1=544257&r2=544258
> ======================================================================
> ========
> --- geronimo/server/trunk/applications/geronimo-welcome/pom.xml
> (original)
> +++ geronimo/server/trunk/applications/geronimo-welcome/pom.xml Mon
> Jun 4 13:44:49 2007
> @@ -66,6 +66,9 @@
> <plugin>
> <groupId>org.codehaus.mojo.jspc</groupId>
> <artifactId>jspc-maven-plugin</artifactId>
> + <configuration>
> + <injectString><!-- [INSERT FRAGMENT HERE] --
> ></injectString>
> + </configuration>
> </plugin>
>
> <plugin>
>
>
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Jason Dillon <ja...@planet57.com>.
Could have been that the first snapshot build was being used, which
had a problem generating web.xml.
Well, if you or anyone else can get any concrete details on the
failure I would like to know about it so I can fix the plugin.
Thanks,
--jason
On Jun 6, 2007, at 6:13 PM, Anita Kulshreshtha wrote:
> FWIW, I am using windows XP, Sun JDK-1.5.0_11 and maven 2.0.6.
> Yesterday I hit 2 problems which went away after cleaning up relevant
> parts of .m2 repo (mvn-jspc-plugin and o.a.g.applications). I have not
> been able to reproduce it today with or w/o inject string.
>
> Thanks
> Anita
>
>
>> I'd really like to get more information on the corruption that
>> occurs, and what issues it has on windows. I can't see anything
>> obvious in the code which would cause it be have so strangely. If
>> you can, please tell me exactly what the plugin spits out and what
>> the precise corruption is... so I can fix the plugin and add
>> integration tests to keep it fixed.
>>
>> Thanks,
>>
>> --jason
>>
>>
>> On Jun 6, 2007, at 9:24 AM, Paul McMahan wrote:
>>
>>> Strange, I don't understand why we're seeing inconsistent behavior
>>
>>> across different environments. Should be OK to go ahead and commit
>>
>>> your further refinements to how we invoke the plugin and then let's
>>
>>> keep an eye on it.
>>>
>>> Best wishes,
>>> Paul
>>>
>>> On Jun 6, 2007, at 11:34 AM, Donald Woods wrote:
>>>
>>>> These changes are actually breaking my builds on WinXP w/ Sun
>>>> 1.5.0_11 and Maven 2.0.6 now for the Tomcat config of geronimo-
>>>> welcome app.
>>>> If I remove the added <configuration> attributes from jspc-maven-
>>>> plugin, remove the Fragment comment from the web.xml source and
>>>> use the 20070603 snapshot of jspc-maven-plugin, then it builds
>>>> fine again....
>>>>
>>>> -Donald
>>>>
>>>>
>>>> Paul McMahan wrote:
>>>>> On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
>>>>>> Why would Geronimo fail to parse an xml file with a valid xml
>>>>>> comment?
>>>>> Good question. I should be able to revert locally and recreate
>>>>> the error if you'd like to see some more data.
>>>>>> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-
>>>>>> plugin which may have caused the generated web.xml to be
>>>>>> corrupt, but I've fixed that.
>>>>>>
>>>>>> I don't believe that the previous version of the plugin
>>>>>> defaulted the injectString to <!-- [INSERT FRAGMENT HERE] -->
>>>>>> though... unless it was removed in the trunk version which was
>>>>>> what I based the new version on. As I mentioned before, the
>>>>>> default injectString was '</web-app>' and I left it that way.
>>>>> I didn't look at the source for the previous version. My
>>>>> comments about it were based on a conversation I had on IRC. At
>>
>>>>> any rate, specifying the placeholder string is consistent with
>>>>> the plugin doc at:
>>>>> http://mojo.codehaus.org/jspc-maven-plugin/usage.html
>>>>> and resolved the compile error for those unfortunate souls that
>>>>> encountered it.
>>>>> Best wishes,
>>>>> Paul
>>>
>>
>>
>
>
>
>
> ______________________________________________________________________
> ______________Ready for the edge of your seat?
> Check out tonight's top picks on Yahoo! TV.
> http://tv.yahoo.com/
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Anita Kulshreshtha <a_...@yahoo.com>.
FWIW, I am using windows XP, Sun JDK-1.5.0_11 and maven 2.0.6.
Yesterday I hit 2 problems which went away after cleaning up relevant
parts of .m2 repo (mvn-jspc-plugin and o.a.g.applications). I have not
been able to reproduce it today with or w/o inject string.
Thanks
Anita
> I'd really like to get more information on the corruption that
> occurs, and what issues it has on windows. I can't see anything
> obvious in the code which would cause it be have so strangely. If
> you can, please tell me exactly what the plugin spits out and what
> the precise corruption is... so I can fix the plugin and add
> integration tests to keep it fixed.
>
> Thanks,
>
> --jason
>
>
> On Jun 6, 2007, at 9:24 AM, Paul McMahan wrote:
>
> > Strange, I don't understand why we're seeing inconsistent behavior
>
> > across different environments. Should be OK to go ahead and commit
>
> > your further refinements to how we invoke the plugin and then let's
>
> > keep an eye on it.
> >
> > Best wishes,
> > Paul
> >
> > On Jun 6, 2007, at 11:34 AM, Donald Woods wrote:
> >
> >> These changes are actually breaking my builds on WinXP w/ Sun
> >> 1.5.0_11 and Maven 2.0.6 now for the Tomcat config of geronimo-
> >> welcome app.
> >> If I remove the added <configuration> attributes from jspc-maven-
> >> plugin, remove the Fragment comment from the web.xml source and
> >> use the 20070603 snapshot of jspc-maven-plugin, then it builds
> >> fine again....
> >>
> >> -Donald
> >>
> >>
> >> Paul McMahan wrote:
> >>> On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
> >>>> Why would Geronimo fail to parse an xml file with a valid xml
> >>>> comment?
> >>> Good question. I should be able to revert locally and recreate
> >>> the error if you'd like to see some more data.
> >>>> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-
> >>>> plugin which may have caused the generated web.xml to be
> >>>> corrupt, but I've fixed that.
> >>>>
> >>>> I don't believe that the previous version of the plugin
> >>>> defaulted the injectString to <!-- [INSERT FRAGMENT HERE] -->
> >>>> though... unless it was removed in the trunk version which was
> >>>> what I based the new version on. As I mentioned before, the
> >>>> default injectString was '</web-app>' and I left it that way.
> >>> I didn't look at the source for the previous version. My
> >>> comments about it were based on a conversation I had on IRC. At
>
> >>> any rate, specifying the placeholder string is consistent with
> >>> the plugin doc at:
> >>> http://mojo.codehaus.org/jspc-maven-plugin/usage.html
> >>> and resolved the compile error for those unfortunate souls that
> >>> encountered it.
> >>> Best wishes,
> >>> Paul
> >
>
>
____________________________________________________________________________________Ready for the edge of your seat?
Check out tonight's top picks on Yahoo! TV.
http://tv.yahoo.com/
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Jason Dillon <ja...@planet57.com>.
I'd really like to get more information on the corruption that
occurs, and what issues it has on windows. I can't see anything
obvious in the code which would cause it be have so strangely. If
you can, please tell me exactly what the plugin spits out and what
the precise corruption is... so I can fix the plugin and add
integration tests to keep it fixed.
Thanks,
--jason
On Jun 6, 2007, at 9:24 AM, Paul McMahan wrote:
> Strange, I don't understand why we're seeing inconsistent behavior
> across different environments. Should be OK to go ahead and commit
> your further refinements to how we invoke the plugin and then let's
> keep an eye on it.
>
> Best wishes,
> Paul
>
> On Jun 6, 2007, at 11:34 AM, Donald Woods wrote:
>
>> These changes are actually breaking my builds on WinXP w/ Sun
>> 1.5.0_11 and Maven 2.0.6 now for the Tomcat config of geronimo-
>> welcome app.
>> If I remove the added <configuration> attributes from jspc-maven-
>> plugin, remove the Fragment comment from the web.xml source and
>> use the 20070603 snapshot of jspc-maven-plugin, then it builds
>> fine again....
>>
>> -Donald
>>
>>
>> Paul McMahan wrote:
>>> On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
>>>> Why would Geronimo fail to parse an xml file with a valid xml
>>>> comment?
>>> Good question. I should be able to revert locally and recreate
>>> the error if you'd like to see some more data.
>>>> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-
>>>> plugin which may have caused the generated web.xml to be
>>>> corrupt, but I've fixed that.
>>>>
>>>> I don't believe that the previous version of the plugin
>>>> defaulted the injectString to <!-- [INSERT FRAGMENT HERE] -->
>>>> though... unless it was removed in the trunk version which was
>>>> what I based the new version on. As I mentioned before, the
>>>> default injectString was '</web-app>' and I left it that way.
>>> I didn't look at the source for the previous version. My
>>> comments about it were based on a conversation I had on IRC. At
>>> any rate, specifying the placeholder string is consistent with
>>> the plugin doc at:
>>> http://mojo.codehaus.org/jspc-maven-plugin/usage.html
>>> and resolved the compile error for those unfortunate souls that
>>> encountered it.
>>> Best wishes,
>>> Paul
>
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Jason Dillon <ja...@planet57.com>.
Can you paste me one of the corrupted web.xml files please?
--jason
On Jun 6, 2007, at 10:20 AM, Donald Woods wrote:
> The fragment and <configuration> is in the code in trunk right now,
> which is causing my build failures on WinXP, but not SLED10/SLES10....
>
> The error I'm seeing, is when the CAR files are created, because
> the jspc updated web.xml files have duplicate <webapp> entries. It
> seems that where the Fragment comment is located in the source
> web.xml, the jspc plugin is placing a complete copy of its updated
> web.xml where the comment is, which creates a web.xml with 2
> <webapp> sections and causes the CAR build to fail with a XML
> parsing error.
>
> I don't have a build output to paste here, as I'm testing a build
> that has the fragment comments and <configuration> code removed to
> verify it works on WinXP and SLED10....
>
> -Donald
>
>
> Anita Kulshreshtha wrote:
>> Donald,
>> If you add the <configuration> and the fragment comment, can you
>> reproduce the error? Do you see the error mentioned in this thread
>> or a
>> NCDFE o.a.AnnotationProcessor.
>> Thanks
>> Anita
>> --- Paul McMahan <pa...@gmail.com> wrote:
>>> Strange, I don't understand why we're seeing inconsistent
>>> behavior across different environments. Should be OK to go
>>> ahead and commit your further refinements to how we invoke the
>>> plugin and then let's keep an eye on it.
>>>
>>> Best wishes,
>>> Paul
>>>
>>> On Jun 6, 2007, at 11:34 AM, Donald Woods wrote:
>>>
>>>> These changes are actually breaking my builds on WinXP w/ Sun
>>>> 1.5.0_11 and Maven 2.0.6 now for the Tomcat config of geronimo-
>>>> welcome app.
>>>> If I remove the added <configuration> attributes from jspc-
>>>> maven- plugin, remove the Fragment comment from the web.xml
>>>> source and use
>>>
>>>> the 20070603 snapshot of jspc-maven-plugin, then it builds fine
>>>> again....
>>>>
>>>> -Donald
>>>>
>>>>
>>>> Paul McMahan wrote:
>>>>> On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
>>>>>> Why would Geronimo fail to parse an xml file with a valid xml
>>>>>> comment?
>>>>> Good question. I should be able to revert locally and
>>>>> recreate the error if you'd like to see some more data.
>>>>>> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-
>>>>>> plugin which may have caused the generated web.xml to be corrupt,
>>>
>>>>>> but I've fixed that.
>>>>>>
>>>>>> I don't believe that the previous version of the plugin defaulted
>>>
>>>>>> the injectString to <!-- [INSERT FRAGMENT HERE] --> though...
>>>>>> unless it was removed in the trunk version which was what I based
>>>
>>>>>> the new version on. As I mentioned before, the default
>>>>>> injectString was '</web-app>' and I left it that way.
>>>>> I didn't look at the source for the previous version. My comments
>>>
>>>>> about it were based on a conversation I had on IRC. At any
>>>>> rate, specifying the placeholder string is consistent with the
>>>>> plugin doc at:
>>>>> http://mojo.codehaus.org/jspc-maven-plugin/usage.html
>>>>> and resolved the compile error for those unfortunate souls
>>>>> that encountered it.
>>>>> Best wishes,
>>>>> Paul
>>>
>>
>> _____________________________________________________________________
>> _______________
>> Sick sense of humor? Visit Yahoo! TV's Comedy with an Edge to see
>> what's on, when. http://tv.yahoo.com/collections/222
Re: svn commit: r544258 - in /geronimo/server/trunk/applications:
console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/
geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/
geronimo-uddi-...
Posted by Donald Woods <dw...@apache.org>.
The fragment and <configuration> is in the code in trunk right now, which is
causing my build failures on WinXP, but not SLED10/SLES10....
The error I'm seeing, is when the CAR files are created, because the jspc
updated web.xml files have duplicate <webapp> entries. It seems that where
the Fragment comment is located in the source web.xml, the jspc plugin is
placing a complete copy of its updated web.xml where the comment is, which
creates a web.xml with 2 <webapp> sections and causes the CAR build to fail
with a XML parsing error.
I don't have a build output to paste here, as I'm testing a build that has the
fragment comments and <configuration> code removed to verify it works on WinXP
and SLED10....
-Donald
Anita Kulshreshtha wrote:
> Donald,
> If you add the <configuration> and the fragment comment, can you
> reproduce the error? Do you see the error mentioned in this thread or a
> NCDFE o.a.AnnotationProcessor.
>
> Thanks
> Anita
>
> --- Paul McMahan <pa...@gmail.com> wrote:
>
>> Strange, I don't understand why we're seeing inconsistent behavior
>> across different environments. Should be OK to go ahead and commit
>> your further refinements to how we invoke the plugin and then let's
>> keep an eye on it.
>>
>> Best wishes,
>> Paul
>>
>> On Jun 6, 2007, at 11:34 AM, Donald Woods wrote:
>>
>>> These changes are actually breaking my builds on WinXP w/ Sun
>>> 1.5.0_11 and Maven 2.0.6 now for the Tomcat config of geronimo-
>>> welcome app.
>>> If I remove the added <configuration> attributes from jspc-maven-
>>> plugin, remove the Fragment comment from the web.xml source and use
>>
>>> the 20070603 snapshot of jspc-maven-plugin, then it builds fine
>>> again....
>>>
>>> -Donald
>>>
>>>
>>> Paul McMahan wrote:
>>>> On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
>>>>> Why would Geronimo fail to parse an xml file with a valid xml
>>>>> comment?
>>>> Good question. I should be able to revert locally and recreate
>>>> the error if you'd like to see some more data.
>>>>> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-
>>>>> plugin which may have caused the generated web.xml to be corrupt,
>>
>>>>> but I've fixed that.
>>>>>
>>>>> I don't believe that the previous version of the plugin defaulted
>>
>>>>> the injectString to <!-- [INSERT FRAGMENT HERE] --> though...
>>>>> unless it was removed in the trunk version which was what I based
>>
>>>>> the new version on. As I mentioned before, the default
>>>>> injectString was '</web-app>' and I left it that way.
>>>> I didn't look at the source for the previous version. My comments
>>
>>>> about it were based on a conversation I had on IRC. At any rate,
>>>> specifying the placeholder string is consistent with the plugin
>>>> doc at:
>>>> http://mojo.codehaus.org/jspc-maven-plugin/usage.html
>>>> and resolved the compile error for those unfortunate souls that
>>>> encountered it.
>>>> Best wishes,
>>>> Paul
>>
>
>
>
>
> ____________________________________________________________________________________
> Sick sense of humor? Visit Yahoo! TV's
> Comedy with an Edge to see what's on, when.
> http://tv.yahoo.com/collections/222
>
>
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Anita Kulshreshtha <a_...@yahoo.com>.
Donald,
If you add the <configuration> and the fragment comment, can you
reproduce the error? Do you see the error mentioned in this thread or a
NCDFE o.a.AnnotationProcessor.
Thanks
Anita
--- Paul McMahan <pa...@gmail.com> wrote:
> Strange, I don't understand why we're seeing inconsistent behavior
> across different environments. Should be OK to go ahead and commit
> your further refinements to how we invoke the plugin and then let's
> keep an eye on it.
>
> Best wishes,
> Paul
>
> On Jun 6, 2007, at 11:34 AM, Donald Woods wrote:
>
> > These changes are actually breaking my builds on WinXP w/ Sun
> > 1.5.0_11 and Maven 2.0.6 now for the Tomcat config of geronimo-
> > welcome app.
> > If I remove the added <configuration> attributes from jspc-maven-
> > plugin, remove the Fragment comment from the web.xml source and use
>
> > the 20070603 snapshot of jspc-maven-plugin, then it builds fine
> > again....
> >
> > -Donald
> >
> >
> > Paul McMahan wrote:
> >> On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
> >>> Why would Geronimo fail to parse an xml file with a valid xml
> >>> comment?
> >> Good question. I should be able to revert locally and recreate
> >> the error if you'd like to see some more data.
> >>> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-
> >>> plugin which may have caused the generated web.xml to be corrupt,
>
> >>> but I've fixed that.
> >>>
> >>> I don't believe that the previous version of the plugin defaulted
>
> >>> the injectString to <!-- [INSERT FRAGMENT HERE] --> though...
> >>> unless it was removed in the trunk version which was what I based
>
> >>> the new version on. As I mentioned before, the default
> >>> injectString was '</web-app>' and I left it that way.
> >> I didn't look at the source for the previous version. My comments
>
> >> about it were based on a conversation I had on IRC. At any rate,
>
> >> specifying the placeholder string is consistent with the plugin
> >> doc at:
> >> http://mojo.codehaus.org/jspc-maven-plugin/usage.html
> >> and resolved the compile error for those unfortunate souls that
> >> encountered it.
> >> Best wishes,
> >> Paul
>
>
____________________________________________________________________________________
Sick sense of humor? Visit Yahoo! TV's
Comedy with an Edge to see what's on, when.
http://tv.yahoo.com/collections/222
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Paul McMahan <pa...@gmail.com>.
Strange, I don't understand why we're seeing inconsistent behavior
across different environments. Should be OK to go ahead and commit
your further refinements to how we invoke the plugin and then let's
keep an eye on it.
Best wishes,
Paul
On Jun 6, 2007, at 11:34 AM, Donald Woods wrote:
> These changes are actually breaking my builds on WinXP w/ Sun
> 1.5.0_11 and Maven 2.0.6 now for the Tomcat config of geronimo-
> welcome app.
> If I remove the added <configuration> attributes from jspc-maven-
> plugin, remove the Fragment comment from the web.xml source and use
> the 20070603 snapshot of jspc-maven-plugin, then it builds fine
> again....
>
> -Donald
>
>
> Paul McMahan wrote:
>> On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
>>> Why would Geronimo fail to parse an xml file with a valid xml
>>> comment?
>> Good question. I should be able to revert locally and recreate
>> the error if you'd like to see some more data.
>>> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-
>>> plugin which may have caused the generated web.xml to be corrupt,
>>> but I've fixed that.
>>>
>>> I don't believe that the previous version of the plugin defaulted
>>> the injectString to <!-- [INSERT FRAGMENT HERE] --> though...
>>> unless it was removed in the trunk version which was what I based
>>> the new version on. As I mentioned before, the default
>>> injectString was '</web-app>' and I left it that way.
>> I didn't look at the source for the previous version. My comments
>> about it were based on a conversation I had on IRC. At any rate,
>> specifying the placeholder string is consistent with the plugin
>> doc at:
>> http://mojo.codehaus.org/jspc-maven-plugin/usage.html
>> and resolved the compile error for those unfortunate souls that
>> encountered it.
>> Best wishes,
>> Paul
Re: svn commit: r544258 - in /geronimo/server/trunk/applications:
console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/
geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/
geronimo-uddi-...
Posted by Donald Woods <dw...@apache.org>.
These changes are actually breaking my builds on WinXP w/ Sun 1.5.0_11 and
Maven 2.0.6 now for the Tomcat config of geronimo-welcome app.
If I remove the added <configuration> attributes from jspc-maven-plugin,
remove the Fragment comment from the web.xml source and use the 20070603
snapshot of jspc-maven-plugin, then it builds fine again....
-Donald
Paul McMahan wrote:
> On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
>
>> Why would Geronimo fail to parse an xml file with a valid xml comment?
>
> Good question. I should be able to revert locally and recreate the
> error if you'd like to see some more data.
>
>> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-plugin
>> which may have caused the generated web.xml to be corrupt, but I've
>> fixed that.
>>
>> I don't believe that the previous version of the plugin defaulted the
>> injectString to <!-- [INSERT FRAGMENT HERE] --> though... unless it
>> was removed in the trunk version which was what I based the new
>> version on. As I mentioned before, the default injectString was
>> '</web-app>' and I left it that way.
>
> I didn't look at the source for the previous version. My comments about
> it were based on a conversation I had on IRC. At any rate, specifying
> the placeholder string is consistent with the plugin doc at:
> http://mojo.codehaus.org/jspc-maven-plugin/usage.html
> and resolved the compile error for those unfortunate souls that
> encountered it.
>
> Best wishes,
> Paul
>
>
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Paul McMahan <pa...@gmail.com>.
On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
> Why would Geronimo fail to parse an xml file with a valid xml comment?
Good question. I should be able to revert locally and recreate the
error if you'd like to see some more data.
> There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-plugin
> which may have caused the generated web.xml to be corrupt, but I've
> fixed that.
>
> I don't believe that the previous version of the plugin defaulted
> the injectString to <!-- [INSERT FRAGMENT HERE] --> though...
> unless it was removed in the trunk version which was what I based
> the new version on. As I mentioned before, the default
> injectString was '</web-app>' and I left it that way.
I didn't look at the source for the previous version. My comments
about it were based on a conversation I had on IRC. At any rate,
specifying the placeholder string is consistent with the plugin doc at:
http://mojo.codehaus.org/jspc-maven-plugin/usage.html
and resolved the compile error for those unfortunate souls that
encountered it.
Best wishes,
Paul
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Jason Dillon <ja...@planet57.com>.
Why would Geronimo fail to parse an xml file with a valid xml comment?
There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-plugin
which may have caused the generated web.xml to be corrupt, but I've
fixed that.
I don't believe that the previous version of the plugin defaulted the
injectString to <!-- [INSERT FRAGMENT HERE] --> though... unless it
was removed in the trunk version which was what I based the new
version on. As I mentioned before, the default injectString was '</
web-app>' and I left it that way.
--jason
On Jun 5, 2007, at 6:51 AM, Paul McMahan wrote:
> I know of four developers that hit the error, but don't understand
> why everyone didn't hit it. Without the change I see the build
> error reported in GERONIMO-3209. I think that the previous plugin
> looked for '<!-- [INSERT FRAGMENT HERE] -->' by default and the new
> one does not. The result is that that placeholder string is left
> in web.xml which results in a parse error when geronimo tries to
> deploy it while building the configs.
>
> Best wishes,
> Paul
>
> On Jun 5, 2007, at 1:21 AM, Jason Dillon wrote:
>
>> From what I could tell, the previous jspc plugin didn't use that
>> string for a default replace token, instead it used '</web-app>'
>> if the injectString was not configured. The new plugin behaves
>> the same way.
>>
>> So... I'm not sure how the previous plugin handles replacing '<!--
>> [INSERT FRAGMENT HERE] -->' with the fragment w/o this configuration.
>>
>> What errors does it produce? I ran the build a few times and it
>> did not produce any errors.
>>
>> --jason
>>
>>
>> On Jun 4, 2007, at 7:17 PM, Paul McMahan wrote:
>>
>>> GERONIMO-3209 shows a build error that I and two others hit.
>>> From a brief conversation with Jeff on IRC, it seems that the
>>> current jspc plugin no longer supports the default placeholder
>>> keyword used by the geronimo applications:
>>> <!-- [INSERT FRAGMENT HERE] -->
>>> This commit fixes the build error.
>>>
>>> Best wishes,
>>> Paul
>>>
>>> On Jun 4, 2007, at 6:38 PM, Jason Dillon wrote:
>>>
>>>> Why is this needed?
>>>>
>>>> --jason
>>>>
>>>>
>>>> On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote:
>>>>
>>>>> Author: pmcmahan
>>>>> Date: Mon Jun 4 13:44:49 2007
>>>>> New Revision: 544258
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=544258
>>>>> Log:
>>>>> GERONIMO-3209 jspc maven plugin fails in some environments when
>>>>> the injectString is not explicitly declared
>>>>>
>>>>> Modified:
>>>>> geronimo/server/trunk/applications/console/geronimo-console-
>>>>> framework/pom.xml
>>>>> geronimo/server/trunk/applications/console/geronimo-console-
>>>>> standard/pom.xml
>>>>> geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>>>>> geronimo/server/trunk/applications/geronimo-examples/
>>>>> geronimo-jsp-examples/pom.xml
>>>>> geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>>>>> geronimo/server/trunk/applications/geronimo-remote-deploy/
>>>>> pom.xml
>>>>> geronimo/server/trunk/applications/geronimo-uddi-server/
>>>>> pom.xml
>>>>> geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>>>>
>>>>> Modified: geronimo/server/trunk/applications/console/geronimo-
>>>>> console-framework/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>>> applications/console/geronimo-console-framework/pom.xml?
>>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>>> ==================================================================
>>>>> ============
>>>>> --- geronimo/server/trunk/applications/console/geronimo-console-
>>>>> framework/pom.xml (original)
>>>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>>>>> framework/pom.xml Mon Jun 4 13:44:49 2007
>>>>> @@ -86,6 +86,9 @@
>>>>> <plugin>
>>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <injectString><!-- [INSERT FRAGMENT
>>>>> HERE] --></injectString>
>>>>> + </configuration>
>>>>> </plugin>
>>>>>
>>>>> <plugin>
>>>>>
>>>>> Modified: geronimo/server/trunk/applications/console/geronimo-
>>>>> console-standard/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>>> applications/console/geronimo-console-standard/pom.xml?
>>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>>> ==================================================================
>>>>> ============
>>>>> --- geronimo/server/trunk/applications/console/geronimo-console-
>>>>> standard/pom.xml (original)
>>>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>>>>> standard/pom.xml Mon Jun 4 13:44:49 2007
>>>>> @@ -142,6 +142,9 @@
>>>>> <plugin>
>>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <injectString><!-- [INSERT FRAGMENT
>>>>> HERE] --></injectString>
>>>>> + </configuration>
>>>>> </plugin>
>>>>>
>>>>> <plugin>
>>>>>
>>>>> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/
>>>>> pom.xml
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>>> applications/geronimo-ca-helper/pom.xml?
>>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>>> ==================================================================
>>>>> ============
>>>>> --- geronimo/server/trunk/applications/geronimo-ca-helper/
>>>>> pom.xml (original)
>>>>> +++ geronimo/server/trunk/applications/geronimo-ca-helper/
>>>>> pom.xml Mon Jun 4 13:44:49 2007
>>>>> @@ -73,6 +73,9 @@
>>>>> <plugin>
>>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <injectString><!-- [INSERT FRAGMENT
>>>>> HERE] --></injectString>
>>>>> + </configuration>
>>>>> </plugin>
>>>>>
>>>>> <plugin>
>>>>>
>>>>> Modified: geronimo/server/trunk/applications/geronimo-examples/
>>>>> geronimo-jsp-examples/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml?
>>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>>> ==================================================================
>>>>> ============
>>>>> --- geronimo/server/trunk/applications/geronimo-examples/
>>>>> geronimo-jsp-examples/pom.xml (original)
>>>>> +++ geronimo/server/trunk/applications/geronimo-examples/
>>>>> geronimo-jsp-examples/pom.xml Mon Jun 4 13:44:49 2007
>>>>> @@ -60,6 +60,9 @@
>>>>> <plugin>
>>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <injectString><!-- [INSERT FRAGMENT
>>>>> HERE] --></injectString>
>>>>> + </configuration>
>>>>> </plugin>
>>>>>
>>>>> <plugin>
>>>>>
>>>>> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/
>>>>> pom.xml
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>>> applications/geronimo-ldap-demo/pom.xml?
>>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>>> ==================================================================
>>>>> ============
>>>>> --- geronimo/server/trunk/applications/geronimo-ldap-demo/
>>>>> pom.xml (original)
>>>>> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/
>>>>> pom.xml Mon Jun 4 13:44:49 2007
>>>>> @@ -46,6 +46,9 @@
>>>>> <plugin>
>>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <injectString><!-- [INSERT FRAGMENT
>>>>> HERE] --></injectString>
>>>>> + </configuration>
>>>>> </plugin>
>>>>>
>>>>> <plugin>
>>>>>
>>>>> Modified: geronimo/server/trunk/applications/geronimo-remote-
>>>>> deploy/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>>> applications/geronimo-remote-deploy/pom.xml?
>>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>>> ==================================================================
>>>>> ============
>>>>> --- geronimo/server/trunk/applications/geronimo-remote-deploy/
>>>>> pom.xml (original)
>>>>> +++ geronimo/server/trunk/applications/geronimo-remote-deploy/
>>>>> pom.xml Mon Jun 4 13:44:49 2007
>>>>> @@ -60,6 +60,9 @@
>>>>> <plugin>
>>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <injectString><!-- [INSERT FRAGMENT
>>>>> HERE] --></injectString>
>>>>> + </configuration>
>>>>> </plugin>
>>>>>
>>>>> <plugin>
>>>>>
>>>>> Modified: geronimo/server/trunk/applications/geronimo-uddi-
>>>>> server/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>>> applications/geronimo-uddi-server/pom.xml?
>>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>>> ==================================================================
>>>>> ============
>>>>> --- geronimo/server/trunk/applications/geronimo-uddi-server/
>>>>> pom.xml (original)
>>>>> +++ geronimo/server/trunk/applications/geronimo-uddi-server/
>>>>> pom.xml Mon Jun 4 13:44:49 2007
>>>>> @@ -54,6 +54,9 @@
>>>>> <plugin>
>>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <injectString><!-- [INSERT FRAGMENT
>>>>> HERE] --></injectString>
>>>>> + </configuration>
>>>>> </plugin>
>>>>>
>>>>> <plugin>
>>>>>
>>>>> Modified: geronimo/server/trunk/applications/geronimo-welcome/
>>>>> pom.xml
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>>> applications/geronimo-welcome/pom.xml?
>>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>>> ==================================================================
>>>>> ============
>>>>> --- geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>>>> (original)
>>>>> +++ geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>>>> Mon Jun 4 13:44:49 2007
>>>>> @@ -66,6 +66,9 @@
>>>>> <plugin>
>>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <injectString><!-- [INSERT FRAGMENT
>>>>> HERE] --></injectString>
>>>>> + </configuration>
>>>>> </plugin>
>>>>>
>>>>> <plugin>
>>>>>
>>>>>
>>>>
>>>
>>
>
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Anita Kulshreshtha <a_...@yahoo.com>.
FYI: In early days of M2 build the plugin did look for this string.
It changed some time before Jan 2007. All the wars here have been built
using </web-app> as the inject string.
http://people.apache.org/repo/m2-snapshot-repository/org/apache/geronimo/applications/examples/geronimo-jsp-examples/2.0-SNAPSHOT/
Thanks
Anita
--- Paul McMahan <pa...@gmail.com> wrote:
>................ I think that the previous plugin looked
> for '<!-- [INSERT FRAGMENT HERE] -->' by default and the new one does
>
> not.
..........................................................
>
> On Jun 5, 2007, at 1:21 AM, Jason Dillon wrote:
>
> > From what I could tell, the previous jspc plugin didn't use that
> > string for a default replace token, instead it used '</web-app>' if
>
> > the injectString was not configured. The new plugin behaves the
> > same way.
> >
> > So... I'm not sure how the previous plugin handles replacing '<!--
>
> > [INSERT FRAGMENT HERE] -->' with the fragment w/o this
> configuration.
____________________________________________________________________________________
Be a better Globetrotter. Get better travel answers from someone who knows. Yahoo! Answers - Check it out.
http://answers.yahoo.com/dir/?link=list&sid=396545469
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Anita Kulshreshtha <a_...@yahoo.com>.
It would be interesting to know if all four error cases did a
partial build (i.e. application, config, assembly) without mvn -N from
the top directory.
Thanks
Anita
--- Paul McMahan <pa...@gmail.com> wrote:
> I know of four developers that hit the error, but don't understand
> why everyone didn't hit it.
Could be Maven magic!!! It would be interesting to know if all four
error cases did a partial build (i.e. application, config, assembly)
without mvn -N from the top directory.
Thanks
Anita
> Without the change I see the build error
>
> reported in GERONIMO-3209. I think that the previous plugin looked
> for '<!-- [INSERT FRAGMENT HERE] -->' by default and the new one does
>
> not. The result is that that placeholder string is left in web.xml
> which results in a parse error when geronimo tries to deploy it while
>
> building the configs.
>
> Best wishes,
> Paul
>
> On Jun 5, 2007, at 1:21 AM, Jason Dillon wrote:
>
> > From what I could tell, the previous jspc plugin didn't use that
> > string for a default replace token, instead it used '</web-app>' if
>
> > the injectString was not configured. The new plugin behaves the
> > same way.
> >
> > So... I'm not sure how the previous plugin handles replacing '<!--
>
> > [INSERT FRAGMENT HERE] -->' with the fragment w/o this
> configuration.
> >
> > What errors does it produce? I ran the build a few times and it
> > did not produce any errors.
> >
> > --jason
> >
> >
> > On Jun 4, 2007, at 7:17 PM, Paul McMahan wrote:
> >
> >> GERONIMO-3209 shows a build error that I and two others hit. From
>
> >> a brief conversation with Jeff on IRC, it seems that the current
> >> jspc plugin no longer supports the default placeholder keyword
> >> used by the geronimo applications:
> >> <!-- [INSERT FRAGMENT HERE] -->
> >> This commit fixes the build error.
> >>
> >> Best wishes,
> >> Paul
> >>
> >> On Jun 4, 2007, at 6:38 PM, Jason Dillon wrote:
> >>
> >>> Why is this needed?
> >>>
> >>> --jason
> >>>
> >>>
> >>> On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote:
> >>>
> >>>> Author: pmcmahan
> >>>> Date: Mon Jun 4 13:44:49 2007
> >>>> New Revision: 544258
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?view=rev&rev=544258
> >>>> Log:
> >>>> GERONIMO-3209 jspc maven plugin fails in some environments when
>
> >>>> the injectString is not explicitly declared
> >>>>
> >>>> Modified:
> >>>> geronimo/server/trunk/applications/console/geronimo-console-
>
> >>>> framework/pom.xml
> >>>> geronimo/server/trunk/applications/console/geronimo-console-
>
> >>>> standard/pom.xml
> >>>>
> geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
> >>>> geronimo/server/trunk/applications/geronimo-examples/
> >>>> geronimo-jsp-examples/pom.xml
> >>>>
> geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
> >>>> geronimo/server/trunk/applications/geronimo-remote-deploy/
> >>>> pom.xml
> >>>>
> geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
> >>>> geronimo/server/trunk/applications/geronimo-welcome/pom.xml
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/console/geronimo-
> >>>> console-framework/pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> >>>> applications/console/geronimo-console-framework/pom.xml?
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> ===================================================================
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/console/geronimo-console-
>
> >>>> framework/pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>
> >>>> framework/pom.xml Mon Jun 4 13:44:49 2007
> >>>> @@ -86,6 +86,9 @@
> >>>> <plugin>
> >>>> <groupId>org.codehaus.mojo.jspc</groupId>
> >>>> <artifactId>jspc-maven-plugin</artifactId>
> >>>> + <configuration>
> >>>> + <injectString><!-- [INSERT FRAGMENT
> >>>> HERE] --></injectString>
> >>>> + </configuration>
> >>>> </plugin>
> >>>>
> >>>> <plugin>
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/console/geronimo-
> >>>> console-standard/pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> >>>> applications/console/geronimo-console-standard/pom.xml?
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> ===================================================================
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/console/geronimo-console-
>
> >>>> standard/pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>
> >>>> standard/pom.xml Mon Jun 4 13:44:49 2007
> >>>> @@ -142,6 +142,9 @@
> >>>> <plugin>
> >>>> <groupId>org.codehaus.mojo.jspc</groupId>
> >>>> <artifactId>jspc-maven-plugin</artifactId>
> >>>> + <configuration>
> >>>> + <injectString><!-- [INSERT FRAGMENT
> >>>> HERE] --></injectString>
> >>>> + </configuration>
> >>>> </plugin>
> >>>>
> >>>> <plugin>
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/
>
> >>>> pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> >>>> applications/geronimo-ca-helper/pom.xml?
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> ===================================================================
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/geronimo-ca-helper/
> >>>> pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/geronimo-ca-helper/
> >>>> pom.xml Mon Jun 4 13:44:49 2007
> >>>> @@ -73,6 +73,9 @@
> >>>> <plugin>
> >>>> <groupId>org.codehaus.mojo.jspc</groupId>
> >>>> <artifactId>jspc-maven-plugin</artifactId>
> >>>> + <configuration>
> >>>> + <injectString><!-- [INSERT FRAGMENT
> >>>> HERE] --></injectString>
> >>>> + </configuration>
> >>>> </plugin>
> >>>>
> >>>> <plugin>
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/geronimo-examples/
> >>>> geronimo-jsp-examples/pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> >>>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml?
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> ===================================================================
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/geronimo-examples/
> >>>> geronimo-jsp-examples/pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/geronimo-examples/
> >>>> geronimo-jsp-examples/pom.xml Mon Jun 4 13:44:49 2007
> >>>> @@ -60,6 +60,9 @@
> >>>> <plugin>
> >>>> <groupId>org.codehaus.mojo.jspc</groupId>
> >>>> <artifactId>jspc-maven-plugin</artifactId>
> >>>> + <configuration>
> >>>> + <injectString><!-- [INSERT FRAGMENT
> >>>> HERE] --></injectString>
> >>>> + </configuration>
> >>>> </plugin>
> >>>>
> >>>> <plugin>
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/
>
> >>>> pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> >>>> applications/geronimo-ldap-demo/pom.xml?
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> ===================================================================
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/geronimo-ldap-demo/
> >>>> pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/
> >>>> pom.xml Mon Jun 4 13:44:49 2007
> >>>> @@ -46,6 +46,9 @@
> >>>> <plugin>
> >>>> <groupId>org.codehaus.mojo.jspc</groupId>
>
=== message truncated ===
____________________________________________________________________________________
Choose the right car based on your needs. Check out Yahoo! Autos new Car Finder tool.
http://autos.yahoo.com/carfinder/
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Paul McMahan <pa...@gmail.com>.
I know of four developers that hit the error, but don't understand
why everyone didn't hit it. Without the change I see the build error
reported in GERONIMO-3209. I think that the previous plugin looked
for '<!-- [INSERT FRAGMENT HERE] -->' by default and the new one does
not. The result is that that placeholder string is left in web.xml
which results in a parse error when geronimo tries to deploy it while
building the configs.
Best wishes,
Paul
On Jun 5, 2007, at 1:21 AM, Jason Dillon wrote:
> From what I could tell, the previous jspc plugin didn't use that
> string for a default replace token, instead it used '</web-app>' if
> the injectString was not configured. The new plugin behaves the
> same way.
>
> So... I'm not sure how the previous plugin handles replacing '<!--
> [INSERT FRAGMENT HERE] -->' with the fragment w/o this configuration.
>
> What errors does it produce? I ran the build a few times and it
> did not produce any errors.
>
> --jason
>
>
> On Jun 4, 2007, at 7:17 PM, Paul McMahan wrote:
>
>> GERONIMO-3209 shows a build error that I and two others hit. From
>> a brief conversation with Jeff on IRC, it seems that the current
>> jspc plugin no longer supports the default placeholder keyword
>> used by the geronimo applications:
>> <!-- [INSERT FRAGMENT HERE] -->
>> This commit fixes the build error.
>>
>> Best wishes,
>> Paul
>>
>> On Jun 4, 2007, at 6:38 PM, Jason Dillon wrote:
>>
>>> Why is this needed?
>>>
>>> --jason
>>>
>>>
>>> On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote:
>>>
>>>> Author: pmcmahan
>>>> Date: Mon Jun 4 13:44:49 2007
>>>> New Revision: 544258
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=544258
>>>> Log:
>>>> GERONIMO-3209 jspc maven plugin fails in some environments when
>>>> the injectString is not explicitly declared
>>>>
>>>> Modified:
>>>> geronimo/server/trunk/applications/console/geronimo-console-
>>>> framework/pom.xml
>>>> geronimo/server/trunk/applications/console/geronimo-console-
>>>> standard/pom.xml
>>>> geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>>>> geronimo/server/trunk/applications/geronimo-examples/
>>>> geronimo-jsp-examples/pom.xml
>>>> geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>>>> geronimo/server/trunk/applications/geronimo-remote-deploy/
>>>> pom.xml
>>>> geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
>>>> geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>>>
>>>> Modified: geronimo/server/trunk/applications/console/geronimo-
>>>> console-framework/pom.xml
>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>> applications/console/geronimo-console-framework/pom.xml?
>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>> ===================================================================
>>>> ===========
>>>> --- geronimo/server/trunk/applications/console/geronimo-console-
>>>> framework/pom.xml (original)
>>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>>>> framework/pom.xml Mon Jun 4 13:44:49 2007
>>>> @@ -86,6 +86,9 @@
>>>> <plugin>
>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>> + <configuration>
>>>> + <injectString><!-- [INSERT FRAGMENT
>>>> HERE] --></injectString>
>>>> + </configuration>
>>>> </plugin>
>>>>
>>>> <plugin>
>>>>
>>>> Modified: geronimo/server/trunk/applications/console/geronimo-
>>>> console-standard/pom.xml
>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>> applications/console/geronimo-console-standard/pom.xml?
>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>> ===================================================================
>>>> ===========
>>>> --- geronimo/server/trunk/applications/console/geronimo-console-
>>>> standard/pom.xml (original)
>>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>>>> standard/pom.xml Mon Jun 4 13:44:49 2007
>>>> @@ -142,6 +142,9 @@
>>>> <plugin>
>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>> + <configuration>
>>>> + <injectString><!-- [INSERT FRAGMENT
>>>> HERE] --></injectString>
>>>> + </configuration>
>>>> </plugin>
>>>>
>>>> <plugin>
>>>>
>>>> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/
>>>> pom.xml
>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>> applications/geronimo-ca-helper/pom.xml?
>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>> ===================================================================
>>>> ===========
>>>> --- geronimo/server/trunk/applications/geronimo-ca-helper/
>>>> pom.xml (original)
>>>> +++ geronimo/server/trunk/applications/geronimo-ca-helper/
>>>> pom.xml Mon Jun 4 13:44:49 2007
>>>> @@ -73,6 +73,9 @@
>>>> <plugin>
>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>> + <configuration>
>>>> + <injectString><!-- [INSERT FRAGMENT
>>>> HERE] --></injectString>
>>>> + </configuration>
>>>> </plugin>
>>>>
>>>> <plugin>
>>>>
>>>> Modified: geronimo/server/trunk/applications/geronimo-examples/
>>>> geronimo-jsp-examples/pom.xml
>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml?
>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>> ===================================================================
>>>> ===========
>>>> --- geronimo/server/trunk/applications/geronimo-examples/
>>>> geronimo-jsp-examples/pom.xml (original)
>>>> +++ geronimo/server/trunk/applications/geronimo-examples/
>>>> geronimo-jsp-examples/pom.xml Mon Jun 4 13:44:49 2007
>>>> @@ -60,6 +60,9 @@
>>>> <plugin>
>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>> + <configuration>
>>>> + <injectString><!-- [INSERT FRAGMENT
>>>> HERE] --></injectString>
>>>> + </configuration>
>>>> </plugin>
>>>>
>>>> <plugin>
>>>>
>>>> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/
>>>> pom.xml
>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>> applications/geronimo-ldap-demo/pom.xml?
>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>> ===================================================================
>>>> ===========
>>>> --- geronimo/server/trunk/applications/geronimo-ldap-demo/
>>>> pom.xml (original)
>>>> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/
>>>> pom.xml Mon Jun 4 13:44:49 2007
>>>> @@ -46,6 +46,9 @@
>>>> <plugin>
>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>> + <configuration>
>>>> + <injectString><!-- [INSERT FRAGMENT
>>>> HERE] --></injectString>
>>>> + </configuration>
>>>> </plugin>
>>>>
>>>> <plugin>
>>>>
>>>> Modified: geronimo/server/trunk/applications/geronimo-remote-
>>>> deploy/pom.xml
>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>> applications/geronimo-remote-deploy/pom.xml?
>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>> ===================================================================
>>>> ===========
>>>> --- geronimo/server/trunk/applications/geronimo-remote-deploy/
>>>> pom.xml (original)
>>>> +++ geronimo/server/trunk/applications/geronimo-remote-deploy/
>>>> pom.xml Mon Jun 4 13:44:49 2007
>>>> @@ -60,6 +60,9 @@
>>>> <plugin>
>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>> + <configuration>
>>>> + <injectString><!-- [INSERT FRAGMENT
>>>> HERE] --></injectString>
>>>> + </configuration>
>>>> </plugin>
>>>>
>>>> <plugin>
>>>>
>>>> Modified: geronimo/server/trunk/applications/geronimo-uddi-
>>>> server/pom.xml
>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>> applications/geronimo-uddi-server/pom.xml?
>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>> ===================================================================
>>>> ===========
>>>> --- geronimo/server/trunk/applications/geronimo-uddi-server/
>>>> pom.xml (original)
>>>> +++ geronimo/server/trunk/applications/geronimo-uddi-server/
>>>> pom.xml Mon Jun 4 13:44:49 2007
>>>> @@ -54,6 +54,9 @@
>>>> <plugin>
>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>> + <configuration>
>>>> + <injectString><!-- [INSERT FRAGMENT
>>>> HERE] --></injectString>
>>>> + </configuration>
>>>> </plugin>
>>>>
>>>> <plugin>
>>>>
>>>> Modified: geronimo/server/trunk/applications/geronimo-welcome/
>>>> pom.xml
>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>>> applications/geronimo-welcome/pom.xml?
>>>> view=diff&rev=544258&r1=544257&r2=544258
>>>> ===================================================================
>>>> ===========
>>>> --- geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>>> (original)
>>>> +++ geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>>> Mon Jun 4 13:44:49 2007
>>>> @@ -66,6 +66,9 @@
>>>> <plugin>
>>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>>> <artifactId>jspc-maven-plugin</artifactId>
>>>> + <configuration>
>>>> + <injectString><!-- [INSERT FRAGMENT
>>>> HERE] --></injectString>
>>>> + </configuration>
>>>> </plugin>
>>>>
>>>> <plugin>
>>>>
>>>>
>>>
>>
>
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Jason Dillon <ja...@planet57.com>.
From what I could tell, the previous jspc plugin didn't use that
string for a default replace token, instead it used '</web-app>' if
the injectString was not configured. The new plugin behaves the same
way.
So... I'm not sure how the previous plugin handles replacing '<!--
[INSERT FRAGMENT HERE] -->' with the fragment w/o this configuration.
What errors does it produce? I ran the build a few times and it did
not produce any errors.
--jason
On Jun 4, 2007, at 7:17 PM, Paul McMahan wrote:
> GERONIMO-3209 shows a build error that I and two others hit. From
> a brief conversation with Jeff on IRC, it seems that the current
> jspc plugin no longer supports the default placeholder keyword used
> by the geronimo applications:
> <!-- [INSERT FRAGMENT HERE] -->
> This commit fixes the build error.
>
> Best wishes,
> Paul
>
> On Jun 4, 2007, at 6:38 PM, Jason Dillon wrote:
>
>> Why is this needed?
>>
>> --jason
>>
>>
>> On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote:
>>
>>> Author: pmcmahan
>>> Date: Mon Jun 4 13:44:49 2007
>>> New Revision: 544258
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=544258
>>> Log:
>>> GERONIMO-3209 jspc maven plugin fails in some environments when
>>> the injectString is not explicitly declared
>>>
>>> Modified:
>>> geronimo/server/trunk/applications/console/geronimo-console-
>>> framework/pom.xml
>>> geronimo/server/trunk/applications/console/geronimo-console-
>>> standard/pom.xml
>>> geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>>> geronimo/server/trunk/applications/geronimo-examples/geronimo-
>>> jsp-examples/pom.xml
>>> geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>>> geronimo/server/trunk/applications/geronimo-remote-deploy/
>>> pom.xml
>>> geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
>>> geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>>
>>> Modified: geronimo/server/trunk/applications/console/geronimo-
>>> console-framework/pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>> applications/console/geronimo-console-framework/pom.xml?
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ====================================================================
>>> ==========
>>> --- geronimo/server/trunk/applications/console/geronimo-console-
>>> framework/pom.xml (original)
>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>>> framework/pom.xml Mon Jun 4 13:44:49 2007
>>> @@ -86,6 +86,9 @@
>>> <plugin>
>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>> <artifactId>jspc-maven-plugin</artifactId>
>>> + <configuration>
>>> + <injectString><!-- [INSERT FRAGMENT HERE]
>>> --></injectString>
>>> + </configuration>
>>> </plugin>
>>>
>>> <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/console/geronimo-
>>> console-standard/pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>> applications/console/geronimo-console-standard/pom.xml?
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ====================================================================
>>> ==========
>>> --- geronimo/server/trunk/applications/console/geronimo-console-
>>> standard/pom.xml (original)
>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>>> standard/pom.xml Mon Jun 4 13:44:49 2007
>>> @@ -142,6 +142,9 @@
>>> <plugin>
>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>> <artifactId>jspc-maven-plugin</artifactId>
>>> + <configuration>
>>> + <injectString><!-- [INSERT FRAGMENT HERE]
>>> --></injectString>
>>> + </configuration>
>>> </plugin>
>>>
>>> <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/
>>> pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>> applications/geronimo-ca-helper/pom.xml?
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ====================================================================
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>>> (original)
>>> +++ geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>>> Mon Jun 4 13:44:49 2007
>>> @@ -73,6 +73,9 @@
>>> <plugin>
>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>> <artifactId>jspc-maven-plugin</artifactId>
>>> + <configuration>
>>> + <injectString><!-- [INSERT FRAGMENT HERE]
>>> --></injectString>
>>> + </configuration>
>>> </plugin>
>>>
>>> <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-examples/
>>> geronimo-jsp-examples/pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml?
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ====================================================================
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-
>>> jsp-examples/pom.xml (original)
>>> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-
>>> jsp-examples/pom.xml Mon Jun 4 13:44:49 2007
>>> @@ -60,6 +60,9 @@
>>> <plugin>
>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>> <artifactId>jspc-maven-plugin</artifactId>
>>> + <configuration>
>>> + <injectString><!-- [INSERT FRAGMENT HERE]
>>> --></injectString>
>>> + </configuration>
>>> </plugin>
>>>
>>> <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/
>>> pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>> applications/geronimo-ldap-demo/pom.xml?
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ====================================================================
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>>> (original)
>>> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>>> Mon Jun 4 13:44:49 2007
>>> @@ -46,6 +46,9 @@
>>> <plugin>
>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>> <artifactId>jspc-maven-plugin</artifactId>
>>> + <configuration>
>>> + <injectString><!-- [INSERT FRAGMENT HERE]
>>> --></injectString>
>>> + </configuration>
>>> </plugin>
>>>
>>> <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-remote-
>>> deploy/pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>> applications/geronimo-remote-deploy/pom.xml?
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ====================================================================
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-remote-deploy/
>>> pom.xml (original)
>>> +++ geronimo/server/trunk/applications/geronimo-remote-deploy/
>>> pom.xml Mon Jun 4 13:44:49 2007
>>> @@ -60,6 +60,9 @@
>>> <plugin>
>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>> <artifactId>jspc-maven-plugin</artifactId>
>>> + <configuration>
>>> + <injectString><!-- [INSERT FRAGMENT HERE]
>>> --></injectString>
>>> + </configuration>
>>> </plugin>
>>>
>>> <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-uddi-server/
>>> pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>> applications/geronimo-uddi-server/pom.xml?
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ====================================================================
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-uddi-server/
>>> pom.xml (original)
>>> +++ geronimo/server/trunk/applications/geronimo-uddi-server/
>>> pom.xml Mon Jun 4 13:44:49 2007
>>> @@ -54,6 +54,9 @@
>>> <plugin>
>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>> <artifactId>jspc-maven-plugin</artifactId>
>>> + <configuration>
>>> + <injectString><!-- [INSERT FRAGMENT HERE]
>>> --></injectString>
>>> + </configuration>
>>> </plugin>
>>>
>>> <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-welcome/
>>> pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>>> applications/geronimo-welcome/pom.xml?
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ====================================================================
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>> (original)
>>> +++ geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>> Mon Jun 4 13:44:49 2007
>>> @@ -66,6 +66,9 @@
>>> <plugin>
>>> <groupId>org.codehaus.mojo.jspc</groupId>
>>> <artifactId>jspc-maven-plugin</artifactId>
>>> + <configuration>
>>> + <injectString><!-- [INSERT FRAGMENT HERE]
>>> --></injectString>
>>> + </configuration>
>>> </plugin>
>>>
>>> <plugin>
>>>
>>>
>>
>
Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Posted by Paul McMahan <pa...@gmail.com>.
GERONIMO-3209 shows a build error that I and two others hit. From a
brief conversation with Jeff on IRC, it seems that the current jspc
plugin no longer supports the default placeholder keyword used by the
geronimo applications:
<!-- [INSERT FRAGMENT HERE] -->
This commit fixes the build error.
Best wishes,
Paul
On Jun 4, 2007, at 6:38 PM, Jason Dillon wrote:
> Why is this needed?
>
> --jason
>
>
> On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote:
>
>> Author: pmcmahan
>> Date: Mon Jun 4 13:44:49 2007
>> New Revision: 544258
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=544258
>> Log:
>> GERONIMO-3209 jspc maven plugin fails in some environments when
>> the injectString is not explicitly declared
>>
>> Modified:
>> geronimo/server/trunk/applications/console/geronimo-console-
>> framework/pom.xml
>> geronimo/server/trunk/applications/console/geronimo-console-
>> standard/pom.xml
>> geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>> geronimo/server/trunk/applications/geronimo-examples/geronimo-
>> jsp-examples/pom.xml
>> geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>> geronimo/server/trunk/applications/geronimo-remote-deploy/pom.xml
>> geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
>> geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>
>> Modified: geronimo/server/trunk/applications/console/geronimo-
>> console-framework/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>> applications/console/geronimo-console-framework/pom.xml?
>> view=diff&rev=544258&r1=544257&r2=544258
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/applications/console/geronimo-console-
>> framework/pom.xml (original)
>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>> framework/pom.xml Mon Jun 4 13:44:49 2007
>> @@ -86,6 +86,9 @@
>> <plugin>
>> <groupId>org.codehaus.mojo.jspc</groupId>
>> <artifactId>jspc-maven-plugin</artifactId>
>> + <configuration>
>> + <injectString><!-- [INSERT FRAGMENT HERE]
>> --></injectString>
>> + </configuration>
>> </plugin>
>>
>> <plugin>
>>
>> Modified: geronimo/server/trunk/applications/console/geronimo-
>> console-standard/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>> applications/console/geronimo-console-standard/pom.xml?
>> view=diff&rev=544258&r1=544257&r2=544258
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/applications/console/geronimo-console-
>> standard/pom.xml (original)
>> +++ geronimo/server/trunk/applications/console/geronimo-console-
>> standard/pom.xml Mon Jun 4 13:44:49 2007
>> @@ -142,6 +142,9 @@
>> <plugin>
>> <groupId>org.codehaus.mojo.jspc</groupId>
>> <artifactId>jspc-maven-plugin</artifactId>
>> + <configuration>
>> + <injectString><!-- [INSERT FRAGMENT HERE]
>> --></injectString>
>> + </configuration>
>> </plugin>
>>
>> <plugin>
>>
>> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/
>> pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>> applications/geronimo-ca-helper/pom.xml?
>> view=diff&rev=544258&r1=544257&r2=544258
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>> (original)
>> +++ geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>> Mon Jun 4 13:44:49 2007
>> @@ -73,6 +73,9 @@
>> <plugin>
>> <groupId>org.codehaus.mojo.jspc</groupId>
>> <artifactId>jspc-maven-plugin</artifactId>
>> + <configuration>
>> + <injectString><!-- [INSERT FRAGMENT HERE]
>> --></injectString>
>> + </configuration>
>> </plugin>
>>
>> <plugin>
>>
>> Modified: geronimo/server/trunk/applications/geronimo-examples/
>> geronimo-jsp-examples/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml?
>> view=diff&rev=544258&r1=544257&r2=544258
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-
>> jsp-examples/pom.xml (original)
>> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-
>> jsp-examples/pom.xml Mon Jun 4 13:44:49 2007
>> @@ -60,6 +60,9 @@
>> <plugin>
>> <groupId>org.codehaus.mojo.jspc</groupId>
>> <artifactId>jspc-maven-plugin</artifactId>
>> + <configuration>
>> + <injectString><!-- [INSERT FRAGMENT HERE]
>> --></injectString>
>> + </configuration>
>> </plugin>
>>
>> <plugin>
>>
>> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/
>> pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>> applications/geronimo-ldap-demo/pom.xml?
>> view=diff&rev=544258&r1=544257&r2=544258
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>> (original)
>> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>> Mon Jun 4 13:44:49 2007
>> @@ -46,6 +46,9 @@
>> <plugin>
>> <groupId>org.codehaus.mojo.jspc</groupId>
>> <artifactId>jspc-maven-plugin</artifactId>
>> + <configuration>
>> + <injectString><!-- [INSERT FRAGMENT HERE]
>> --></injectString>
>> + </configuration>
>> </plugin>
>>
>> <plugin>
>>
>> Modified: geronimo/server/trunk/applications/geronimo-remote-
>> deploy/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>> applications/geronimo-remote-deploy/pom.xml?
>> view=diff&rev=544258&r1=544257&r2=544258
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/applications/geronimo-remote-deploy/
>> pom.xml (original)
>> +++ geronimo/server/trunk/applications/geronimo-remote-deploy/
>> pom.xml Mon Jun 4 13:44:49 2007
>> @@ -60,6 +60,9 @@
>> <plugin>
>> <groupId>org.codehaus.mojo.jspc</groupId>
>> <artifactId>jspc-maven-plugin</artifactId>
>> + <configuration>
>> + <injectString><!-- [INSERT FRAGMENT HERE]
>> --></injectString>
>> + </configuration>
>> </plugin>
>>
>> <plugin>
>>
>> Modified: geronimo/server/trunk/applications/geronimo-uddi-server/
>> pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>> applications/geronimo-uddi-server/pom.xml?
>> view=diff&rev=544258&r1=544257&r2=544258
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/applications/geronimo-uddi-server/
>> pom.xml (original)
>> +++ geronimo/server/trunk/applications/geronimo-uddi-server/
>> pom.xml Mon Jun 4 13:44:49 2007
>> @@ -54,6 +54,9 @@
>> <plugin>
>> <groupId>org.codehaus.mojo.jspc</groupId>
>> <artifactId>jspc-maven-plugin</artifactId>
>> + <configuration>
>> + <injectString><!-- [INSERT FRAGMENT HERE]
>> --></injectString>
>> + </configuration>
>> </plugin>
>>
>> <plugin>
>>
>> Modified: geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
>> applications/geronimo-welcome/pom.xml?
>> view=diff&rev=544258&r1=544257&r2=544258
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>> (original)
>> +++ geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>> Mon Jun 4 13:44:49 2007
>> @@ -66,6 +66,9 @@
>> <plugin>
>> <groupId>org.codehaus.mojo.jspc</groupId>
>> <artifactId>jspc-maven-plugin</artifactId>
>> + <configuration>
>> + <injectString><!-- [INSERT FRAGMENT HERE]
>> --></injectString>
>> + </configuration>
>> </plugin>
>>
>> <plugin>
>>
>>
>