You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Laszlo Pinter via Review Board <no...@reviews.apache.org> on 2018/10/25 13:37:00 UTC
Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/
-----------------------------------------------------------
Review request for hive and Peter Vary.
Repository: hive-git
Description
-------
HIVE-20796: jdbc URL can contain sensitive information that should not be logged
Diffs
-----
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
Diff: https://reviews.apache.org/r/69167/diff/1/
Testing
-------
New unit test created.
Thanks,
Laszlo Pinter
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210036
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Vary
On okt. 25, 2018, 1:36 du, Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated okt. 25, 2018, 1:36 du)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Laszlo Pinter via Review Board <no...@reviews.apache.org>.
> On Oct. 25, 2018, 4:48 p.m., Denys Kuzmenko wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
> > Lines 1163 (patched)
> > <https://reviews.apache.org/r/69167/diff/1/?file=2102460#file2102460line1163>
> >
> > Strings are immutable
done.
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210044
-----------------------------------------------------------
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by denys kuzmenko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210044
-----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
Lines 1163 (patched)
<https://reviews.apache.org/r/69167/#comment294689>
Strings are immutable
- denys kuzmenko
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Denys Kuzmenko via Review Board <no...@reviews.apache.org>.
> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
> > Lines 1172 (patched)
> > <https://reviews.apache.org/r/69167/diff/1/?file=2102460#file2102460line1172>
> >
> > Could be optimized to:
> >
> > String[] sensitiveData = {"user", "password"};
> > String regex = "([;,\?&]" + String.join("|", sensitiveData) + ")=.*?([;,&\)]+)";
> >
> > String result = Pattern.compile(regex).matcher(connectionURL).replaceAll("$1=***$2");
or just connectionURL.replaceAll(regex, "$1=***$2");
- Denys
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210059
-----------------------------------------------------------
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Laszlo Pinter via Review Board <no...@reviews.apache.org>.
> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
> > Lines 1172 (patched)
> > <https://reviews.apache.org/r/69167/diff/1/?file=2102460#file2102460line1172>
> >
> > Could be optimized to:
> >
> > String[] sensitiveData = {"user", "password"};
> > String regex = "([;,\?&]" + String.join("|", sensitiveData) + ")=.*?([;,&\)]+)";
> >
> > String result = Pattern.compile(regex).matcher(connectionURL).replaceAll("$1=***$2");
>
> Denys Kuzmenko wrote:
> or just connectionURL.replaceAll(regex, "$1=***$2");
>
> Denys Kuzmenko wrote:
> regex = "([;,?&]" + String.join("|", sensitiveData) + ")=.*?([;,&)]?)";
Thanks for the input. It's much shorter than my implementation.
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210059
-----------------------------------------------------------
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Denys Kuzmenko via Review Board <no...@reviews.apache.org>.
> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
> > Lines 1172 (patched)
> > <https://reviews.apache.org/r/69167/diff/1/?file=2102460#file2102460line1172>
> >
> > Could be optimized to:
> >
> > String[] sensitiveData = {"user", "password"};
> > String regex = "([;,\?&]" + String.join("|", sensitiveData) + ")=.*?([;,&\)]+)";
> >
> > String result = Pattern.compile(regex).matcher(connectionURL).replaceAll("$1=***$2");
>
> Denys Kuzmenko wrote:
> or just connectionURL.replaceAll(regex, "$1=***$2");
regex = "([;,?&]" + String.join("|", sensitiveData) + ")=.*?([;,&)]?)";
- Denys
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210059
-----------------------------------------------------------
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Denys Kuzmenko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210059
-----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
Lines 1172 (patched)
<https://reviews.apache.org/r/69167/#comment294699>
Could be optimized to:
String[] sensitiveData = {"user", "password"};
String regex = "([;,\?&]" + String.join("|", sensitiveData) + ")=.*?([;,&\)]+)";
String result = Pattern.compile(regex).matcher(connectionURL).replaceAll("$1=***$2");
- Denys Kuzmenko
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Laszlo Pinter via Review Board <no...@reviews.apache.org>.
> On Oct. 25, 2018, 4:44 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
> > Lines 1176 (patched)
> > <https://reviews.apache.org/r/69167/diff/1/?file=2102460#file2102460line1176>
> >
> > Nit: all the trendy kids use StringBuilder now
Removed StringBuffer
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210043
-----------------------------------------------------------
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Andrew Sherman via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210043
-----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
Lines 1176 (patched)
<https://reviews.apache.org/r/69167/#comment294688>
Nit: all the trendy kids use StringBuilder now
- Andrew Sherman
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by denys kuzmenko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210045
-----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
Lines 1164 (patched)
<https://reviews.apache.org/r/69167/#comment294690>
Opinion: I would go with a list of attributes to be masked
- denys kuzmenko
On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 1:36 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/1/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Denys Kuzmenko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/#review210088
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Kuzmenko
On Oct. 26, 2018, 10:34 a.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69167/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2018, 10:34 a.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20796: jdbc URL can contain sensitive information that should not be logged
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
>
>
> Diff: https://reviews.apache.org/r/69167/diff/2/
>
>
> Testing
> -------
>
> New unit test created.
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive
information that should not be logged
Posted by Laszlo Pinter via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69167/
-----------------------------------------------------------
(Updated Oct. 26, 2018, 10:34 a.m.)
Review request for hive and Peter Vary.
Repository: hive-git
Description
-------
HIVE-20796: jdbc URL can contain sensitive information that should not be logged
Diffs (updated)
-----
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 9c158040497cd3d2762620ce35e2b46bb6d5fffe
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java f3b38665676391fec9b85eb9a405c14632340dc6
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java f4bdd734dc4e731dda01e6031a4115cde5571baf
Diff: https://reviews.apache.org/r/69167/diff/2/
Changes: https://reviews.apache.org/r/69167/diff/1-2/
Testing
-------
New unit test created.
Thanks,
Laszlo Pinter