You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by DLotts <gi...@git.apache.org> on 2016/10/06 22:32:25 UTC
[GitHub] incubator-rya pull request #99: rya-177 WIP; indexing and mapreduce are now ...
GitHub user DLotts opened a pull request:
https://github.com/apache/incubator-rya/pull/99
rya-177 WIP; indexing and mapreduce are now optional profiles in Mave\u2026
## Description
>What Changed?
Made indexing and mapreduce modules part of profiles that are not built unless using one of these:
mvn ... -P indexing
mvn ... -P mapreduce
The purpose is to make geotools related features optional since it has an LGPL license.
Also under RYA-177 are removing several other less difficult dependencies.
TODO: remove Geo dependencies from top level POM.xml and find dependencies. They are marked with comments. Also remove other dependencies that have incompatible licenses.
### Tests
>Coverage?
No additional junit tests are needed. A good test is to run exactly this in the project root:
mvn license:aggregate-add-third-party
GeoTools should be missing. Also look for GPL and LGPL and some other incompatible licensed libraries. look on the rya dev list where I posted the subset of bad ones. It subject has the wrong issue number, here it is:
subject: RYA-179 Review License / Copyright notices on Rya Artifacts
found here: https://www.mail-archive.com/dev@rya.incubator.apache.org/msg00969.html
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-177)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
#### People To Reivew
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DLotts/incubator-rya RYA-177_incompatLicenseOptional
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit 714be87f230ea1da596870910206085b3e3e410d
Author: David W. Lotts <da...@parsons.com>
Date: 2016-10-06T21:54:40Z
rya-177 WIP; indexing and mapreduce are now optional profiles in Maven. TODO: remove Geo from top level POM and find dependencies.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #99: rya-177 WIP; indexing and mapreduce are now ...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/99#discussion_r82300811
--- Diff: pom.xml ---
@@ -77,7 +86,8 @@ under the License.
<zookeeper.version>3.4.6</zookeeper.version>
<pig.version>0.9.2</pig.version> <!-- Newest: 0.15.0 -->
-
+
+ <!-- Can we move geomesa to indexing? -->
--- End diff --
Here is the reason it is still WIP. To do, remove dependencies. I already copied them to the indexing pom.xml.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #99: rya-177 WIP; indexing and mapreduce are now optiona...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on the issue:
https://github.com/apache/incubator-rya/pull/99
Closing this un-pulled because of a better effort that only removed geo dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #99: rya-177 WIP; indexing and mapreduce are now ...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/99#discussion_r82300936
--- Diff: pom.xml ---
@@ -60,12 +60,21 @@ under the License.
<module>common</module>
<module>dao</module>
<module>extras</module>
- <module>mapreduce</module>
<module>osgi</module>
<module>pig</module>
<module>sail</module>
<module>web</module>
</modules>
+ <profiles>
+ <profile>
+ <id>mapreduce</id>
+ <modules>
+ <module>mapreduce</module>
+ <module>indexing</module>
+ <module>indexingSailExample</module>
--- End diff --
oops, indexingSailExample is old, delete this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #99: rya-177 WIP; indexing and mapreduce are now ...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts closed the pull request at:
https://github.com/apache/incubator-rya/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #99: rya-177 WIP; indexing and mapreduce are now optiona...
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the issue:
https://github.com/apache/incubator-rya/pull/99
A couple things:
I cannot do a `mvn clean install` . Apache rat breaks.
You need to remove more projects including:
- tinkerpop.rya
- web.rya
- rya.reasoning
- rya.console
- rya.merger
Also, I'd much rather you move all 10 of these "optional" project (listed below) to a top level directory named `optional`. Have a profile in the root pom named "build-optional" that enables the module in the `optional` directory.
Ten optional projects:
- mapreduce
- indexing
- rya.indexing.pcj
- indexingExample
- rya.pcj.fluo
- tinkerpop.rya
- web.rya
- rya.reasoning
- rya.console
- rya.merger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #99: rya-177 WIP; indexing and mapreduce are now ...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/99#discussion_r82300871
--- Diff: pom.xml ---
@@ -462,6 +472,7 @@ under the License.
</dependency>
<!-- Geo Indexing -->
+ <!-- Can we move geomesa to extras/indexing? -->
--- End diff --
See above. Todo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---