You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Yong Tang <yo...@outlook.com> on 2016/03/18 02:30:12 UTC

Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45011/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-4070
    https://issues.apache.org/jira/browse/MESOS-4070


Repository: mesos


Description
-------

This fix updated the implementation of numify() so that negative numbers
could be handled conssitently for hex and non-hex numbers.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 26a637bec1193dd51437bd689c34fbe6d1935d89 
  3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp 444377df00922df12d4b3ed25b4cfe9071cff5c3 

Diff: https://reviews.apache.org/r/45011/diff/


Testing
-------

make check (Ubuntu 14.04)


Thanks,

Yong Tang