You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/19 03:06:46 UTC

[GitHub] [spark] LuciferYang commented on pull request #34153: [SPARK-36796][BUILD][CORE][SQL] Pass all `sql/core` and dependent modules UTs with JDK 17 except one case in `postgreSQL/text.sql`

LuciferYang commented on pull request #34153:
URL: https://github.com/apache/spark/pull/34153#issuecomment-946327597


   > Do we need to wait on a resolution to the date difference here or treat it separately? would it mean we don't have to change the expected output?
   
   I created a new Jira  SPARK-37013 and https://github.com/apache/spark/pull/34153 try to fix the different string format behavior between Java 8 and Java 17, the relevant code has been removed from this pr.
   
   At present, this pr only adds the default `--add-opens` options and `-XX:+IgnoreUnrecognizedVMOptions` where needed, and passed UTs except `select format_string('%0$s', 'Hello')` in `postgreSQL/text.sql`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org