You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/13 16:50:20 UTC
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4747: Optimize seata at transaction manager
terrymanu commented on a change in pull request #4747: Optimize seata at transaction manager
URL: https://github.com/apache/incubator-shardingsphere/pull/4747#discussion_r392349397
##########
File path: sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/Constant.java
##########
@@ -17,31 +17,10 @@
package org.apache.shardingsphere.transaction.base.seata.at;
-import io.seata.core.context.RootContext;
-import org.apache.shardingsphere.underlying.executor.engine.ExecutorDataMap;
-
-import java.util.Map;
-
/**
- * Seata transaction broadcaster.
+ * Constant.
*/
-class SeataTransactionBroadcaster {
-
- private static final String SEATA_TX_XID = "SEATA_TX_XID";
+final class Constant {
Review comment:
Please do not use `Constant` as a class name, the scope of this name is too big, it is very easy conflict and misunderstanding with other modules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services