[GitHub] [beam] TSultanov commented on a diff in pull request #26235: [Playground] Make fields categories and context_line optional in examples tag

["TSultanov (via GitHub)" <gi...@apache.org>]

TSultanov commented on code in PR #26235:
URL: https://github.com/apache/beam/pull/26235#discussion_r1164219229


##########
playground/backend/internal/db/mapper/precompiled_object_mapper_test.go:
##########
@@ -40,7 +40,7 @@ func TestPrecompiledObjectMapper_ToObjectInfo(t *testing.T) {
 		Categories:      []string{"MOCK_CAT_1", "MOCK_CAT_2", "MOCK_CAT_3"},
 		PipelineOptions: "MOCK_OPTIONS",

Review Comment:
   This is internal data used only for test, the mock data used for local deployment is loaded form different place. I'm not if such change will be within the scope of this PR



##########
playground/backend/internal/db/mapper/precompiled_object_mapper_test.go:
##########
@@ -40,7 +40,7 @@ func TestPrecompiledObjectMapper_ToObjectInfo(t *testing.T) {
 		Categories:      []string{"MOCK_CAT_1", "MOCK_CAT_2", "MOCK_CAT_3"},
 		PipelineOptions: "MOCK_OPTIONS",

Review Comment:
   This data used only for this test, the mock data used for local deployment is loaded form different place. I'm not if such change will be within the scope of this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org