You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/07/16 09:39:39 UTC
[GitHub] [hbase] anoopsjohn commented on a change in pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…
anoopsjohn commented on a change in pull request #3493:
URL: https://github.com/apache/hbase/pull/3493#discussion_r671109693
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##########
@@ -1212,11 +1206,7 @@ public static Scan toScan(
if (proto.hasMvccReadPoint()) {
PackagePrivateFieldAccessor.setMvccReadPoint(scan, proto.getMvccReadPoint());
}
- if (scan.isSmall()) {
- scan.setReadType(Scan.ReadType.PREAD);
- } else if (proto.hasReadType()) {
- scan.setReadType(toReadType(proto.getReadType()));
- }
+ scan.setReadType(toReadType(proto.getReadType()));
Review comment:
Need if(proto.hasReadType()) check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org