You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org> on 2009/11/26 00:37:39 UTC
[jira] Created: (HADOOP-6394) Helper class for FileContext tests
Helper class for FileContext tests
----------------------------------
Key: HADOOP-6394
URL: https://issues.apache.org/jira/browse/HADOOP-6394
Project: Hadoop Common
Issue Type: Improvement
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791862#action_12791862 ]
Hudson commented on HADOOP-6394:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #149 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/149/])
HDFS-840. Change tests to use FileContext test helper introduced in . Contributed by Jitendra Nath Pandey.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785476#action_12785476 ]
Hadoop QA commented on HADOOP-6394:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12426800/HADOOP-6394.3.patch
against trunk revision 886645.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 34 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/162/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/162/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/162/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/162/console
This message is automatically generated.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Attachment: HADOOP-6394.5.patch
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Attachment: HADOOP-6394.2.patch
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-6394:
------------------------------------
Component/s: test
Affects Version/s: 0.22.0
0.21.0
Fix Version/s: 0.22.0
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-6394:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed the patch. Thank you Jitendra.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791922#action_12791922 ]
Hudson commented on HADOOP-6394:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #173 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/173/])
HDFS-840. Change tests to use FileContext test helper introduced in . Contributed by Jitendra Nath Pandey.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Status: Patch Available (was: Open)
HADOOP-6394.3.patch is submitted for Hudson tests
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791729#action_12791729 ]
Hudson commented on HADOOP-6394:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #120 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/120/])
. Add a helper class to simplify FileContext related tests and improve code reusability. Contributed by Jitendra Nath Pandey.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799016#action_12799016 ]
Hudson commented on HADOOP-6394:
--------------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #94 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/94/])
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791704#action_12791704 ]
Jitendra Nath Pandey commented on HADOOP-6394:
----------------------------------------------
The failure in TestUTF8 is unrelated to this patch.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Status: Open (was: Patch Available)
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Description:
A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
Examples of such methods:
createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
getTestRootPath(FileContext fc)
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791250#action_12791250 ]
Suresh Srinivas commented on HADOOP-6394:
-----------------------------------------
Comments:
# There are some empty line changes, can you please remove them
# There are some lines longer than 80 columns
# FileContextCreateMkdirBaseTest.java - Use shortened path to Log4JLogger
# FileContextURIBase.java - Add a method setup as in other base tests with @Before annotation to fix the warning in class javadoc
# When using FileContextTestHelper, do a static import to avoid having to call methods using FileContextHelper class prefix.
# FileContextTestHelper - pass the block size also as CreateOpts to FileContext create method.
# FileContextTestHelper - make defaultBlockSize and defaultNumBlocks final
# FileContextTestHelper - make the class final and add a private constructor
# FileContextTestHelper.getTestRoot() - rootPath should be created always as different tests could use different FileContexts.
# FileContextMainOperationsBaseTest.testWriteInNonExistentDirectory - not sure why this throws InterruptedException. There are other methods throwing InterruptedException as well
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Status: Open (was: Patch Available)
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791592#action_12791592 ]
Hadoop QA commented on HADOOP-6394:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12428221/HADOOP-6394.5.patch
against trunk revision 891132.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 33 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/210/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/210/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/210/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/210/console
This message is automatically generated.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Attachment: HADOOP-6394.1.patch
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785165#action_12785165 ]
Hadoop QA commented on HADOOP-6394:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12426744/HADOOP-6394.2.patch
against trunk revision 886645.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 34 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/161/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/161/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/161/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/161/console
This message is automatically generated.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Attachment: HADOOP-6394.3.patch
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Status: Patch Available (was: Open)
Patch HADOOP-6394.2.patch is submitted for hudson tests.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793383#action_12793383 ]
Hudson commented on HADOOP-6394:
--------------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #154 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/154/])
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791807#action_12791807 ]
Konstantin Boudnik commented on HADOOP-6394:
--------------------------------------------
HDFS build is failing after this modification:
{noformat}
compile-hdfs-test:
[javac] Compiling 143 source files to /home/cos/work/Hdfs/build/test/classes
[javac] /home/cos/work/Hdfs/src/test/hdfs/org/apache/hadoop/fs/TestHDFSFileContextMainOperations.java:102: cannot find symbol
[javac] symbol : method getTestRootPath(java.lang.String)
[javac] location: class org.apache.hadoop.fs.TestHDFSFileContextMainOperations
[javac] Path src1 = getTestRootPath("test/testOldRenameWithQuota/srcdir/src1");
[javac] ^
[javac] /home/cos/work/Hdfs/src/test/hdfs/org/apache/hadoop/fs/TestHDFSFileContextMainOperations.java:103: cannot find symbol
[javac] symbol : method getTestRootPath(java.lang.String)
[javac] location: class org.apache.hadoop.fs.TestHDFSFileContextMainOperations
[javac] Path src2 = getTestRootPath("test/testOldRenameWithQuota/srcdir/src2");
...
{noformat}
Hopefully it will be addressed by HDFS-840
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783942#action_12783942 ]
Suresh Srinivas commented on HADOOP-6394:
-----------------------------------------
Preliminary comments:
# No need to have many variants of createFile. Just one with all the params should suffice. Callers should call create with appropriate args. Otherwise we will have too many createFile methods one for each usecase.
# Changes are required in tests to use this helper class to remove duplicated code.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6394) Helper class for FileContext tests
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6394:
-----------------------------------------
Status: Patch Available (was: Open)
HADOOP-6394.5.patch submitted for Hudson tests.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6394) Helper class for FileContext tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791877#action_12791877 ]
Hudson commented on HADOOP-6394:
--------------------------------
Integrated in Hadoop-Common-trunk #190 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/190/])
. Add a helper class to simplify FileContext related tests and improve code reusability. Contributed by Jitendra Nath Pandey.
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.22.0
>
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch, HADOOP-6394.3.patch, HADOOP-6394.5.patch
>
>
> A helper class for FileContext tests should contain common methods which can be used in many unit tests, so that every unit test doesn't have to re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.