You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "David Law (Updated) (JIRA)" <de...@myfaces.apache.org> on 2012/01/14 14:45:39 UTC
[jira] [Updated] (MYFACES-3448) UISelectOne.validateValue(...)
optimised & refactored
[ https://issues.apache.org/jira/browse/MYFACES-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Law updated MYFACES-3448:
-------------------------------
Status: Patch Available (was: Open)
> UISelectOne.validateValue(...) optimised & refactored
> -----------------------------------------------------
>
> Key: MYFACES-3448
> URL: https://issues.apache.org/jira/browse/MYFACES-3448
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.1.5
> Reporter: David Law
> Priority: Minor
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The UISelectOne.validateValue(...) code is not particularly human-readable to say the least.
> Also, in the case of a match(the norm) the method this.isRequired() is called twice(!) if it returns false.
> Patch attached. (100% tested for all permutations of match, isRequired & NoSelection)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira