[GitHub] [airflow] feluelle commented on a change in pull request #11020: Fix AWS DataSync tests failing (#10985)

[GitBox <gi...@apache.org>]

feluelle commented on a change in pull request #11020:
URL: https://github.com/apache/airflow/pull/11020#discussion_r510700608



##########
File path: tests/providers/amazon/aws/hooks/test_batch_waiters.py
##########
@@ -305,13 +305,13 @@ def test_aws_batch_job_waiting(aws_clients, aws_region, job_queue_name, job_defi
     assert "Waiter JobComplete failed: Max attempts exceeded" in str(err.value)
 
     # wait for job to be running (or complete)
-    job_running_waiter.config.delay = 0.25  # sec delays between status checks
-    job_running_waiter.config.max_attempts = 50
+    job_running_waiter.config.delay = 1  # sec delays between status checks

Review comment:
       So that is the value you need to adjust?

##########
File path: tests/providers/amazon/aws/hooks/test_batch_waiters.py
##########
@@ -305,13 +305,13 @@ def test_aws_batch_job_waiting(aws_clients, aws_region, job_queue_name, job_defi
     assert "Waiter JobComplete failed: Max attempts exceeded" in str(err.value)
 
     # wait for job to be running (or complete)
-    job_running_waiter.config.delay = 0.25  # sec delays between status checks
-    job_running_waiter.config.max_attempts = 50
+    job_running_waiter.config.delay = 1  # sec delays between status checks
+    job_running_waiter.config.max_attempts = 100
     job_running_waiter.wait(jobs=[job_id])
 
     # wait for job completion
-    job_complete_waiter.config.delay = 0.25
-    job_complete_waiter.config.max_attempts = 50
+    job_complete_waiter.config.delay = 1

Review comment:
       Same here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org