You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by eowhadi <gi...@git.apache.org> on 2016/03/04 23:23:35 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1863] PR340 caused Pu...
GitHub user eowhadi opened a pull request:
https://github.com/apache/incubator-trafodion/pull/364
[TRAFODION-1863] PR340 caused PushdownV2 issues with column having non null default
since non null default columns are sometime resolved at select time, we need to disable pushdown for these.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eowhadi/incubator-trafodion jira1863
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #364
----
commit e9b02c2c37890626cccbb2e7fda40af0edc874c6
Author: Eric Owhadi <er...@esgyn.com>
Date: 2016-03-04T14:46:04Z
Fix jira1863. Pushdown V2 is disabled on columns with non null default as we are resolving default at select time and hbase don t know about the default values.
commit b929e6e20f66a5ce9f27f16ee90f4598519784bf
Author: Eric Owhadi <er...@esgyn.com>
Date: 2016-03-04T14:50:36Z
Merge branch 'master' of github.com:apache/incubator-trafodion into jira1863
commit 11c58b6d9e4331f01236bd588397189f2b626352
Author: Eric Owhadi <er...@esgyn.com>
Date: 2016-03-04T21:45:18Z
fix EXPECTED056 to remove the workaround introduced with PR340
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1863] PR340 caused Pu...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/364#discussion_r55272393
--- Diff: core/sql/generator/GenPreCode.cpp ---
@@ -11386,7 +11386,7 @@ NABoolean HbaseAccess::isHbaseFilterPredV2(Generator * generator, ItemExpr * ie,
}
//check if not an added column with default non null
if ((foundBinary || foundUnary)&& (NOT hbaseLookupPred)){
- if (colVID.isAddedColumnWithNonNullDefault()){
+ if (colVID.isColumnWithNonNullDefault()){
--- End diff --
Would a check for added columns with non-null default be sufficient for aligned format?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1863] PR340 caused Pu...
Posted by eowhadi <gi...@git.apache.org>.
Github user eowhadi commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/364#discussion_r55248094
--- Diff: core/sql/optimizer/ValueDesc.cpp ---
@@ -529,14 +529,13 @@ NABoolean ValueId::isAddedColumnWithNonNullDefault() const{
default:
break;
}
- if (nac && nac->isAddedColumn() && nac->getDefaultValue())
+ if (nac && nac->getDefaultValue() && strcmp(nac->getDefaultValue(),"NULL") != 0)
--- End diff --
why is it better? I know what I do work. I don't know about the alternative. But I know how much a re run of regression cost :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1863] PR340 caused Pu...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/364#discussion_r55246253
--- Diff: core/sql/optimizer/ValueDesc.cpp ---
@@ -529,14 +529,13 @@ NABoolean ValueId::isAddedColumnWithNonNullDefault() const{
default:
break;
}
- if (nac && nac->isAddedColumn() && nac->getDefaultValue())
+ if (nac && nac->getDefaultValue() && strcmp(nac->getDefaultValue(),"NULL") != 0)
--- End diff --
Will it be better to check for DefaultColumnClass == COM_NULL_DEFAULT instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1863] PR340 caused Pu...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/364#discussion_r55272540
--- Diff: core/sql/optimizer/ValueDesc.cpp ---
@@ -529,14 +529,13 @@ NABoolean ValueId::isAddedColumnWithNonNullDefault() const{
default:
break;
}
- if (nac && nac->isAddedColumn() && nac->getDefaultValue())
+ if (nac && nac->getDefaultValue() && strcmp(nac->getDefaultValue(),"NULL") != 0)
--- End diff --
Agree with Selva that checking the enum is safer and more maintainable. Maybe you can make this change in a future check-in, so you don't have to rerun the regressions just for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1863] PR340 caused Pu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/364
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1863] PR340 caused Pu...
Posted by eowhadi <gi...@git.apache.org>.
Github user eowhadi commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/364#discussion_r55273061
--- Diff: core/sql/generator/GenPreCode.cpp ---
@@ -11386,7 +11386,7 @@ NABoolean HbaseAccess::isHbaseFilterPredV2(Generator * generator, ItemExpr * ie,
}
//check if not an added column with default non null
if ((foundBinary || foundUnary)&& (NOT hbaseLookupPred)){
- if (colVID.isAddedColumnWithNonNullDefault()){
+ if (colVID.isColumnWithNonNullDefault()){
--- End diff --
this code is totally bypassed for align format
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---