You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2018/05/22 11:45:00 UTC
[jira] [Commented] (SOLR-11880) Avoid creating new exceptions for
every request made via MDCAwareThreadPoolExecutor
[ https://issues.apache.org/jira/browse/SOLR-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483820#comment-16483820 ]
Shalin Shekhar Mangar commented on SOLR-11880:
----------------------------------------------
Taking another look at this one. The distributed update and search requests are the most frequent users of this executor. Tracing each, I see that the Runnable added by HttpShardHandler.submit, SolrCmdDistributor.submit and StreamingSolrClients.ErrorReportingConcurrentUpdateSolrClient never throw any exceptions but they are tracked and logged as part of the shard response or similar classes. Therefore there is no point in creating an Exception object for these two usages. So, this patches adds another constructor for MDCAwareThreadPoolExecutor which disables the submitter stack trace for search and update use-cases.
> Avoid creating new exceptions for every request made via MDCAwareThreadPoolExecutor
> -----------------------------------------------------------------------------------
>
> Key: SOLR-11880
> URL: https://issues.apache.org/jira/browse/SOLR-11880
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Assignee: Noble Paul
> Priority: Minor
> Attachments: SOLR-11880.patch
>
>
> MDCAwareThreadPoolExecutor has this line in it's{{{execute}} method
>
> {code:java}
> final Exception submitterStackTrace = new Exception("Submitter stack trace");{code}
> This means that every call via the a thread pool will create this exception, and only when it sees an error will it be used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org