[GitHub] [samza] abhishekshivanna commented on a change in pull request #1290: SAMZA-2468: Make Standby containers respond to shutdown request

[GitBox <gi...@apache.org>]

abhishekshivanna commented on a change in pull request #1290: SAMZA-2468: Make Standby containers respond to shutdown request
URL: https://github.com/apache/samza/pull/1290#discussion_r384177870
 
 

 ##########
 File path: samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala
 ##########
 @@ -126,6 +126,45 @@ class TestSamzaContainer extends AssertionsForJUnit with MockitoSugar {
     verify(this.runLoop).run()
   }
 
+
+  @Test
+  def testShutDownSequenceForStandbyContainers() {
+    class ShutDownSignal(container: SamzaContainer) extends Runnable {
+      def run(): Unit = {
+        Thread.sleep(2000)
 
 Review comment:
   Can we do without the sleep in the test ?  Also, we should verify that the countdown() was actually called.
   I think it should be possible to test the behavior by making the latch visible for testing ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services