You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/01 21:26:49 UTC

[GitHub] [flink] Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)
URL: https://github.com/apache/flink/pull/6594#issuecomment-478754392
 
 
   Hi @becketqin 
   
   Thanks for the review! I've addressed most of them. Some I have not addressed yet because they are related to `MultipleIdsMessageAcknowledgingSourceBase`.
   
   We'll need to make a decision about `MultipleIdsMessageAcknowledgingSourceBase`. I am oke with replacing it with a class inside of the PubSub connector. But do realize it will almost be identical to `MultipleIdsMessageAcknowledgingSourceBase`. If you're oke with a bit of code deduplication I will add it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services